Skip to content

Commit

Permalink
[Fonts] initiateFontLoadingByAccessingGlyphDataIfApplicable() operate…
Browse files Browse the repository at this point in the history
…s on code units, not code points

https://bugs.webkit.org/show_bug.cgi?id=260768
rdar://114488476

Reviewed by Cameron McCormack.

It's meaningless to lookup fonts using individual surrogates.

* Source/WebCore/rendering/RenderText.cpp:
(WebCore::initiateFontLoadingByAccessingGlyphDataIfApplicable):

Canonical link: https://commits.webkit.org/267333@main
  • Loading branch information
litherum committed Aug 27, 2023
1 parent 2a288d2 commit 77879c8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Source/WebCore/rendering/RenderText.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -311,8 +311,8 @@ static void initiateFontLoadingByAccessingGlyphDataIfApplicable(const String& te
fontVariant = NormalVariant;
}
#endif
for (size_t i = 0; i < textContent.length(); ++i)
fontCascade.glyphDataForCharacter(textContent[i], false, fontVariant);
for (UChar32 character : StringView(textContent).codePoints())
fontCascade.glyphDataForCharacter(character, false, fontVariant);
}

void RenderText::styleDidChange(StyleDifference diff, const RenderStyle* oldStyle)
Expand Down

0 comments on commit 77879c8

Please sign in to comment.