Skip to content

Commit

Permalink
Cherry-pick 272062@main (3096c56). https://bugs.webkit.org/show_bug.c…
Browse files Browse the repository at this point in the history
…gi?id=265634

    Samesite=Lax is not always working in Safari
    https://bugs.webkit.org/show_bug.cgi?id=265634
    rdar://119362503

    Reviewed by Brent Fulgham and Alex Christensen.

    We were not setting isSameSite correctly when reading it from disk cache, which was then triggering different cookies being sent between
    speculative loads and the actual would be loads.
    Websites could use Vary Cookie headers to handle that case, but they do not tend to.

    * Source/WebKit/NetworkProcess/cache/NetworkCacheSubresourcesEntry.h:
    (WebKit::NetworkCache::SubresourceInfo::SubresourceInfo):

    Canonical link: https://commits.webkit.org/272062@main
  • Loading branch information
youennf authored and aperezdc committed Jan 26, 2024
1 parent 6afbe91 commit 78b6821
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,12 @@ class SubresourceInfo {
, m_lastSeen(lastSeen)
, m_firstSeen(firstSeen)
, m_isTransient(true) { }
SubresourceInfo(Key&& key, WallTime lastSeen, WallTime firstSeen, bool sameSite, bool isAppInitiated, URL&& firstPartyForCookies, WebCore::HTTPHeaderMap&& requestHeaders, WebCore::ResourceLoadPriority priority)
SubresourceInfo(Key&& key, WallTime lastSeen, WallTime firstSeen, bool isSameSite, bool isAppInitiated, URL&& firstPartyForCookies, WebCore::HTTPHeaderMap&& requestHeaders, WebCore::ResourceLoadPriority priority)
: m_key(WTFMove(key))
, m_lastSeen(lastSeen)
, m_firstSeen(firstSeen)
, m_isTransient(false)
, m_isSameSite(isSameSite)
, m_isAppInitiated(isAppInitiated)
, m_firstPartyForCookies(WTFMove(firstPartyForCookies))
, m_requestHeaders(WTFMove(requestHeaders))
Expand Down

0 comments on commit 78b6821

Please sign in to comment.