update FormData to latest spec webidl

https://bugs.webkit.org/show_bug.cgi?id=171589 Patch by Rob Buis <rbuis@igalia.com> on 2020-10-01 Reviewed by Alex Christensen. LayoutTests/imported/w3c: Update improved test result. * web-platform-tests/xhr/formdata-expected.txt: Source/WebCore: Change FormData contructor to not take optional, nullable parameter. Test: imported/w3c/web-platform-tests/xhr/formdata.html * html/DOMFormData.cpp: (WebCore::DOMFormData::DOMFormData): * html/DOMFormData.h: (WebCore::DOMFormData::create): * html/DOMFormData.idl: Canonical link: https://commits.webkit.org/229984@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267866 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit · Oct 2, 2020 · 7c10579 · 7c10579
1 parent eacfcbf
commit 7c10579
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 2 deletions.
diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
@@ -1,3 +1,14 @@
+2020-10-01  Rob Buis  <rbuis@igalia.com>
+
+        update FormData to latest spec webidl
+        https://bugs.webkit.org/show_bug.cgi?id=171589
+
+        Reviewed by Alex Christensen.
+
+        Update improved test result.
+
+        * web-platform-tests/xhr/formdata-expected.txt:
+
 2020-10-01  Alex Christensen  <achristensen@webkit.org>
 
         Non-special URLs are not idempotent

diff --git a/LayoutTests/imported/w3c/web-platform-tests/xhr/formdata-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/xhr/formdata-expected.txt
@@ -2,7 +2,7 @@
 
 
 
-FAIL Constructors should throw a type error assert_throws_js: function "() => { new FormData(null); }" did not throw
+PASS Constructors should throw a type error
 PASS empty formdata
 PASS formdata with string
 PASS formdata with named string

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
@@ -1,3 +1,21 @@
+2020-10-01  Rob Buis  <rbuis@igalia.com>
+
+        update FormData to latest spec webidl
+        https://bugs.webkit.org/show_bug.cgi?id=171589
+
+        Reviewed by Alex Christensen.
+
+        Change FormData contructor to not take optional, nullable
+        parameter.
+
+        Test: imported/w3c/web-platform-tests/xhr/formdata.html
+
+        * html/DOMFormData.cpp:
+        (WebCore::DOMFormData::DOMFormData):
+        * html/DOMFormData.h:
+        (WebCore::DOMFormData::create):
+        * html/DOMFormData.idl:
+
 2020-10-01  Sam Weinig  <weinig@apple.com>
 
         [WebIDL] Add support for non-nullable optional wrapper type arguments to operations

diff --git a/Source/WebCore/html/DOMFormData.idl b/Source/WebCore/html/DOMFormData.idl
@@ -37,7 +37,7 @@ typedef (File or USVString) FormDataEntryValue;
     InterfaceName=FormData,
     ImplementationLacksVTable,
 ] interface DOMFormData {
-    constructor(optional HTMLFormElement? form);
+    constructor(optional HTMLFormElement form);
 
     undefined append(USVString name, USVString value);
     undefined append(USVString name, Blob blobValue, optional USVString filename);