Skip to content

Commit

Permalink
Use smart pointer for connection in NetworkConnectionToWebProcess
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=268085
rdar://121619673

Reviewed by Chris Dumez.

* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::cookiesAdded):
(WebKit::NetworkConnectionToWebProcess::cookiesDeleted):
(WebKit::NetworkConnectionToWebProcess::allCookiesDeleted):
(WebKit::NetworkConnectionToWebProcess::entangleLocalPortInThisProcessToRemote):
(WebKit::NetworkConnectionToWebProcess::postMessageToRemote):
(WebKit::NetworkConnectionToWebProcess::broadcastConsoleMessage):
(WebKit::NetworkConnectionToWebProcess::addAllowedFirstPartyForCookies):

Canonical link: https://commits.webkit.org/273543@main
  • Loading branch information
szewai committed Jan 26, 2024
1 parent cfe51e0 commit 7c475be
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -917,17 +917,17 @@ void NetworkConnectionToWebProcess::unsubscribeFromCookieChangeNotifications(con

void NetworkConnectionToWebProcess::cookiesAdded(const String& host, const Vector<WebCore::Cookie>& cookies)
{
connection().send(Messages::NetworkProcessConnection::CookiesAdded(host, cookies), 0);
protectedConnection()->send(Messages::NetworkProcessConnection::CookiesAdded(host, cookies), 0);
}

void NetworkConnectionToWebProcess::cookiesDeleted(const String& host, const Vector<WebCore::Cookie>& cookies)
{
connection().send(Messages::NetworkProcessConnection::CookiesDeleted(host, cookies), 0);
protectedConnection()->send(Messages::NetworkProcessConnection::CookiesDeleted(host, cookies), 0);
}

void NetworkConnectionToWebProcess::allCookiesDeleted()
{
connection().send(Messages::NetworkProcessConnection::AllCookiesDeleted(), 0);
protectedConnection()->send(Messages::NetworkProcessConnection::AllCookiesDeleted(), 0);
}

#endif
Expand Down Expand Up @@ -1371,7 +1371,7 @@ void NetworkConnectionToWebProcess::entangleLocalPortInThisProcessToRemote(const

RefPtr channel = networkProcess().messagePortChannelRegistry().existingChannelContainingPort(local);
if (channel && channel->hasAnyMessagesPendingOrInFlight())
connection().send(Messages::NetworkProcessConnection::MessagesAvailableForPort(local), 0);
protectedConnection()->send(Messages::NetworkProcessConnection::MessagesAvailableForPort(local), 0);
}

void NetworkConnectionToWebProcess::messagePortDisentangled(const MessagePortIdentifier& port)
Expand Down Expand Up @@ -1417,15 +1417,15 @@ void NetworkConnectionToWebProcess::postMessageToRemote(MessageWithMessagePorts&
ASSERT(channel);
auto processIdentifier = channel->processForPort(port);
if (processIdentifier) {
if (auto* connectionToWebProcess = networkProcess().webProcessConnection(*processIdentifier))
connectionToWebProcess->connection().send(Messages::NetworkProcessConnection::MessagesAvailableForPort(port), 0);
if (RefPtr connectionToWebProcess = networkProcess().webProcessConnection(*processIdentifier))
connectionToWebProcess->protectedConnection()->send(Messages::NetworkProcessConnection::MessagesAvailableForPort(port), 0);
}
}
}

void NetworkConnectionToWebProcess::broadcastConsoleMessage(JSC::MessageSource source, JSC::MessageLevel level, const String& message)
{
connection().send(Messages::NetworkProcessConnection::BroadcastConsoleMessage(source, level, message), 0);
protectedConnection()->send(Messages::NetworkProcessConnection::BroadcastConsoleMessage(source, level, message), 0);
}

void NetworkConnectionToWebProcess::setCORSDisablingPatterns(WebCore::PageIdentifier pageIdentifier, Vector<String>&& patterns)
Expand Down Expand Up @@ -1507,7 +1507,7 @@ void NetworkConnectionToWebProcess::logOnBehalfOfWebContent(IPC::DataReference&&

void NetworkConnectionToWebProcess::addAllowedFirstPartyForCookies(const RegistrableDomain& firstPartyForCookies)
{
connection().send(Messages::NetworkProcessConnection::AddAllowedFirstPartyForCookies(firstPartyForCookies), 0);
protectedConnection()->send(Messages::NetworkProcessConnection::AddAllowedFirstPartyForCookies(firstPartyForCookies), 0);
}

void NetworkConnectionToWebProcess::useRedirectionForCurrentNavigation(WebCore::ResourceLoaderIdentifier identifier, WebCore::ResourceResponse&& response)
Expand Down

0 comments on commit 7c475be

Please sign in to comment.