Skip to content

Commit

Permalink
Use sendWithAsyncReply for NetworkMDNSRegister::RegisterMDNSName
Browse files Browse the repository at this point in the history 
https://bugs.webkit.org/show_bug.cgi?id=259657
rdar://113156914

Reviewed by Chris Dumez.

This removes an unnecessary message receiver and makes it more clear which code paths need to send a reply.

* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-output.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.cpp:
(WebKit::PendingRegistrationRequest::PendingRegistrationRequest):
(WebKit::registerMDNSNameCallback):
(WebKit::NetworkMDNSRegister::registerMDNSName):
(WebKit::pendingRegistrationRequests): Deleted.
* Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.h:
* Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.messages.in:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveMessage):
* Source/WebKit/WebProcess/Network/webrtc/WebMDNSRegister.cpp:
(WebKit::WebMDNSRegister::registerMDNSName):
* Source/WebKit/WebProcess/Network/webrtc/WebMDNSRegister.h:
* Source/WebKit/WebProcess/Network/webrtc/WebMDNSRegister.messages.in: Removed.

Canonical link: https://commits.webkit.org/266461@main
  • Loading branch information
@achristensen07
achristensen07 committed Jul 31, 2023
1 parent d7f0862 commit 7e04799
Show file tree
Hide file tree
Showing 14 changed files with 42 additions and 157 deletions.
1 change: 0 additions & 1 deletion Source/WebKit/CMakeLists.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,6 @@ set(WebKit_MESSAGES_IN_FILES

WebProcess/Network/webrtc/LibWebRTCNetwork
WebProcess/Network/webrtc/RTCDataChannelRemoteManager
WebProcess/Network/webrtc/WebMDNSRegister
WebProcess/Network/webrtc/WebRTCMonitor
WebProcess/Network/webrtc/WebRTCResolver

Expand Down
1 change: 0 additions & 1 deletion Source/WebKit/DerivedSources-output.xcfilelist
View file
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,6 @@ $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit/WebInspectorUIProxyMessages.h
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit/WebKitPlatformGeneratedSerializers.mm
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit/WebLockRegistryProxyMessageReceiver.cpp
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit/WebLockRegistryProxyMessages.h
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit/WebMDNSRegisterMessageReceiver.cpp
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit/WebMDNSRegisterMessages.h
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit/WebNotificationManagerMessageReceiver.cpp
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit/WebNotificationManagerMessages.h
Expand Down
1 change: 0 additions & 1 deletion Source/WebKit/DerivedSources.make
View file
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,6 @@ MESSAGE_RECEIVERS = \
WebProcess/Network/webrtc/LibWebRTCNetwork \
WebProcess/Network/webrtc/RTCDataChannelRemoteManager \
WebProcess/Network/webrtc/WebRTCMonitor \
WebProcess/Network/webrtc/WebMDNSRegister \
WebProcess/Network/webrtc/WebRTCResolver \
WebProcess/WebCoreSupport/RemoteWebLockRegistry \
WebProcess/WebCoreSupport/WebBroadcastChannelRegistry \
Expand Down
55 changes: 20 additions & 35 deletions Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

#include "Logging.h"
#include "NetworkConnectionToWebProcess.h"
#include "WebMDNSRegisterMessages.h"
#include <WebCore/MDNSRegisterError.h>
#include <pal/SessionID.h>
#include <wtf/UUID.h>
#include <wtf/text/StringConcatenateNumbers.h>
Expand Down Expand Up @@ -65,30 +65,21 @@ void NetworkMDNSRegister::unregisterMDNSNames(WebCore::ScriptExecutionContextIde

struct PendingRegistrationRequest {
WTF_MAKE_STRUCT_FAST_ALLOCATED;
PendingRegistrationRequest(Ref<NetworkConnectionToWebProcess>&& connection, MDNSRegisterIdentifier requestIdentifier, String&& name, PAL::SessionID sessionID)
PendingRegistrationRequest(Ref<NetworkConnectionToWebProcess>&& connection, String&& name, PAL::SessionID sessionID, CompletionHandler<void(const String&, std::optional<WebCore::MDNSRegisterError>)>&& completionHandler)
: connection(WTFMove(connection))
, requestIdentifier(requestIdentifier)
, name(WTFMove(name))
, sessionID(sessionID)
, completionHandler(WTFMove(completionHandler))
{
}

Ref<NetworkConnectionToWebProcess> connection;
MDNSRegisterIdentifier requestIdentifier;
String name;
PAL::SessionID sessionID;
DNSRecordRef record;
CompletionHandler<void(const String&, std::optional<WebCore::MDNSRegisterError>)> completionHandler;
};


static uintptr_t pendingRegistrationRequestCount = 1;
static HashMap<uintptr_t, std::unique_ptr<PendingRegistrationRequest>>& pendingRegistrationRequests()
{
ASSERT(RunLoop::isMain());
static NeverDestroyed<HashMap<uintptr_t, std::unique_ptr<PendingRegistrationRequest>>> map;
return map;
}

void NetworkMDNSRegister::closeAndForgetService(DNSServiceRef service)
{
DNSServiceRefDeallocate(service);
Expand All @@ -98,24 +89,21 @@ void NetworkMDNSRegister::closeAndForgetService(DNSServiceRef service)
});
}

static void registerMDNSNameCallback(DNSServiceRef service, DNSRecordRef record, DNSServiceFlags, DNSServiceErrorType errorCode, void *context)
static void registerMDNSNameCallback(DNSServiceRef service, DNSRecordRef record, DNSServiceFlags, DNSServiceErrorType errorCode, void* context)
{
auto request = pendingRegistrationRequests().take(reinterpret_cast<uintptr_t>(context));
if (!request)
return;
std::unique_ptr<PendingRegistrationRequest> request { reinterpret_cast<PendingRegistrationRequest*>(context) };

MDNS_RELEASE_LOG_IN_CALLBACK(request->sessionID, "registerMDNSNameCallback with error %d", errorCode);

if (errorCode) {
request->connection->mdnsRegister().closeAndForgetService(service);
request->connection->connection().send(Messages::WebMDNSRegister::FinishedRegisteringMDNSName { request->requestIdentifier, request->name, WebCore::MDNSRegisterError::DNSSD }, 0);

request->completionHandler(request->name, WebCore::MDNSRegisterError::DNSSD);
return;
}
request->connection->connection().send(Messages::WebMDNSRegister::FinishedRegisteringMDNSName { request->requestIdentifier, request->name, { } }, 0);
request->completionHandler(request->name, { });
}

void NetworkMDNSRegister::registerMDNSName(MDNSRegisterIdentifier requestIdentifier, WebCore::ScriptExecutionContextIdentifier documentIdentifier, const String& ipAddress)
void NetworkMDNSRegister::registerMDNSName(WebCore::ScriptExecutionContextIdentifier documentIdentifier, const String& ipAddress, CompletionHandler<void(const String&, std::optional<WebCore::MDNSRegisterError>)>&& completionHandler)
{
auto name = makeString(WTF::UUID::createVersion4(), ".local"_s);

Expand All @@ -125,14 +113,12 @@ void NetworkMDNSRegister::registerMDNSName(MDNSRegisterIdentifier requestIdentif
auto error = DNSServiceCreateConnection(&service);
if (error) {
MDNS_RELEASE_LOG("registerMDNSName DNSServiceCreateConnection error %d", error);
m_connection.connection().send(Messages::WebMDNSRegister::FinishedRegisteringMDNSName { requestIdentifier, name, WebCore::MDNSRegisterError::DNSSD }, 0);
return;
return completionHandler(name, WebCore::MDNSRegisterError::DNSSD);
}
error = DNSServiceSetDispatchQueue(service, dispatch_get_main_queue());
if (error) {
MDNS_RELEASE_LOG("registerMDNSName DNSServiceCreateConnection error %d", error);
m_connection.connection().send(Messages::WebMDNSRegister::FinishedRegisteringMDNSName { requestIdentifier, name, WebCore::MDNSRegisterError::DNSSD }, 0);
return;
return completionHandler(name, WebCore::MDNSRegisterError::DNSSD);
}
ASSERT(service);
m_services.add(documentIdentifier, service);
Expand All @@ -144,11 +130,10 @@ void NetworkMDNSRegister::registerMDNSName(MDNSRegisterIdentifier requestIdentif
// FIXME: Add IPv6 support.
if (ip == ( in_addr_t)(-1)) {
MDNS_RELEASE_LOG("registerMDNSName inet_addr error");
m_connection.connection().send(Messages::WebMDNSRegister::FinishedRegisteringMDNSName { requestIdentifier, name, WebCore::MDNSRegisterError::BadParameter }, 0);
return;
return completionHandler(name, WebCore::MDNSRegisterError::BadParameter);
}

auto pendingRequest = makeUnique<PendingRegistrationRequest>(m_connection, requestIdentifier, WTFMove(name), sessionID());
auto* pendingRequest = new PendingRegistrationRequest(m_connection, WTFMove(name), sessionID(), WTFMove(completionHandler));
auto* record = &pendingRequest->record;
auto error = DNSServiceRegisterRecord(service,
record,
Expand All @@ -165,34 +150,34 @@ void NetworkMDNSRegister::registerMDNSName(MDNSRegisterIdentifier requestIdentif
&ip,
0,
registerMDNSNameCallback,
reinterpret_cast<void*>(pendingRegistrationRequestCount));
pendingRequest);
if (error) {
MDNS_RELEASE_LOG("registerMDNSName DNSServiceRegisterRecord error %d", error);

DNSServiceRefDeallocate(service);
m_services.remove(documentIdentifier);

m_connection.connection().send(Messages::WebMDNSRegister::FinishedRegisteringMDNSName { requestIdentifier, pendingRequest->name, WebCore::MDNSRegisterError::DNSSD }, 0);
pendingRequest->completionHandler(pendingRequest->name, WebCore::MDNSRegisterError::DNSSD);
delete pendingRequest;
return;
}
pendingRegistrationRequests().add(pendingRegistrationRequestCount++, WTFMove(pendingRequest));
}

#else
#else // ENABLE_MDNS

void NetworkMDNSRegister::unregisterMDNSNames(WebCore::ScriptExecutionContextIdentifier)
{
}

void NetworkMDNSRegister::registerMDNSName(MDNSRegisterIdentifier requestIdentifier, WebCore::ScriptExecutionContextIdentifier documentIdentifier, const String& ipAddress)
void NetworkMDNSRegister::registerMDNSName(WebCore::ScriptExecutionContextIdentifier documentIdentifier, const String& ipAddress, CompletionHandler<void(const String&, std::optional<WebCore::MDNSRegisterError>)>&& completionHandler)
{
MDNS_RELEASE_LOG("registerMDNSName not implemented");
auto name = makeString(WTF::UUID::createVersion4(), ".local"_s);

m_connection.connection().send(Messages::WebMDNSRegister::FinishedRegisteringMDNSName { requestIdentifier, name, WebCore::MDNSRegisterError::NotImplemented }, 0);
completionHandler(name, WebCore::MDNSRegisterError::NotImplemented);
}

#endif
#endif // ENABLE_MDNS

PAL::SessionID NetworkMDNSRegister::sessionID() const
{
Expand Down
9 changes: 6 additions & 3 deletions Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@

#if ENABLE(WEB_RTC)

#include "MDNSRegisterIdentifier.h"
#include "RTCNetwork.h"
#include <WebCore/ProcessQualified.h>
#include <WebCore/ScriptExecutionContextIdentifier.h>
Expand All @@ -54,6 +53,10 @@ namespace PAL {
class SessionID;
}

namespace WebCore {
enum class MDNSRegisterError;
}

namespace WebKit {

class NetworkConnectionToWebProcess;
Expand All @@ -71,8 +74,8 @@ class NetworkMDNSRegister {

private:
void unregisterMDNSNames(WebCore::ScriptExecutionContextIdentifier);
void registerMDNSName(MDNSRegisterIdentifier, WebCore::ScriptExecutionContextIdentifier, const String& ipAddress);
void registerMDNSName(WebCore::ScriptExecutionContextIdentifier, const String& ipAddress, CompletionHandler<void(const String&, std::optional<WebCore::MDNSRegisterError>)>&&);

PAL::SessionID sessionID() const;

NetworkConnectionToWebProcess& m_connection;
Expand Down
2 changes: 1 addition & 1 deletion Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.messages.in
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

messages -> NetworkMDNSRegister NotRefCounted {
UnregisterMDNSNames(WebCore::ScriptExecutionContextIdentifier documentIdentifier)
RegisterMDNSName(WebKit::MDNSRegisterIdentifier requestIdentifier, WebCore::ScriptExecutionContextIdentifier documentIdentifier, String ipAddress)
RegisterMDNSName(WebCore::ScriptExecutionContextIdentifier documentIdentifier, String ipAddress) -> (String mdnsName, std::optional<WebCore::MDNSRegisterError> error)
}

#endif // ENABLE(WEB_RTC)
1 change: 0 additions & 1 deletion Source/WebKit/Scripts/webkit/messages.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,6 @@ def serialized_identifiers():
'WebKit::IPCStreamTesterIdentifier',
'WebKit::LegacyCustomProtocolID',
'WebKit::LibWebRTCResolverIdentifier',
'WebKit::MDNSRegisterIdentifier',
'WebKit::MarkSurfacesAsVolatileRequestIdentifier',
'WebKit::MediaRecorderIdentifier',
'WebKit::NetworkResourceLoadIdentifier',
Expand Down
3 changes: 0 additions & 3 deletions Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
#include "JSIPCBinding.h"
#include "LegacyCustomProtocolID.h"
#include "LibWebRTCResolverIdentifier.h"
#include "MDNSRegisterIdentifier.h"
#include "MarkSurfacesAsVolatileRequestIdentifier.h"
#include "MediaRecorderIdentifier.h"
#include "NetworkResourceLoadIdentifier.h"
Expand Down Expand Up @@ -457,7 +456,6 @@ Vector<ASCIILiteral> serializedIdentifiers()
static_assert(sizeof(uint64_t) == sizeof(WebKit::IPCStreamTesterIdentifier));
static_assert(sizeof(uint64_t) == sizeof(WebKit::LegacyCustomProtocolID));
static_assert(sizeof(uint64_t) == sizeof(WebKit::LibWebRTCResolverIdentifier));
static_assert(sizeof(uint64_t) == sizeof(WebKit::MDNSRegisterIdentifier));
static_assert(sizeof(uint64_t) == sizeof(WebKit::MarkSurfacesAsVolatileRequestIdentifier));
static_assert(sizeof(uint64_t) == sizeof(WebKit::MediaRecorderIdentifier));
static_assert(sizeof(uint64_t) == sizeof(WebKit::NetworkResourceLoadIdentifier));
Expand Down Expand Up @@ -557,7 +555,6 @@ Vector<ASCIILiteral> serializedIdentifiers()
"WebKit::IPCStreamTesterIdentifier"_s,
"WebKit::LegacyCustomProtocolID"_s,
"WebKit::LibWebRTCResolverIdentifier"_s,
"WebKit::MDNSRegisterIdentifier"_s,
"WebKit::MarkSurfacesAsVolatileRequestIdentifier"_s,
"WebKit::MediaRecorderIdentifier"_s,
"WebKit::NetworkResourceLoadIdentifier"_s,
Expand Down
8 changes: 0 additions & 8 deletions Source/WebKit/WebKit.xcodeproj/project.pbxproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1141,7 +1141,6 @@
51F060E11654318500F3281F /* WebRTCMonitorMessageReceiver.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 51F060DD1654317500F3281F /* WebRTCMonitorMessageReceiver.cpp */; };
51F060E11654318500F3282C /* WebRTCResolverMessageReceiver.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 51F060DD1654317500F3282C /* WebRTCResolverMessageReceiver.cpp */; };
51F060E11654318500F3282E /* NetworkRTCProviderMessageReceiver.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 51F060DD1654317500F3282E /* NetworkRTCProviderMessageReceiver.cpp */; };
51F060E11654318500F3282F /* WebMDNSRegisterMessageReceiver.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 51F060DD1654317500F3282F /* WebMDNSRegisterMessageReceiver.cpp */; };
51F060E11654318500F3283F /* NetworkMDNSRegisterMessageReceiver.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 51F060DD1654317500F3283F /* NetworkMDNSRegisterMessageReceiver.cpp */; };
51F886A61F2C228100C193EF /* WKTestingSupport.h in Headers */ = {isa = PBXBuildFile; fileRef = 51F886A41F2C214A00C193EF /* WKTestingSupport.h */; settings = {ATTRIBUTES = (Private, ); }; };
51FAEC3A1B0657630009C4E7 /* AuxiliaryProcessMessages.h in Headers */ = {isa = PBXBuildFile; fileRef = 51FAEC371B0657310009C4E7 /* AuxiliaryProcessMessages.h */; };
Expand Down Expand Up @@ -4532,7 +4531,6 @@
41684C4D24643BFA001CE8ED /* RemoteCaptureSampleManager.messages.in */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = RemoteCaptureSampleManager.messages.in; sourceTree = "<group>"; };
41684C4E24643C81001CE8ED /* RemoteCaptureSampleManager.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RemoteCaptureSampleManager.h; sourceTree = "<group>"; };
41684C4F24643D3F001CE8ED /* RemoteCaptureSampleManager.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = RemoteCaptureSampleManager.cpp; sourceTree = "<group>"; };
416CD74523FB178B00661D99 /* MDNSRegisterIdentifier.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = MDNSRegisterIdentifier.h; path = Network/webrtc/MDNSRegisterIdentifier.h; sourceTree = "<group>"; };
416EDC052600F6B000092675 /* RTCDataChannelRemoteManager.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; name = RTCDataChannelRemoteManager.cpp; path = Network/webrtc/RTCDataChannelRemoteManager.cpp; sourceTree = "<group>"; };
416EDC062600F6B000092675 /* RTCDataChannelRemoteManager.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = RTCDataChannelRemoteManager.h; path = Network/webrtc/RTCDataChannelRemoteManager.h; sourceTree = "<group>"; };
416F8086245B397400B68F02 /* LibWebRTCNetwork.messages.in */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; name = LibWebRTCNetwork.messages.in; path = Network/webrtc/LibWebRTCNetwork.messages.in; sourceTree = "<group>"; };
Expand Down Expand Up @@ -4581,7 +4579,6 @@
41B28B081F83AD3E00FB52AC /* RTCPacketOptions.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RTCPacketOptions.h; sourceTree = "<group>"; };
41B28B091F83AD3E00FB52AC /* RTCPacketOptions.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = RTCPacketOptions.cpp; sourceTree = "<group>"; };
41B7ED6C20681DCE0087D853 /* WebMDNSRegister.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = WebMDNSRegister.h; path = Network/webrtc/WebMDNSRegister.h; sourceTree = "<group>"; };
41B7ED6D20681DCF0087D853 /* WebMDNSRegister.messages.in */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; name = WebMDNSRegister.messages.in; path = Network/webrtc/WebMDNSRegister.messages.in; sourceTree = "<group>"; };
41B7ED6E20681DCF0087D853 /* WebMDNSRegister.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = WebMDNSRegister.cpp; path = Network/webrtc/WebMDNSRegister.cpp; sourceTree = "<group>"; };
41B7ED6F206965900087D853 /* NetworkMDNSRegister.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = NetworkMDNSRegister.cpp; sourceTree = "<group>"; };
41B7ED70206965900087D853 /* NetworkMDNSRegister.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NetworkMDNSRegister.h; sourceTree = "<group>"; };
Expand Down Expand Up @@ -5038,7 +5035,6 @@
51F060DD1654317500F3281F /* WebRTCMonitorMessageReceiver.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = WebRTCMonitorMessageReceiver.cpp; sourceTree = "<group>"; };
51F060DD1654317500F3282C /* WebRTCResolverMessageReceiver.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = WebRTCResolverMessageReceiver.cpp; sourceTree = "<group>"; };
51F060DD1654317500F3282E /* NetworkRTCProviderMessageReceiver.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = NetworkRTCProviderMessageReceiver.cpp; sourceTree = "<group>"; };
51F060DD1654317500F3282F /* WebMDNSRegisterMessageReceiver.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = WebMDNSRegisterMessageReceiver.cpp; sourceTree = "<group>"; };
51F060DD1654317500F3283F /* NetworkMDNSRegisterMessageReceiver.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = NetworkMDNSRegisterMessageReceiver.cpp; sourceTree = "<group>"; };
51F060DE1654317500F3281B /* WebResourceLoaderMessages.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WebResourceLoaderMessages.h; sourceTree = "<group>"; };
51F7BB74274498BA00C45A72 /* MockAppBundleForTesting.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = MockAppBundleForTesting.mm; sourceTree = "<group>"; };
Expand Down Expand Up @@ -10387,13 +10383,11 @@
413075A01DE85EE70039EC69 /* LibWebRTCSocket.h */,
413075A51DE85EE70039EC69 /* LibWebRTCSocketFactory.cpp */,
413075A61DE85EE70039EC69 /* LibWebRTCSocketFactory.h */,
416CD74523FB178B00661D99 /* MDNSRegisterIdentifier.h */,
416EDC052600F6B000092675 /* RTCDataChannelRemoteManager.cpp */,
416EDC062600F6B000092675 /* RTCDataChannelRemoteManager.h */,
411223B72602152B00B0A0B6 /* RTCDataChannelRemoteManager.messages.in */,
41B7ED6E20681DCF0087D853 /* WebMDNSRegister.cpp */,
41B7ED6C20681DCE0087D853 /* WebMDNSRegister.h */,
41B7ED6D20681DCF0087D853 /* WebMDNSRegister.messages.in */,
413075A21DE85EE70039EC69 /* WebRTCMonitor.cpp */,
413075A31DE85EE70039EC69 /* WebRTCMonitor.h */,
413075A41DE85EE70039EC69 /* WebRTCMonitor.messages.in */,
Expand Down Expand Up @@ -13530,7 +13524,6 @@
1CA8B943127C882A00576C2B /* WebInspectorUIProxyMessageReceiver.cpp */,
1CA8B944127C882A00576C2B /* WebInspectorUIProxyMessages.h */,
5C9E0F972A577EC400FC2664 /* WebKitPlatformGeneratedSerializers.mm */,
51F060DD1654317500F3282F /* WebMDNSRegisterMessageReceiver.cpp */,
31BA9248148830810062EDB5 /* WebNotificationManagerMessageReceiver.cpp */,
31BA9249148830810062EDB5 /* WebNotificationManagerMessages.h */,
C0CE729E1247E71D00BC0EC4 /* WebPageMessageReceiver.cpp */,
Expand Down Expand Up @@ -17397,7 +17390,6 @@
1A6280F31919982A006AD9F9 /* WebKit.m in Sources */,
A181A79821ACC74B0059A316 /* WebKitAdditions.mm in Sources */,
CDF1B91B267025550007EC10 /* WebKitSwiftSoftLink.mm in Sources */,
51F060E11654318500F3282F /* WebMDNSRegisterMessageReceiver.cpp in Sources */,
E3816B3D27E2463A005EAFC0 /* WebMockContentFilterManager.cpp in Sources */,
31BA924D148831260062EDB5 /* WebNotificationManagerMessageReceiver.cpp in Sources */,
2DF6FE52212E110900469030 /* WebPage.cpp in Sources */,
Expand Down
Loading

0 comments on commit 7e04799

Please sign in to comment.