Skip to content

Commit

Permalink
REGRESSION(266513@main?): [ macOS Monterey+ Debug WK1 ] media/modern-…
Browse files Browse the repository at this point in the history
…media-controls/tracks-support/text-track-selected-via-media-api.html is a constant timeout (259546)

https://bugs.webkit.org/show_bug.cgi?id=263257
rdar://112952952

Reviewed by Jer Noble.

Changing WebKit1 test expectation for media/modern-media-controls/tracks-support/text-track-selected-via-media-api.html to "skip."
This test times out because it waits for the tracks button to appear in the bottom media controls bar, which never happens. The
test sets maximumRightContainerButtonCountOverride to 100, which should allow for the tracks button to be shown, but this does not
work for some reason, and so the maximumRightContainerButtonCount maintains its default value of 2, which only allows for AirPlay
and overflow buttons to appear. It does not feel important to fix this right now because maximumRightContainerButtonCountOverride
is only available in testing anyways, so the tracks button is never expected in any non-testing application.

* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/269437@main
  • Loading branch information
danae404 committed Oct 18, 2023
1 parent 2b68151 commit 7e993de
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion LayoutTests/platform/mac-wk1/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -2592,7 +2592,7 @@ fast/html/transient-activation.html [ Skip ]

webkit.org/b/259485 [ Ventura+ ] http/tests/media/hls/track-in-band-multiple-cues.html [ Crash ]

webkit.org/b/259546 [ Debug ] media/modern-media-controls/tracks-support/text-track-selected-via-media-api.html [ Crash Timeout ]
webkit.org/b/259546 [ Debug ] media/modern-media-controls/tracks-support/text-track-selected-via-media-api.html [ Skip ]

webkit.org/b/260070 fast/selectors/style-invalidation-hover-change-descendants.html [ Pass Failure ]
webkit.org/b/260070 fast/selectors/style-invalidation-hover-change-siblings.html [ Failure ]
Expand Down

0 comments on commit 7e993de

Please sign in to comment.