Skip to content

Commit

Permalink
REGRESSION (270071@main): [ Sonoma wk2 ] 2 tests in imported/w3c/web-…
Browse files Browse the repository at this point in the history
…platform-tests/css/ are consistent failures

https://bugs.webkit.org/show_bug.cgi?id=266684
rdar://119902392

Unreviewed test expectations gardening.

The following CSS WPTs were always behaving differently with async
overflow scrolling enabled:
- css-overscroll-behavior/overscroll-behavior.html
- css-scroll-snap/input/snap-area-overflow-boundary.html

Unfortunately, this failure never surfaced in open source EWS since I
simply skipped over these tests for any macOS target. Instead, this
commit skips these tests in more specific platform configurations (where
it is necessary), and adjust the test output accordingly.

This test also adds a drive-by expectation adjustment to reflect that
the html/semantics/popovers/popover-light-dismiss.html WPT no longer
behaves as expected after enabling async overflow scrolling.

* LayoutTests/imported/w3c/web-platform-tests/css/css-overscroll-behavior/overscroll-behavior-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/input/snap-area-overflow-boundary-expected.txt:
* LayoutTests/platform/mac-ventura-wk2/TestExpectations:
* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/272340@main
  • Loading branch information
aprotyas committed Dec 20, 2023
1 parent 8d1371e commit 7e9e2cf
Show file tree
Hide file tree
Showing 5 changed files with 25 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ Repeat the same scrolls as in step 1 and then tap on DONE.
Repeat the same scrolls as in step 1 and then tap on DONE.
Make two separate scrolls on GREEN, in this order: scroll UP (or drag down), then scroll LEFT (or drag right). Scroll (or drag) until nothing is scrolling. Then tap on DONE.

FAIL overscroll-behavior prevents scroll-propagation in the area and direction as specified assert_equals: expected 0 but got 100
PASS overscroll-behavior prevents scroll-propagation in the area and direction as specified

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Header 1Footer 1
Header 2Footer 2

FAIL Keyboard scrolling with vertical snap-area overflow assert_equals: End boundary of snap-area is valid snap target expected 39 but got 449
FAIL Keyboard scrolling with vertical snap-area overflow assert_equals: Verify snap on relayout expected 0 but got 40
FAIL Mouse-wheel scrolling with vertical snap-area overflow assert_equals: End boundary of snap-area is valid snap target expected 100 but got 101

11 changes: 11 additions & 0 deletions LayoutTests/platform/mac-ventura-wk2/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,14 @@ imported/w3c/web-platform-tests/css/cssom-view/scroll-behavior-smooth-positions.

# This feature was introduced in macOS Sonoma.
http/tests/paymentrequest/paymentrequest-applePayLaterAvailability.https.html [ Skip ]

# webkit.org/b/263476 [ mac-wk2 ] Some WPTs exercising wheel actions interface timing out on pre-Sonoma macOS after 269632@main
imported/w3c/web-platform-tests/css/css-overscroll-behavior/overscroll-behavior.html [ Skip ]
imported/w3c/web-platform-tests/css/css-scroll-snap/input/snap-area-overflow-boundary.html [ Skip ]
imported/w3c/web-platform-tests/css/css-transforms/scroll-preserve-3d.html [ Skip ]
imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/non-passive-mousewheel-event-listener-on-div.html [ Skip ]
imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/non-passive-wheel-event-listener-on-div.html [ Skip ]
imported/w3c/web-platform-tests/dom/events/scrolling/iframe-chains.html [ Skip ]
imported/w3c/web-platform-tests/dom/events/scrolling/scrollend-event-for-user-scroll.html [ Skip ]
imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss.html [ Skip ]
imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-mouse.html [ Skip ]
11 changes: 11 additions & 0 deletions LayoutTests/platform/mac-wk1/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -2735,3 +2735,14 @@ webkit.org/b/266184 compositing/images/truncated-direct-png-image.html [ ImageOn
# webkit.org/b/266345 [Test Gardening] css-contain/contain-size-block-003.html and css-contain/contain-size-inline-block-003.html only fail on GTK
imported/w3c/web-platform-tests/css/css-contain/contain-size-block-003.html [ Failure ]
imported/w3c/web-platform-tests/css/css-contain/contain-size-inline-block-003.html [ Failure ]

# webkit.org/b/263441 [ mac-wk1 ] Several WPTs using wheel actions are timing out after 269632@main
imported/w3c/web-platform-tests/css/css-overscroll-behavior/overscroll-behavior.html [ Skip ]
imported/w3c/web-platform-tests/css/css-scroll-snap/input/snap-area-overflow-boundary.html [ Skip ]
imported/w3c/web-platform-tests/css/css-transforms/scroll-preserve-3d.html [ Skip ]
imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/non-passive-mousewheel-event-listener-on-div.html [ Skip ]
imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/non-passive-wheel-event-listener-on-div.html [ Skip ]
imported/w3c/web-platform-tests/dom/events/scrolling/iframe-chains.html [ Skip ]
imported/w3c/web-platform-tests/dom/events/scrolling/scrollend-event-for-user-scroll.html [ Skip ]
imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss.html [ Skip ]
imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-mouse.html [ Skip ]
12 changes: 1 addition & 11 deletions LayoutTests/platform/mac/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -2542,17 +2542,7 @@ imported/w3c/web-platform-tests/media-source/mediasource-redundant-seek.html [ P
imported/w3c/web-platform-tests/media-source/mediasource-remove-preserves-currentTime.html [ Pass Failure ]
imported/w3c/web-platform-tests/media-source/mediasource-remove.html [ Pass Failure ]

# webkit.org/b/263441 [ mac-wk1 ] Several WPTs using wheel actions are timing out after b243272
# webkit.org/b/263476 [ mac-wk2 ] Some WPTs exercising wheel actions interface timing out on pre-Sonoma MacOS after b243272
imported/w3c/web-platform-tests/css/css-overscroll-behavior/overscroll-behavior.html [ Skip ]
imported/w3c/web-platform-tests/css/css-scroll-snap/input/snap-area-overflow-boundary.html [ Skip ]
imported/w3c/web-platform-tests/css/css-transforms/scroll-preserve-3d.html [ Skip ]
imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/non-passive-mousewheel-event-listener-on-div.html [ Skip ]
imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/non-passive-wheel-event-listener-on-div.html [ Skip ]
imported/w3c/web-platform-tests/dom/events/scrolling/iframe-chains.html [ Skip ]
imported/w3c/web-platform-tests/dom/events/scrolling/scrollend-event-for-user-scroll.html [ Skip ]
imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss.html [ Skip ]
imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-mouse.html [ Skip ]
webkit.org/b/266683 imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss.html [ Failure ]

# Failing word-break: auto-phrase tests.
webkit.org/b/257698 [ Sonoma+ ] imported/w3c/web-platform-tests/css/css-text/word-break/auto-phrase/word-break-auto-phrase-004.html [ ImageOnlyFailure ]
Expand Down

0 comments on commit 7e9e2cf

Please sign in to comment.