Skip to content

Commit

Permalink
Remove Source/WebCore/display and LayoutFormattingContextEnabled pref…
Browse files Browse the repository at this point in the history
…erence

https://bugs.webkit.org/show_bug.cgi?id=265505
rdar://118914665

Reviewed by Simon Fraser.

This code is currently not being used, it was a prototype of LFC painting, but perhaps may not be the future.

Remove it to avoid unnecessary maintenance and to free up the Display namespace.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/Headers.cmake:
* Source/WebCore/Sources.txt:
* Source/WebCore/display/DisplayGeometryTypes.h: Removed.
* Source/WebCore/display/DisplayTree.cpp: Removed.
* Source/WebCore/display/DisplayTree.h: Removed.
* Source/WebCore/display/DisplayTreeBuilder.cpp: Removed.
* Source/WebCore/display/DisplayTreeBuilder.h: Removed.
* Source/WebCore/display/DisplayView.cpp: Removed.
* Source/WebCore/display/DisplayView.h: Removed.
* Source/WebCore/display/ReadMe.md: Removed.
* Source/WebCore/display/compositing/DisplayLayerController.cpp: Removed.
* Source/WebCore/display/compositing/DisplayLayerController.h: Removed.
* Source/WebCore/display/css/DisplayBox.cpp: Removed.
* Source/WebCore/display/css/DisplayBox.h: Removed.
* Source/WebCore/display/css/DisplayBoxClip.cpp: Removed.
* Source/WebCore/display/css/DisplayBoxClip.h: Removed.
* Source/WebCore/display/css/DisplayBoxDecorationData.cpp: Removed.
* Source/WebCore/display/css/DisplayBoxDecorationData.h: Removed.
* Source/WebCore/display/css/DisplayBoxDecorationPainter.cpp: Removed.
* Source/WebCore/display/css/DisplayBoxDecorationPainter.h: Removed.
* Source/WebCore/display/css/DisplayBoxFactory.cpp: Removed.
* Source/WebCore/display/css/DisplayBoxFactory.h: Removed.
* Source/WebCore/display/css/DisplayBoxModelBox.cpp: Removed.
* Source/WebCore/display/css/DisplayBoxModelBox.h: Removed.
* Source/WebCore/display/css/DisplayBoxPainter.cpp: Removed.
* Source/WebCore/display/css/DisplayBoxPainter.h: Removed.
* Source/WebCore/display/css/DisplayBoxRareGeometry.cpp: Removed.
* Source/WebCore/display/css/DisplayBoxRareGeometry.h: Removed.
* Source/WebCore/display/css/DisplayCSSPainter.cpp: Removed.
* Source/WebCore/display/css/DisplayCSSPainter.h: Removed.
* Source/WebCore/display/css/DisplayContainerBox.cpp: Removed.
* Source/WebCore/display/css/DisplayContainerBox.h: Removed.
* Source/WebCore/display/css/DisplayFillLayerImageGeometry.cpp: Removed.
* Source/WebCore/display/css/DisplayFillLayerImageGeometry.h: Removed.
* Source/WebCore/display/css/DisplayImageBox.cpp: Removed.
* Source/WebCore/display/css/DisplayImageBox.h: Removed.
* Source/WebCore/display/css/DisplayPaintingContext.h: Removed.
* Source/WebCore/display/css/DisplayReplacedBox.cpp: Removed.
* Source/WebCore/display/css/DisplayReplacedBox.h: Removed.
* Source/WebCore/display/css/DisplayStackingItem.cpp: Removed.
* Source/WebCore/display/css/DisplayStackingItem.h: Removed.
* Source/WebCore/display/css/DisplayStyle.cpp: Removed.
* Source/WebCore/display/css/DisplayStyle.h: Removed.
* Source/WebCore/display/css/DisplayTextBox.cpp: Removed.
* Source/WebCore/display/css/DisplayTextBox.h: Removed.
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::flushCompositingStateForThisFrame):
(WebCore::LocalFrameView::setIsInWindow):
(WebCore::LocalFrameView::existingDisplayView const): Deleted.
(WebCore::LocalFrameView::displayView): Deleted.
* Source/WebCore/page/LocalFrameView.h:
* Source/WebCore/page/Page.cpp:
(WebCore::Page::doAfterUpdateRendering):
* Tools/DumpRenderTree/mac/DumpRenderTree.mm:
(setWebPreferencesForTestOptions):

Canonical link: https://commits.webkit.org/271264@main
  • Loading branch information
nt1m committed Nov 29, 2023
1 parent 4352256 commit 7eb9a06
Show file tree
Hide file tree
Showing 51 changed files with 1 addition and 6,401 deletions.
14 changes: 0 additions & 14 deletions Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3657,20 +3657,6 @@ LayoutFallbackWidth:
WebCore:
default: 980

LayoutFormattingContextEnabled:
type: bool
status: unstable
category: dom
humanReadableName: "Full next-generation layout (LFC)"
humanReadableDescription: "Enable full next-generation layout (LFC)"
defaultValue:
WebKitLegacy:
default: false
WebKit:
default: false
WebCore:
default: false

LayoutViewportHeightExpansionFactor:
type: double
status: embedder
Expand Down
3 changes: 0 additions & 3 deletions Source/WebCore/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,6 @@ set(WebCore_PRIVATE_INCLUDE_DIRECTORIES
"${WEBCORE_DIR}/css/typedom/numeric"
"${WEBCORE_DIR}/css/typedom/transform"
"${WEBCORE_DIR}/cssjit"
"${WEBCORE_DIR}/display"
"${WEBCORE_DIR}/display/compositing"
"${WEBCORE_DIR}/display/css"
"${WEBCORE_DIR}/dom"
"${WEBCORE_DIR}/dom/messageports"
"${WEBCORE_DIR}/domjit"
Expand Down
13 changes: 0 additions & 13 deletions Source/WebCore/Headers.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -886,19 +886,6 @@ set(WebCore_PRIVATE_FRAMEWORK_HEADERS

cssjit/CompiledSelector.h

display/DisplayTree.h
display/DisplayTreeBuilder.h
display/DisplayView.h

display/compositing/DisplayLayerController.h

display/css/DisplayBox.h
display/css/DisplayCSSPainter.h
display/css/DisplayContainerBox.h
display/css/DisplayImageBox.h
display/css/DisplayReplacedBox.h
display/css/DisplayStyle.h

dom/AbortSignal.h
dom/AbstractRange.h
dom/ActiveDOMCallback.h
Expand Down
20 changes: 0 additions & 20 deletions Source/WebCore/Sources.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1021,26 +1021,6 @@ css/typedom/transform/CSSTransformComponent.cpp
css/typedom/transform/CSSTransformValue.cpp
css/typedom/transform/CSSTranslate.cpp
cssjit/SelectorCompiler.cpp
display/compositing/DisplayLayerController.cpp
display/css/DisplayBox.cpp
display/css/DisplayBoxClip.cpp
display/css/DisplayBoxDecorationData.cpp
display/css/DisplayBoxDecorationPainter.cpp
display/css/DisplayBoxFactory.cpp
display/css/DisplayBoxModelBox.cpp
display/css/DisplayBoxPainter.cpp
display/css/DisplayBoxRareGeometry.cpp
display/css/DisplayContainerBox.cpp
display/css/DisplayCSSPainter.cpp
display/css/DisplayFillLayerImageGeometry.cpp
display/css/DisplayImageBox.cpp
display/css/DisplayReplacedBox.cpp
display/css/DisplayStackingItem.cpp
display/css/DisplayStyle.cpp
display/css/DisplayTextBox.cpp
display/DisplayTree.cpp
display/DisplayTreeBuilder.cpp
display/DisplayView.cpp
dom/AbortController.cpp
dom/AbortSignal.cpp
dom/AbstractRange.cpp
Expand Down
60 changes: 0 additions & 60 deletions Source/WebCore/display/DisplayGeometryTypes.h

This file was deleted.

59 changes: 0 additions & 59 deletions Source/WebCore/display/DisplayTree.cpp

This file was deleted.

63 changes: 0 additions & 63 deletions Source/WebCore/display/DisplayTree.h

This file was deleted.

Loading

0 comments on commit 7eb9a06

Please sign in to comment.