Skip to content

Commit

Permalink
Merge r247427 - [GTK] GitHub breaks on FreeBSD because of "unsupporte…
Browse files Browse the repository at this point in the history
…d browser"

https://bugs.webkit.org/show_bug.cgi?id=199745

Reviewed by Carlos Garcia Campos.

It's been a while since I last updated the fake version numbers in our user agent, both for
the user agent quirks for naughty websites and also the Safari version in our standard user
agent. Update them. This should fix github.com on FreeBSD at least. I also noticed some
wonkiness on Google Docs recently that I thought required this update, but I didn't do
anything about it at the time because I wasn't able to reproduce the issue when I tried
again later.

This could absolutely break websites, because the web is awful, but that's calculated risk.

* platform/UserAgentQuirks.cpp:
(WebCore::UserAgentQuirks::stringForQuirk):
* platform/glib/UserAgentGLib.cpp:
(WebCore::buildUserAgentString):
  • Loading branch information
mcatanzaro committed Aug 4, 2019
1 parent 3c14320 commit 7f087e6
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 3 deletions.
21 changes: 21 additions & 0 deletions Source/WebCore/ChangeLog
@@ -1,3 +1,24 @@
2019-07-15 Michael Catanzaro <mcatanzaro@igalia.com>

[GTK] GitHub breaks on FreeBSD because of "unsupported browser"
https://bugs.webkit.org/show_bug.cgi?id=199745

Reviewed by Carlos Garcia Campos.

It's been a while since I last updated the fake version numbers in our user agent, both for
the user agent quirks for naughty websites and also the Safari version in our standard user
agent. Update them. This should fix github.com on FreeBSD at least. I also noticed some
wonkiness on Google Docs recently that I thought required this update, but I didn't do
anything about it at the time because I wasn't able to reproduce the issue when I tried
again later.

This could absolutely break websites, because the web is awful, but that's calculated risk.

* platform/UserAgentQuirks.cpp:
(WebCore::UserAgentQuirks::stringForQuirk):
* platform/glib/UserAgentGLib.cpp:
(WebCore::buildUserAgentString):

2019-07-10 Enrique Ocaña González <eocanha@igalia.com>

[GStreamer] Protect against null samples and samples with null buffers
Expand Down
4 changes: 2 additions & 2 deletions Source/WebCore/platform/UserAgentQuirks.cpp
Expand Up @@ -138,9 +138,9 @@ String UserAgentQuirks::stringForQuirk(UserAgentQuirk quirk)
switch (quirk) {
case NeedsChromeBrowser:
// Get versions from https://chromium.googlesource.com/chromium/src.git
return "Chrome/58.0.3029.81"_s;
return "Chrome/75.0.3770.141"_s;
case NeedsMacintoshPlatform:
return "Macintosh; Intel Mac OS X 10_13_4"_s;
return "Macintosh; Intel Mac OS X 10_15"_s;
case NeedsLinuxDesktopPlatform:
return "X11; Linux x86_64"_s;
case NumUserAgentQuirks:
Expand Down
2 changes: 1 addition & 1 deletion Source/WebCore/platform/glib/UserAgentGLib.cpp
Expand Up @@ -103,7 +103,7 @@ static String buildUserAgentString(const UserAgentQuirks& quirks)

// Version/X is mandatory *before* Safari/X to be a valid Safari UA. See
// https://bugs.webkit.org/show_bug.cgi?id=133403 for details.
uaString.appendLiteral("Version/11.0 Safari/");
uaString.appendLiteral("Version/13.0 Safari/");
uaString.append(versionForUAString());

return uaString.toString();
Expand Down

0 comments on commit 7f087e6

Please sign in to comment.