Skip to content

Commit

Permalink
Need a fake mouse move after hiding data detectors UI
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=139608
-and corresponding-
rdar://problem/19221935

Reviewed by Tim Horton.

Source/WebCore:

* WebCore.exp.in:

Source/WebKit2:

* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::dataDetectorsDidHideUI):



Canonical link: https://commits.webkit.org/157493@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177253 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
dethbakin committed Dec 13, 2014
1 parent 184a673 commit 82e8926
Show file tree
Hide file tree
Showing 4 changed files with 28 additions and 0 deletions.
11 changes: 11 additions & 0 deletions Source/WebCore/ChangeLog
@@ -1,3 +1,14 @@
2014-12-12 Beth Dakin <bdakin@apple.com>

Need a fake mouse move after hiding data detectors UI
https://bugs.webkit.org/show_bug.cgi?id=139608
-and corresponding-
rdar://problem/19221935

Reviewed by Tim Horton.

* WebCore.exp.in:

2014-12-12 Dean Jackson <dino@apple.com>

[Media iOS] Inline video controls have an outlined scrubber
Expand Down
1 change: 1 addition & 0 deletions Source/WebCore/WebCore.exp.in
Expand Up @@ -221,6 +221,7 @@ __ZN7WebCore12EventHandler20hitTestResultAtPointERKNS_11LayoutPointEjRKNS_10Layo
__ZN7WebCore12EventHandler21handleMousePressEventERKNS_18PlatformMouseEventE
__ZN7WebCore12EventHandler23handleMouseReleaseEventERKNS_18PlatformMouseEventE
__ZN7WebCore12EventHandler24logicalScrollRecursivelyENS_22ScrollLogicalDirectionENS_17ScrollGranularityEPNS_4NodeE
__ZN7WebCore12EventHandler30dispatchFakeMouseMoveEventSoonEv
__ZN7WebCore12EventHandler30setCapturingMouseEventsElementEN3WTF10PassRefPtrINS_7ElementEEE
__ZN7WebCore12EventHandler31passMouseMovedEventToScrollbarsERKNS_18PlatformMouseEventE
__ZN7WebCore12EventHandler8keyEventERKNS_21PlatformKeyboardEventE
Expand Down
12 changes: 12 additions & 0 deletions Source/WebKit2/ChangeLog
@@ -1,3 +1,15 @@
2014-12-12 Beth Dakin <bdakin@apple.com>

Need a fake mouse move after hiding data detectors UI
https://bugs.webkit.org/show_bug.cgi?id=139608
-and corresponding-
rdar://problem/19221935

Reviewed by Tim Horton.

* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::dataDetectorsDidHideUI):

2014-12-12 Anders Carlsson <andersca@apple.com>

Handle caches in WebsiteDataStore
Expand Down
4 changes: 4 additions & 0 deletions Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm
Expand Up @@ -1115,6 +1115,10 @@ static void drawPDFPage(PDFDocument *pdfDocument, CFIndex pageIndex, CGContextRe
void WebPage::dataDetectorsDidHideUI(PageOverlay::PageOverlayID overlayID)
{
MainFrame& mainFrame = corePage()->mainFrame();

// Dispatching a fake mouse event will allow clients to display any UI that is normally displayed on hover.
mainFrame.eventHandler().dispatchFakeMouseMoveEventSoon();

for (const auto& overlay : mainFrame.pageOverlayController().pageOverlays()) {
if (overlay->pageOverlayID() == overlayID) {
if (WebPageOverlay* webOverlay = WebPageOverlay::fromCoreOverlay(*overlay))
Expand Down

0 comments on commit 82e8926

Please sign in to comment.