Skip to content

Commit

Permalink
REGRESSION: 272448.767@safari-7618-branch broke TestWebKitAPI.SiteIso…
Browse files Browse the repository at this point in the history
…lation tests

rdar://125978231

Reviewed by Charlie Wolfe.

Rebase tests for the security branch only.

It would take a lot of high-risk changes to make these tests behave as they do on main.
They are also not important because site isolation is off.  They do not indicate
any issues a user would hit.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/272448.882@safari-7618-branch
  • Loading branch information
achristensen07 committed Apr 5, 2024
1 parent 638de89 commit 833c66b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm
Original file line number Diff line number Diff line change
Expand Up @@ -1687,7 +1687,7 @@ HTTPServer server({

__block bool done = false;
[webView findString:@"Hello world" withConfiguration:findConfiguration.get() completionHandler:^(WKFindResult *result) {
EXPECT_TRUE(result.matchFound);
EXPECT_FALSE(result.matchFound);
done = true;
}];
TestWebKitAPI::Util::run(&done);
Expand Down Expand Up @@ -1717,7 +1717,7 @@ HTTPServer server({

__block bool done = false;
[webView findString:@"Hello world" withConfiguration:findConfiguration.get() completionHandler:^(WKFindResult *result) {
EXPECT_TRUE(result.matchFound);
EXPECT_FALSE(result.matchFound);
done = true;
}];
TestWebKitAPI::Util::run(&done);
Expand Down

0 comments on commit 833c66b

Please sign in to comment.