Skip to content

Commit

Permalink
Stub out dNR completionHandlers for unimplemented methods.
Browse files Browse the repository at this point in the history
https://webkit.org/b/265944
rdar://problem/119261044

Reviewed by Brian Weinstein.

* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIDeclarativeNetRequestCocoa.mm:
(WebKit::WebExtensionAPIDeclarativeNetRequest::updateDynamicRules): Call callback.
(WebKit::WebExtensionAPIDeclarativeNetRequest::getDynamicRules): Ditto.
(WebKit::WebExtensionAPIDeclarativeNetRequest::updateSessionRules): Ditto.
(WebKit::WebExtensionAPIDeclarativeNetRequest::getSessionRules): Ditto.

Canonical link: https://commits.webkit.org/271623@main
  • Loading branch information
xeenon committed Dec 6, 2023
1 parent 0cab9f4 commit 84e50b6
Showing 1 changed file with 8 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -90,24 +90,28 @@
}, extensionContext().identifier());
}

void WebExtensionAPIDeclarativeNetRequest::updateDynamicRules(NSDictionary *options, Ref<WebExtensionCallbackHandler>&&, NSString **outExceptionString)
void WebExtensionAPIDeclarativeNetRequest::updateDynamicRules(NSDictionary *options, Ref<WebExtensionCallbackHandler>&& callback, NSString **outExceptionString)
{
// FIXME: rdar://118476702 - Support dynamic rules
callback->call();
}

void WebExtensionAPIDeclarativeNetRequest::getDynamicRules(Ref<WebExtensionCallbackHandler>&&)
void WebExtensionAPIDeclarativeNetRequest::getDynamicRules(Ref<WebExtensionCallbackHandler>&& callback)
{
// FIXME: rdar://118476702 - Support dynamic rules
callback->call(@[ ]);
}

void WebExtensionAPIDeclarativeNetRequest::updateSessionRules(NSDictionary *options, Ref<WebExtensionCallbackHandler>&&, NSString **outExceptionString)
void WebExtensionAPIDeclarativeNetRequest::updateSessionRules(NSDictionary *options, Ref<WebExtensionCallbackHandler>&& callback, NSString **outExceptionString)
{
// FIXME: rdar://118476774 - Support session rules
callback->call();
}

void WebExtensionAPIDeclarativeNetRequest::getSessionRules(Ref<WebExtensionCallbackHandler>&&)
void WebExtensionAPIDeclarativeNetRequest::getSessionRules(Ref<WebExtensionCallbackHandler>&& callback)
{
// FIXME: rdar://118476774 - Support session rules
callback->call(@[ ]);
}

static bool extensionHasPermission(WebExtensionContextProxy& extensionContext, NSString *permission)
Expand Down

0 comments on commit 84e50b6

Please sign in to comment.