Skip to content

Commit

Permalink
Enable Vorbis support on iOS
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=263109
rdar://116776158

Reviewed by Youenn Fablet.

Add entitlements for iOS support.
Fly-by: move mac entitlements to the webcontent_shared_entitlements.

Covered by existing tests, however no possibility of testing on iOS at
this stage due to lack of framework support.

* Source/WebKit/Scripts/process-entitlements.sh:

Canonical link: https://commits.webkit.org/269327@main
  • Loading branch information
jyavenard committed Oct 13, 2023
1 parent c5710af commit 8535231
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions Source/WebKit/Scripts/process-entitlements.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@ function mac_process_webcontent_entitlements()
plistbuddy Add :com.apple.avfoundation.allow-system-wide-context bool YES
plistbuddy add :com.apple.QuartzCore.webkit-limited-types bool YES
fi
if (( "${TARGET_MAC_OS_X_VERSION_MAJOR}" >= 120000 ))
then
plistbuddy add :com.apple.coreaudio.allow-vorbis-decode bool YES
fi
if (( "${TARGET_MAC_OS_X_VERSION_MAJOR}" >= 130000 ))
then
plistbuddy Add :com.apple.private.gpu-restricted bool YES
Expand Down Expand Up @@ -65,10 +61,6 @@ function mac_process_webcontent_captiveportal_entitlements()
plistbuddy Add :com.apple.avfoundation.allow-system-wide-context bool YES
plistbuddy add :com.apple.QuartzCore.webkit-limited-types bool YES
fi
if (( "${TARGET_MAC_OS_X_VERSION_MAJOR}" >= 120000 ))
then
plistbuddy add :com.apple.coreaudio.allow-vorbis-decode bool YES
fi
if (( "${TARGET_MAC_OS_X_VERSION_MAJOR}" >= 130000 ))
then
plistbuddy Add :com.apple.private.gpu-restricted bool YES
Expand Down Expand Up @@ -205,6 +197,7 @@ function mac_process_webcontent_shared_entitlements()
then
plistbuddy Add :com.apple.private.verified-jit bool YES
plistbuddy Add :com.apple.security.cs.single-jit bool YES
plistbuddy add :com.apple.coreaudio.allow-vorbis-decode bool YES
fi

if (( "${TARGET_MAC_OS_X_VERSION_MAJOR}" >= 130000 ))
Expand Down Expand Up @@ -368,6 +361,7 @@ function ios_family_process_webcontent_shared_entitlements()
plistbuddy Add :com.apple.private.webkit.use-xpc-endpoint bool YES
plistbuddy Add :com.apple.runningboard.assertions.webkit bool YES
plistbuddy Add :com.apple.private.sandbox.profile string com.apple.WebKit.WebContent
plistbuddy add :com.apple.coreaudio.allow-vorbis-decode bool YES
webcontent_sandbox_entitlements
}

Expand Down Expand Up @@ -436,6 +430,8 @@ function ios_family_process_gpu_entitlements()
plistbuddy Add :com.apple.security.exception.mach-lookup.global-name:0 string com.apple.systemstatus.activityattribution
plistbuddy Add :com.apple.private.attribution.explicitly-assumed-identities array
plistbuddy Add :com.apple.private.attribution.explicitly-assumed-identities:0:type string wildcard

plistbuddy add :com.apple.coreaudio.allow-vorbis-decode bool YES
}

function ios_family_process_adattributiond_entitlements()
Expand Down

0 comments on commit 8535231

Please sign in to comment.