Please sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
2011-05-19 Jer Noble <email@example.com>
Reviewed by Maciej Stachowiak. WebKit2: Flashing when entering and exiting full screen mode https://bugs.webkit.org/show_bug.cgi?id=56957 Guard against the parameter of setAnimating() matching the ivar value it's setting, thus avoiding tearing down the renderer's layer backing. * rendering/RenderFullScreen.cpp: (RenderFullScreen::setAnimating): 2011-05-19 Jer Noble <firstname.lastname@example.org> Reviewed by Maciej Stachowiak. WebKit2: Flashing when entering and exiting full screen mode https://bugs.webkit.org/show_bug.cgi?id=56957 In the WKFullscreenWindowController, when exiting accelerated compositing mode, force a repaint, and don't actually remove the animation layer until the repaint completes. Also, move back to parenting the WebView in a layer-backed view, and work around the SnowLeopard bug which causes a crash in those situations. We no longer need to do a bunch of work in finishedEnterFullScreenAnimation, because the animation layer is "hiding" all the drawing happening in the webView underneath. In the WebFullScreenManagerMac, when asked to tear down the root layer, instead remove all its children, and set its contents to a flattened image of the full screen element and its children. This helps patch over the time where everything is re-rendering and helps give the appearance of continuousness in the animation. * UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): (-[WKFullScreenWindowController beganExitFullScreenAnimation]): (-[WKFullScreenWindowController enterAcceleratedCompositingMode:WebKit::]): (-[WKFullScreenWindowController exitAcceleratedCompositingMode]): (-[WKFullScreenWindowController exitCompositedModeRepaintCompleted]): (exitCompositedModeRepaintCompleted): (-[WKFullScreenWindowController _page]): (-[WKFullScreenWindowController _manager]): (-[WKFullScreenWindow initWithContentRect:styleMask:backing:defer:]): * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Canonical link: https://commits.webkit.org/76528@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing with 94 additions and 16 deletions.