Skip to content

Commit

Permalink
Cleanup #undefs in JSGlobalObject.cpp
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=263762

Reviewed by Keith Miller.

1. CREATE_PROTOTYPE_FOR_LAZY_TYPE has its #undef >600 lines later than expected; move it to its rightful location.
2. CREATE_WEBASSEMBLY_CONSTRUCTOR doesn't exist; we mean to be #undefing CREATE_WEBASSEMBLY_PROTOTYPE.

* Source/JavaScriptCore/runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):

Canonical link: https://commits.webkit.org/269868@main
  • Loading branch information
rkirsling authored and donny-dont committed Oct 27, 2023
1 parent 3abfea5 commit 87241d5
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions Source/JavaScriptCore/runtime/JSGlobalObject.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1099,6 +1099,8 @@ void JSGlobalObject::init(VM& vm)
}

FOR_EACH_LAZY_BUILTIN_TYPE(CREATE_PROTOTYPE_FOR_LAZY_TYPE)

#undef CREATE_PROTOTYPE_FOR_LAZY_TYPE

// Constructors

Expand Down Expand Up @@ -1733,13 +1735,10 @@ capitalName ## Constructor* lowerName ## Constructor = featureFlag ? capitalName

FOR_EACH_WEBASSEMBLY_CONSTRUCTOR_TYPE(CREATE_WEBASSEMBLY_PROTOTYPE)

#undef CREATE_WEBASSEMBLY_CONSTRUCTOR
#undef CREATE_WEBASSEMBLY_PROTOTYPE
}
#endif // ENABLE(WEBASSEMBLY)

#undef CREATE_PROTOTYPE_FOR_LAZY_TYPE


{
ObjectPropertyCondition condition = setupAdaptiveWatchpoint(this, arrayIteratorPrototype, vm.propertyNames->next);
m_arrayIteratorPrototypeNext = makeUnique<ObjectPropertyChangeAdaptiveWatchpoint<InlineWatchpointSet>>(this, condition, m_arrayIteratorProtocolWatchpointSet);
Expand Down

0 comments on commit 87241d5

Please sign in to comment.