-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Find in Note: Dark gray outline (shadow) appears behind gray/yellow h…
…ighlights when matched text found in HTML note. https://bugs.webkit.org/show_bug.cgi?id=270666 rdar://122843511 Reviewed by Aditya Keerthi. In notes, the WKContentView is transparent, so our original solution of putting an additional grey layer behind the content view that filled up the empty parts of the scroll view would show through and make the find ui have a incorrect grey cast. So instead, we make four views that surround the WKContentView to fill in any part of the scrollView that isn't covered by the contentView. These are arranged around the content view like so: ----- ----------- | | | | |----------| | | | | | | | | ----- ------ | | | | |__________|____| Each view is expanded to reach the edges of the scroll view every time the view is scrolled or the bounds change. This means that no matter where the content view is scrolled to, there will be a view that gives the correct grey cast to the scroll view. * Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h: * Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm: (-[WKWebView scrollViewDidScroll:]): (-[WKWebView _frameOrBoundsMayHaveChanged]): (-[WKWebView _updateFindOverlayForOverflowScrollPositions]): (-[WKWebView _showFindOverlay]): (-[WKWebView _hideFindOverlay]): (-[WKWebView _didAddLayerForFindOverlay:]): (-[WKWebView _updateFindOverlayPosition]): Deleted. Canonical link: https://commits.webkit.org/275873@main
- Loading branch information
1 parent
93c3eb8
commit 89bc7dd
Showing
2 changed files
with
95 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters