Skip to content

Commit

Permalink
[Navigation] Enable some tests that now pass
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=271374

Reviewed by Manuel Rego Casasnovas.

Enable some tests that now pass.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-destination-getState-back-forward-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-history-back-noop-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-navigation-back-same-document-in-iframe-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/same-url-replace-cross-document-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/same-url-replace-same-document-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/back-forward-initial-about-blank-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/back-forward-opaque-origin-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-already-detached-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-detach-in-serialization-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-invalid-url-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-push-javascript-url-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-rejection-order-invalidurl-detached-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-rejection-order-invalidurl-unserializablestate-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-unserializable-state-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/traverseTo-invalid-key-expected.txt:

Canonical link: https://commits.webkit.org/276474@main
  • Loading branch information
rwlbuis committed Mar 21, 2024
1 parent d0d7718 commit 8b127d8
Show file tree
Hide file tree
Showing 16 changed files with 26 additions and 17 deletions.
11 changes: 11 additions & 0 deletions LayoutTests/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -6857,9 +6857,14 @@ imported/w3c/web-platform-tests/navigation-api/currententrychange-event/navigati
imported/w3c/web-platform-tests/navigation-api/currententrychange-event/navigation-navigate-preventDefault.html [ Skip ]
imported/w3c/web-platform-tests/navigation-api/currententrychange-event/navigation-navigate-replace-same-doc.html [ Skip ]
imported/w3c/web-platform-tests/navigation-api/commit-behavior/after-transition-uncancelable.html [ Pass ]
imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-destination-getState-back-forward.html [ Pass ]
imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-history-back-noop.html [ Pass ]
imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-navigation-back-same-document-in-iframe.html [ Pass ]
imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-to-javascript.html [ Pass ]
imported/w3c/web-platform-tests/navigation-api/navigate-event/navigatesuccess-cross-document.html [ Pass ]
imported/w3c/web-platform-tests/navigation-api/navigate-event/replaceState-in-unload-then-remove-iframe.html [ Pass ]
imported/w3c/web-platform-tests/navigation-api/navigate-event/same-url-replace-cross-document.html [ Pass ]
imported/w3c/web-platform-tests/navigation-api/navigate-event/same-url-replace-same-document.html [ Pass ]
imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-crossdocument-crossorigin.html [ Pass ]
imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/location-crossdocument-crossorigin.html [ Pass ]
imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/open-crossdocument-crossorigin.html [ Pass ]
Expand All @@ -6878,6 +6883,12 @@ imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-inter
imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-relative-url.html [ Pass ]
imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/back-forward-out-of-bounds.html [ Pass ]
imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-push-initial-about-blank.html [ Pass ]
imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/traverseTo-invalid-key.html [ Pass ]
imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-rejection-order-invalidurl-unserializablestate.html [ Pass ]
imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-push-javascript-url.html [ Pass ]
imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/back-forward-opaque-origin.html [ Pass ]
imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/back-forward-initial-about-blank.html [ Pass ]
imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-invalid-url.html [ Pass ]
imported/w3c/web-platform-tests/navigation-api/navigation-methods/reload-base-url.html [ Pass ]
imported/w3c/web-platform-tests/navigation-api/navigation-methods/sandboxing-navigate-parent.html [ Pass ]
imported/w3c/web-platform-tests/navigation-api/navigation-methods/sandboxing-navigate-sibling.html [ Pass ]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@

FAIL navigate event destination.getState() on back/forward navigation null is not an object (evaluating 'navigation.currentEntry.key')
PASS navigate event destination.getState() on back/forward navigation

Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@


FAIL history.back() does not fire a navigate event when there's nothing to navigate promise_test: Unhandled rejection with value: object "TypeError: null is not an object (evaluating 'navigation.currentEntry.index')"
PASS history.back() does not fire a navigate event when there's nothing to navigate

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@


FAIL navigate event for navigation.back() - same-document in an iframe promise_test: Unhandled rejection with value: object "TypeError: null is not an object (evaluating 'i.contentWindow.navigation.currentEntry.key')"
PASS navigate event for navigation.back() - same-document in an iframe

Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@

FAIL navigate() to the current URL cross document should replace promise_test: Unhandled rejection with value: object "TypeError: null is not an object (evaluating 'navigation.currentEntry.index')"
PASS navigate() to the current URL cross document should replace

Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@

FAIL navigate() to the current URL same document should replace promise_test: Unhandled rejection with value: object "TypeError: null is not an object (evaluating 'navigation.currentEntry.index')"
PASS navigate() to the current URL same document should replace

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@


FAIL back() and forward() in initial about:blank document assert_array_equals: lengths differ, expected array ["committed", "finished"] length 2, got ["todo"] length 1
PASS back() and forward() in initial about:blank document

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@


FAIL navigation.back()/forward() in an opaque origin iframe assert_array_equals: lengths differ, expected array ["committed", "finished"] length 2, got ["todo"] length 1
PASS navigation.back()/forward() in an opaque origin iframe

Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@

FAIL navigate() in a detached window assert_array_equals: lengths differ, expected array ["committed", "finished"] length 2, got ["todo"] length 1
PASS navigate() in a detached window

Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@


FAIL navigate() promise rejections when detaching an iframe inside state serialization assert_array_equals: lengths differ, expected array ["committed", "finished"] length 2, got ["todo"] length 1
PASS navigate() promise rejections when detaching an iframe inside state serialization

Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@

FAIL navigate() with an invalid URL assert_array_equals: lengths differ, expected array ["committed", "finished"] length 2, got ["todo"] length 1
PASS navigate() with an invalid URL

Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@

FAIL navigate() to a javascript: URL assert_array_equals: lengths differ, expected array ["committed", "finished"] length 2, got ["todo"] length 1
PASS navigate() to a javascript: URL

Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@

FAIL navigate() with an invalid URL in a detached iframe throws "SyntaxError", not "InvalidStateError" assert_array_equals: lengths differ, expected array ["committed", "finished"] length 2, got ["todo"] length 1
PASS navigate() with an invalid URL in a detached iframe throws "SyntaxError", not "InvalidStateError"

Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@

FAIL navigate() with an invalid URL and unserializable state throws "SyntaxError", not "DataCloneError" assert_array_equals: lengths differ, expected array ["committed", "finished"] length 2, got ["todo"] length 1
PASS navigate() with an invalid URL and unserializable state throws "SyntaxError", not "DataCloneError"

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@

FAIL navigate() with an unserializable state (WritableStream) assert_array_equals: lengths differ, expected array ["committed", "finished"] length 2, got ["todo"] length 1
PASS navigate() with an unserializable state (WritableStream)
FAIL navigate() with an unserializable state (SharedArrayBuffer) assert_array_equals: lengths differ, expected array ["committed", "finished"] length 2, got ["todo"] length 1

Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@

FAIL traverseTo() with invalid key assert_array_equals: lengths differ, expected array ["committed", "finished"] length 2, got ["todo"] length 1
PASS traverseTo() with invalid key

0 comments on commit 8b127d8

Please sign in to comment.