Skip to content

Commit

Permalink
CMake 3.25.0: ninja: error: dependency cycle: Source/WebCore/CMakeFil…
Browse files Browse the repository at this point in the history
…es/WebCore.dir/CXX.dd

https://bugs.webkit.org/show_bug.cgi?id=248190

Reviewed by Ross Kirsling.

The latest CMake 3.25.0 fails to build WebKit due to a dependency
cycle error of Ninja.
> ninja: error: dependency cycle: Source/WebCore/CMakeFiles/WebCore.dir/CXX.dd -> Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/FormatConverter.cpp.obj.ddi -> Source/WebCore/WebCore_SOURCES/WebCorePrefix.pch ->
> Source/WebCore/CMakeFiles/WebCore.dir/WebCorePrefix.cpp.obj -> Source/WebCore/CMakeFiles/WebCore.dir/CXX.dd

It enables CMAKE_EXPERIMENTAL_CXX_MODULE_DYNDEP if CMAKE_CXX_STANDARD
is 20. It should be disabled for now.

* Source/cmake/OptionsCommon.cmake:

Canonical link: https://commits.webkit.org/256922@main
  • Loading branch information
fujii committed Nov 22, 2022
1 parent 6a6f9ed commit 8b54e8f
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Source/cmake/OptionsCommon.cmake
@@ -1,6 +1,7 @@
set(CMAKE_CXX_STANDARD 20)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS OFF)
set(CMAKE_EXPERIMENTAL_CXX_MODULE_DYNDEP OFF)

add_definitions(-DBUILDING_WITH_CMAKE=1)
add_definitions(-DBUILDING_WEBKIT=1)
Expand Down

0 comments on commit 8b54e8f

Please sign in to comment.