Skip to content

Commit

Permalink
Support specifying explicit SDK version
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=274298

Reviewed by Elliott Williams.

Strip the version number from the specified SDK as well when setting
the platform name

* Tools/Scripts/webkitdirs.pm:
(determineXcodeSDKPlatformName):

Canonical link: https://commits.webkit.org/279009@main
  • Loading branch information
ojhunt authored and emw-apple committed May 20, 2024
1 parent 03357c1 commit 9140fbd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Tools/Scripts/webkitdirs.pm
Original file line number Diff line number Diff line change
Expand Up @@ -965,7 +965,7 @@ sub determineXcodeSDKPlatformName {
if (checkForArgumentAndRemoveFromARGVGettingValue("--sdk", \$sdk)) {
$xcodeSDK = lc $sdk;
$xcodeSDKPlatformName ||= $sdk;
$xcodeSDKPlatformName =~ s/\.internal$//;
$xcodeSDKPlatformName =~ s/(\d+\.[\d\.]+)?(\.internal)?$//;
die "Couldn't determine platform name from Xcode SDK" unless isValidXcodeSDKPlatformName($xcodeSDKPlatformName);
return;
}
Expand Down

0 comments on commit 9140fbd

Please sign in to comment.