Skip to content

Commit

Permalink
Add heap identifier macros to WebCore/accessibility and WebCore/css
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=260544
rdar://114281241

Reviewed by Brent Fulgham.

Replace WTF_MAKE_FAST_ALLOCATED with
WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER for more fine-grained
diagnostics when building with MallocHeapBreakdown enabled.

* Source/WebCore/accessibility/AXGeometryManager.cpp:
* Source/WebCore/accessibility/AXGeometryManager.h:
* Source/WebCore/accessibility/AXObjectCache.cpp:
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AXTextMarker.cpp:
* Source/WebCore/accessibility/AXTextMarker.h:
* Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp:
* Source/WebCore/accessibility/atspi/AccessibilityAtspi.h:
* Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.cpp:
* Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
* Source/WebCore/css/CSSCounterStyleRegistry.cpp:
* Source/WebCore/css/CSSCounterStyleRegistry.h:
* Source/WebCore/css/CSSFontFaceSource.cpp:
* Source/WebCore/css/CSSFontFaceSource.h:
* Source/WebCore/css/CSSSegmentedFontFace.cpp:
* Source/WebCore/css/CSSSegmentedFontFace.h:
* Source/WebCore/css/CSSStyleSheet.cpp:
* Source/WebCore/css/CSSValuePool.cpp:
* Source/WebCore/css/CSSValuePool.h:
* Source/WebCore/css/CSSVariableData.cpp:
* Source/WebCore/css/CSSVariableData.h:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
* Source/WebCore/css/ComputedStyleExtractor.h:
* Source/WebCore/css/DOMCSSPaintWorklet.cpp:
* Source/WebCore/css/DOMCSSPaintWorklet.h:
* Source/WebCore/css/DOMCSSRegisterCustomProperty.cpp:
* Source/WebCore/css/DOMCSSRegisterCustomProperty.h:
* Source/WebCore/css/StyleRuleImport.cpp:
* Source/WebCore/css/StyleRuleImport.h:
* Source/WebCore/css/calc/CSSCalcOperationNode.cpp:
* Source/WebCore/css/calc/CSSCalcOperationNode.h:
* Source/WebCore/css/calc/CSSCalcPrimitiveValueNode.cpp:
* Source/WebCore/css/calc/CSSCalcPrimitiveValueNode.h:
* Source/WebCore/css/parser/CSSParserToken.cpp:
* Source/WebCore/css/parser/CSSParserToken.h:
* Source/WebCore/css/parser/CSSTokenizer.cpp:
* Source/WebCore/css/parser/CSSTokenizer.h:
* Source/WebCore/css/parser/CSSTokenizerInputStream.cpp:
* Source/WebCore/css/parser/CSSTokenizerInputStream.h:
* Source/WebCore/css/typedom/CSSNumericFactory.cpp:
* Source/WebCore/css/typedom/CSSNumericFactory.h:

Canonical link: https://commits.webkit.org/267195@main
  • Loading branch information
rreno committed Aug 23, 2023
1 parent 0495446 commit 949488d
Show file tree
Hide file tree
Showing 43 changed files with 70 additions and 23 deletions.
1 change: 1 addition & 0 deletions Source/WebCore/accessibility/AXGeometryManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
#endif

namespace WebCore {
DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER(AXGeometryManager);

AXGeometryManager::AXGeometryManager(AXObjectCache& owningCache)
: m_cache(owningCache)
Expand Down
3 changes: 2 additions & 1 deletion Source/WebCore/accessibility/AXGeometryManager.h
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,10 @@ namespace WebCore {

class AXObjectCache;

DECLARE_ALLOCATOR_WITH_HEAP_IDENTIFIER(AXGeometryManager);
class AXGeometryManager : public ThreadSafeRefCounted<AXGeometryManager> {
WTF_MAKE_NONCOPYABLE(AXGeometryManager);
WTF_MAKE_FAST_ALLOCATED;
WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER(AXGeometryManager);
public:
explicit AXGeometryManager(AXObjectCache&);
AXGeometryManager();
Expand Down
2 changes: 2 additions & 0 deletions Source/WebCore/accessibility/AXObjectCache.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,8 @@
#endif

namespace WebCore {
DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER(AXComputedObjectAttributeCache);
DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER(AXObjectCache);

using namespace HTMLNames;

Expand Down
6 changes: 4 additions & 2 deletions Source/WebCore/accessibility/AXObjectCache.h
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,9 @@ struct CharacterOffset {
}
};

DECLARE_ALLOCATOR_WITH_HEAP_IDENTIFIER(AXComputedObjectAttributeCache);
class AXComputedObjectAttributeCache {
WTF_MAKE_FAST_ALLOCATED;
WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER(AXComputedObjectAttributeCache);
public:
AccessibilityObjectInclusion getIgnored(AXID) const;
void setIgnored(AXID, AccessibilityObjectInclusion);
Expand Down Expand Up @@ -142,10 +143,11 @@ enum AXTextChange { AXTextInserted, AXTextDeleted, AXTextAttributesChanged };

enum class PostTarget { Element, ObservableParent };

DECLARE_ALLOCATOR_WITH_HEAP_IDENTIFIER(AXObjectCache);
class AXObjectCache : public CanMakeWeakPtr<AXObjectCache>, public CanMakeCheckedPtr
, public AXTreeStore<AXObjectCache> {
WTF_MAKE_NONCOPYABLE(AXObjectCache);
WTF_MAKE_FAST_ALLOCATED;
WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER(AXObjectCache);
friend class AXIsolatedTree;
friend class AXTextMarker;
friend WTF::TextStream& operator<<(WTF::TextStream&, AXObjectCache&);
Expand Down
1 change: 1 addition & 0 deletions Source/WebCore/accessibility/AXTextMarker.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
#include "TextIterator.h"

namespace WebCore {
DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER(AXTextMarker);

TextMarkerData::TextMarkerData(AXObjectCache& cache, Node* nodeParam, const VisiblePosition& visiblePosition, int charStart, int charOffset, bool ignoredParam)
{
Expand Down
3 changes: 2 additions & 1 deletion Source/WebCore/accessibility/AXTextMarker.h
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,9 @@ using PlatformTextMarkerData = AXTextMarkerRef;
using PlatformTextMarkerData = NSData *;;
#endif

DECLARE_ALLOCATOR_WITH_HEAP_IDENTIFIER(AXTextMarker);
class AXTextMarker {
WTF_MAKE_FAST_ALLOCATED;
WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER(AXTextMarker);
friend class AXTextMarkerRange;
friend std::partial_ordering partialOrder(const AXTextMarker&, const AXTextMarker&);
public:
Expand Down
1 change: 1 addition & 0 deletions Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
#include <wtf/glib/RunLoopSourcePriority.h>

namespace WebCore {
DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER(AccessibilityAtspi);

AccessibilityAtspi& AccessibilityAtspi::singleton()
{
Expand Down
4 changes: 3 additions & 1 deletion Source/WebCore/accessibility/atspi/AccessibilityAtspi.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,10 @@ class AccessibilityObjectAtspi;
class AccessibilityRootAtspi;
enum class AccessibilityRole;

DECLARE_ALLOCATOR_WITH_HEAP_IDENTIFIER(AccessibilityAtspi);
class AccessibilityAtspi {
WTF_MAKE_NONCOPYABLE(AccessibilityAtspi); WTF_MAKE_FAST_ALLOCATED;
WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER(AccessibilityAtspi);
WTF_MAKE_NONCOPYABLE(AccessibilityAtspi);
friend NeverDestroyed<AccessibilityAtspi>;
public:
WEBCORE_EXPORT static AccessibilityAtspi& singleton();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
#include <locale.h>

namespace WebCore {
DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER(AccessibilityRootAtspi);

Ref<AccessibilityRootAtspi> AccessibilityRootAtspi::create(Page& page)
{
Expand Down
3 changes: 2 additions & 1 deletion Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,9 @@ namespace WebCore {
class AccessibilityObjectAtspi;
class Page;

DECLARE_ALLOCATOR_WITH_HEAP_IDENTIFIER(AccessibilityRootAtspi);
class AccessibilityRootAtspi final : public RefCounted<AccessibilityRootAtspi> {
WTF_MAKE_FAST_ALLOCATED;
WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER(AccessibilityRootAtspi);
public:
static Ref<AccessibilityRootAtspi> create(Page&);
~AccessibilityRootAtspi() = default;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
#include <wtf/SetForScope.h>

namespace WebCore {
DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER(AXIsolatedTree);

HashMap<PageIdentifier, Ref<AXIsolatedTree>>& AXIsolatedTree::treePageCache()
{
Expand Down
3 changes: 2 additions & 1 deletion Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
Original file line number Diff line number Diff line change
Expand Up @@ -247,10 +247,11 @@ struct AXPropertyChange {
AXPropertyMap properties; // Changed properties.
};

DECLARE_ALLOCATOR_WITH_HEAP_IDENTIFIER(AXIsolatedTree);
class AXIsolatedTree : public ThreadSafeRefCountedAndCanMakeThreadSafeWeakPtr<AXIsolatedTree>
, public AXTreeStore<AXIsolatedTree> {
WTF_MAKE_NONCOPYABLE(AXIsolatedTree);
WTF_MAKE_FAST_ALLOCATED;
WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER(AXIsolatedTree);
friend WTF::TextStream& operator<<(WTF::TextStream&, AXIsolatedTree&);
friend void streamIsolatedSubtreeOnMainThread(TextStream&, const AXIsolatedTree&, AXID, const OptionSet<AXStreamOptions>&);
public:
Expand Down
1 change: 1 addition & 0 deletions Source/WebCore/css/CSSCounterStyleRegistry.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
#include <wtf/NeverDestroyed.h>

namespace WebCore {
DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER(CSSCounterStyleRegistry);


void CSSCounterStyleRegistry::resolveUserAgentReferences()
Expand Down
3 changes: 2 additions & 1 deletion Source/WebCore/css/CSSCounterStyleRegistry.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,9 @@ enum CSSValueID : uint16_t;

using CounterStyleMap = HashMap<AtomString, RefPtr<CSSCounterStyle>>;

DECLARE_ALLOCATOR_WITH_HEAP_IDENTIFIER(CSSCounterStyleRegistry);
class CSSCounterStyleRegistry {
WTF_MAKE_FAST_ALLOCATED;
WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER(CSSCounterStyleRegistry);
public:
CSSCounterStyleRegistry() = default;
RefPtr<CSSCounterStyle> resolvedCounterStyle(const ListStyleType&);
Expand Down
1 change: 1 addition & 0 deletions Source/WebCore/css/CSSFontFaceSource.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
#include "SharedBuffer.h"

namespace WebCore {
DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER(CSSFontFaceSource);

inline void CSSFontFaceSource::setStatus(Status newStatus)
{
Expand Down
3 changes: 2 additions & 1 deletion Source/WebCore/css/CSSFontFaceSource.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,9 @@ class WeakPtrImplWithEventTargetData;

struct FontCustomPlatformData;

DECLARE_ALLOCATOR_WITH_HEAP_IDENTIFIER(CSSFontFaceSource);
class CSSFontFaceSource final : public FontLoadRequestClient {
WTF_MAKE_FAST_ALLOCATED;
WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER(CSSFontFaceSource);
public:
CSSFontFaceSource(CSSFontFace& owner, AtomString fontFaceName);
CSSFontFaceSource(CSSFontFace& owner, AtomString fontFaceName, SVGFontFaceElement&);
Expand Down
1 change: 1 addition & 0 deletions Source/WebCore/css/CSSSegmentedFontFace.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
#include "FontSelector.h"

namespace WebCore {
DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER(CSSSegmentedFontFace);

CSSSegmentedFontFace::CSSSegmentedFontFace()
{
Expand Down
3 changes: 2 additions & 1 deletion Source/WebCore/css/CSSSegmentedFontFace.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,9 @@ class FontDescription;
class FontPaletteValues;
class FontRanges;

DECLARE_ALLOCATOR_WITH_HEAP_IDENTIFIER(CSSSegmentedFontFace);
class CSSSegmentedFontFace final : public RefCounted<CSSSegmentedFontFace>, public CSSFontFace::Client {
WTF_MAKE_FAST_ALLOCATED;
WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER(CSSSegmentedFontFace);
public:
static Ref<CSSSegmentedFontFace> create()
{
Expand Down
4 changes: 3 additions & 1 deletion Source/WebCore/css/CSSStyleSheet.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,9 @@ static Style::Scope& styleScopeFor(ContainerNode& treeScope)
return downcast<Document>(treeScope).styleScope();
}

DECLARE_ALLOCATOR_WITH_HEAP_IDENTIFIER(StyleSheetCSSRuleList);
class StyleSheetCSSRuleList final : public CSSRuleList {
WTF_MAKE_FAST_ALLOCATED;
WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER(StyleSheetCSSRuleList);
public:
StyleSheetCSSRuleList(CSSStyleSheet* sheet) : m_styleSheet(sheet) { }

Expand All @@ -73,6 +74,7 @@ class StyleSheetCSSRuleList final : public CSSRuleList {

CSSStyleSheet* m_styleSheet;
};
DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER(StyleSheetCSSRuleList);

#if ASSERT_ENABLED
static bool isAcceptableCSSStyleSheetParent(Node* parentNode)
Expand Down
1 change: 1 addition & 0 deletions Source/WebCore/css/CSSValuePool.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
#include <wtf/text/StringConcatenateNumbers.h>

namespace WebCore {
DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER(CSSValuePool);

LazyNeverDestroyed<StaticCSSValuePool> staticCSSValuePool;

Expand Down
3 changes: 2 additions & 1 deletion Source/WebCore/css/CSSValuePool.h
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,9 @@ class StaticCSSValuePool {

WEBCORE_EXPORT extern LazyNeverDestroyed<StaticCSSValuePool> staticCSSValuePool;

DECLARE_ALLOCATOR_WITH_HEAP_IDENTIFIER(CSSValuePool);
class CSSValuePool {
WTF_MAKE_FAST_ALLOCATED;
WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER(CSSValuePool);
WTF_MAKE_NONCOPYABLE(CSSValuePool);
public:
CSSValuePool();
Expand Down
1 change: 1 addition & 0 deletions Source/WebCore/css/CSSVariableData.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
#include <wtf/text/StringView.h>

namespace WebCore {
DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER(CSSVariableData);

template<typename CharacterType> void CSSVariableData::updateTokens(const CSSParserTokenRange& range)
{
Expand Down
3 changes: 2 additions & 1 deletion Source/WebCore/css/CSSVariableData.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,10 @@

namespace WebCore {

DECLARE_ALLOCATOR_WITH_HEAP_IDENTIFIER(CSSVariableData);
class CSSVariableData : public RefCounted<CSSVariableData> {
WTF_MAKE_NONCOPYABLE(CSSVariableData);
WTF_MAKE_FAST_ALLOCATED;
WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER(CSSVariableData);
public:
static Ref<CSSVariableData> create(const CSSParserTokenRange& range)
{
Expand Down
1 change: 1 addition & 0 deletions Source/WebCore/css/ComputedStyleExtractor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@
#include "WebAnimationUtilities.h"

namespace WebCore {
DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER(ComputedStyleExtractor);

template<typename ConvertibleType> Ref<CSSPrimitiveValue> createConvertingToCSSValueID(const ConvertibleType& value)
{
Expand Down
3 changes: 2 additions & 1 deletion Source/WebCore/css/ComputedStyleExtractor.h
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,9 @@ enum class SVGPaintType : uint8_t;

using CSSValueListBuilder = Vector<Ref<CSSValue>, 4>;

DECLARE_ALLOCATOR_WITH_HEAP_IDENTIFIER(ComputedStyleExtractor);
class ComputedStyleExtractor {
WTF_MAKE_FAST_ALLOCATED;
WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER(ComputedStyleExtractor);
public:
ComputedStyleExtractor(Node*, bool allowVisitedStyle = false);
ComputedStyleExtractor(Node*, bool allowVisitedStyle, PseudoId);
Expand Down
1 change: 1 addition & 0 deletions Source/WebCore/css/DOMCSSPaintWorklet.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
#include <wtf/text/WTFString.h>

namespace WebCore {
DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER(DOMCSSPaintWorklet);

PaintWorklet& DOMCSSPaintWorklet::ensurePaintWorklet(Document& document)
{
Expand Down
3 changes: 2 additions & 1 deletion Source/WebCore/css/DOMCSSPaintWorklet.h
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,9 @@ class PaintWorklet final : public Worklet {
{ }
};

DECLARE_ALLOCATOR_WITH_HEAP_IDENTIFIER(DOMCSSPaintWorklet);
class DOMCSSPaintWorklet final : public Supplement<DOMCSSNamespace> {
WTF_MAKE_FAST_ALLOCATED;
WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER(DOMCSSPaintWorklet);
public:
explicit DOMCSSPaintWorklet(DOMCSSNamespace&) { }

Expand Down
1 change: 1 addition & 0 deletions Source/WebCore/css/DOMCSSRegisterCustomProperty.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
#include <wtf/text/WTFString.h>

namespace WebCore {
DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER(DOMCSSRegisterCustomProperty);

ExceptionOr<void> DOMCSSRegisterCustomProperty::registerProperty(Document& document, const DOMCSSCustomPropertyDescriptor& descriptor)
{
Expand Down
3 changes: 2 additions & 1 deletion Source/WebCore/css/DOMCSSRegisterCustomProperty.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,9 @@ namespace WebCore {
class Document;
class DOMCSSNamespace;

DECLARE_ALLOCATOR_WITH_HEAP_IDENTIFIER(DOMCSSRegisterCustomProperty);
class DOMCSSRegisterCustomProperty final : public Supplement<DOMCSSNamespace> {
WTF_MAKE_FAST_ALLOCATED;
WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER(DOMCSSRegisterCustomProperty);
public:
explicit DOMCSSRegisterCustomProperty(DOMCSSNamespace&) { }

Expand Down
1 change: 1 addition & 0 deletions Source/WebCore/css/StyleRuleImport.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
#include <wtf/StdLibExtras.h>

namespace WebCore {
DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER(StyleRuleImport);

Ref<StyleRuleImport> StyleRuleImport::create(const String& href, MQ::MediaQueryList&& mediaQueries, std::optional<CascadeLayerName>&& cascadeLayerName)
{
Expand Down
3 changes: 2 additions & 1 deletion Source/WebCore/css/StyleRuleImport.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,9 @@ namespace WebCore {
class CachedCSSStyleSheet;
class StyleSheetContents;

DECLARE_ALLOCATOR_WITH_HEAP_IDENTIFIER(StyleRuleImport);
class StyleRuleImport final : public StyleRuleBase {
WTF_MAKE_FAST_ALLOCATED;
WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER(StyleRuleImport);
public:
static Ref<StyleRuleImport> create(const String& href, MQ::MediaQueryList&&, std::optional<CascadeLayerName>&&);
~StyleRuleImport();
Expand Down
1 change: 1 addition & 0 deletions Source/WebCore/css/calc/CSSCalcOperationNode.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
#include <wtf/text/TextStream.h>

namespace WebCore {
DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER(CSSCalcOperationNode);

// This is the result of the "To add two types type1 and type2, perform the following steps:" rules.

Expand Down
3 changes: 2 additions & 1 deletion Source/WebCore/css/calc/CSSCalcOperationNode.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,9 @@

namespace WebCore {

DECLARE_ALLOCATOR_WITH_HEAP_IDENTIFIER(CSSCalcOperationNode);
class CSSCalcOperationNode final : public CSSCalcExpressionNode {
WTF_MAKE_FAST_ALLOCATED;
WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER(CSSCalcOperationNode);
public:
enum class IsRoot : bool { No, Yes };

Expand Down
1 change: 1 addition & 0 deletions Source/WebCore/css/calc/CSSCalcPrimitiveValueNode.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
#include <wtf/text/TextStream.h>

namespace WebCore {
DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER(CSSCalcPrimitiveValueNode);

Ref<CSSCalcPrimitiveValueNode> CSSCalcPrimitiveValueNode::create(Ref<CSSPrimitiveValue>&& value)
{
Expand Down
3 changes: 2 additions & 1 deletion Source/WebCore/css/calc/CSSCalcPrimitiveValueNode.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,9 @@ class CSSToLengthConversionData;

enum CSSPropertyID : uint16_t;

DECLARE_ALLOCATOR_WITH_HEAP_IDENTIFIER(CSSCalcPrimitiveValueNode);
class CSSCalcPrimitiveValueNode final : public CSSCalcExpressionNode {
WTF_MAKE_FAST_ALLOCATED;
WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER(CSSCalcPrimitiveValueNode);
public:
static Ref<CSSCalcPrimitiveValueNode> create(Ref<CSSPrimitiveValue>&&);
static RefPtr<CSSCalcPrimitiveValueNode> create(double value, CSSUnitType);
Expand Down
1 change: 1 addition & 0 deletions Source/WebCore/css/parser/CSSParserToken.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
#include <wtf/text/StringBuilder.h>

namespace WebCore {
DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER(CSSParserToken);

template<typename CharacterType>
CSSUnitType cssPrimitiveValueUnitFromTrie(const CharacterType* data, unsigned length)
Expand Down
3 changes: 2 additions & 1 deletion Source/WebCore/css/parser/CSSParserToken.h
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,9 @@ enum HashTokenType {
HashTokenUnrestricted,
};

DECLARE_ALLOCATOR_WITH_HEAP_IDENTIFIER(CSSParserToken);
class CSSParserToken {
WTF_MAKE_FAST_ALLOCATED;
WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER(CSSParserToken);
public:
enum BlockType {
NotBlock,
Expand Down
1 change: 1 addition & 0 deletions Source/WebCore/css/parser/CSSTokenizer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
#include <wtf/unicode/CharacterNames.h>

namespace WebCore {
DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER(CSSTokenizer);

// https://drafts.csswg.org/css-syntax/#input-preprocessing
String CSSTokenizer::preprocessString(const String& string)
Expand Down
3 changes: 2 additions & 1 deletion Source/WebCore/css/parser/CSSTokenizer.h
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,10 @@ class CSSTokenizerInputStream;
class CSSParserObserverWrapper;
class CSSParserTokenRange;

DECLARE_ALLOCATOR_WITH_HEAP_IDENTIFIER(CSSTokenizer);
class CSSTokenizer {
WTF_MAKE_NONCOPYABLE(CSSTokenizer);
WTF_MAKE_FAST_ALLOCATED;
WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER(CSSTokenizer);
public:
static std::unique_ptr<CSSTokenizer> tryCreate(const String&);
static std::unique_ptr<CSSTokenizer> tryCreate(const String&, CSSParserObserverWrapper&); // For the inspector
Expand Down
Loading

0 comments on commit 949488d

Please sign in to comment.