Skip to content

Commit

Permalink
Cherry-pick 266992@main (1b2a91b). https://bugs.webkit.org/show_bug.c…
Browse files Browse the repository at this point in the history
…gi?id=260260

    [GTK][WPE] Crash in `DrawingAreaCoordinatedGraphics::display()`in debug builds
    https://bugs.webkit.org/show_bug.cgi?id=260260

    Reviewed by Carlos Garcia Campos.

    `DrawingAreaCoordinatedGraphics::forceRepaint()`, which, in turn, can call
    `DrawingAreaCoordinatedGraphics::display()`, can be called while being
    in the middle of resizing.

    We can just ignore it because repainting will happen after resizing anyway.

    * LayoutTests/platform/glib/TestExpectations:
    * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
    (WebKit::DrawingAreaCoordinatedGraphics::forceRepaint):

    Canonical link: https://commits.webkit.org/266992@main
  • Loading branch information
obyknovenius authored and carlosgcampos committed Aug 18, 2023
1 parent 07a2cda commit 99b562e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 10 deletions.
10 changes: 0 additions & 10 deletions LayoutTests/platform/glib/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -3377,28 +3377,18 @@ imported/w3c/web-platform-tests/preload/preload-time-to-fetch.https.html [ DumpJ
imported/w3c/web-platform-tests/preload/preload-type-match.html [ DumpJSConsoleLogInStdErr ]

# Tests crashing in Debug only.
[ Debug ] css3/viewport-percentage-lengths/viewport-percentage-lengths-anonymous-block.html [ Crash ]
[ Debug ] css3/viewport-percentage-lengths/viewport-percentage-lengths-percent-size-child.html [ Crash ]
[ Debug ] css3/viewport-percentage-lengths/viewport-percentage-lengths-relative-font-size.html [ Crash ]
[ Debug ] css3/viewport-percentage-lengths/viewport-percentage-lengths-resize.html [ Crash ]
[ Debug ] editing/pasteboard/copy-paste-across-shadow-boundaries-with-style-2.html [ Crash ]
[ Debug ] fast/backgrounds/gradient-background-leakage-hidpi.html [ Crash ]
[ Debug ] fast/canvas/2d.backingStorePixelRatio.html [ Crash ]
[ Debug ] fast/canvas/canvas-as-image-hidpi.html [ Crash ]
[ Debug ] fast/canvas/canvas-resize-reset-pixelRatio.html [ Crash ]
[ Debug ] fast/css-custom-paint/simple-hidpi.html [ Crash ]
[ Debug ] fast/css-grid-layout/flex-content-sized-columns-resize.html [ Crash ]
[ Debug ] fast/dom/HTMLImageElement/sizes/image-sizes-2x.html [ Crash ]
[ Debug ] fast/dom/HTMLImageElement/sizes/image-sizes-js-change.html [ Crash ]
[ Debug ] fast/dom/HTMLImageElement/sizes/image-sizes-js-innerhtml.html [ Crash ]
[ Debug ] fast/dom/Window/window-resize-contents.html [ Crash ]
[ Debug ] fast/dom/Window/window-resize-update-scrollbars.html [ Crash ]
[ Debug ] fast/dynamic/window-resize-scrollbars-test.html [ Crash ]
[ Debug ] fast/fixed-layout/fixed-layout.html [ Crash ]
[ Debug ] fast/forms/textarea-node-removed-from-document-crash.html [ Crash ]
[ Debug ] fast/history/page-cache-closed-audiocontext.html [ Crash ]
[ Debug ] fast/media/mq-resolution.html [ Crash ]
[ Debug ] fast/picture/viewport-resize.html [ Crash ]
[ Debug ] http/tests/loading/sizes/preload-image-sizes-2x.html [ Crash ]
[ Debug ] http/wpt/dom-ranges-live-range/Range-mutations-deleteData.html [ Crash ]
[ Debug ] http/wpt/dom-ranges-live-range/Range-mutations-insertData.html [ Crash ]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,9 @@ void DrawingAreaCoordinatedGraphics::scroll(const IntRect& scrollRect, const Int

void DrawingAreaCoordinatedGraphics::forceRepaint()
{
if (m_inUpdateGeometry)
return;

if (!m_layerTreeHost) {
m_isWaitingForDidUpdate = false;
m_dirtyRegion = m_webPage.bounds();
Expand Down

0 comments on commit 99b562e

Please sign in to comment.