Skip to content

Commit

Permalink
Remove incremental attribute and search event
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=195818
rdar://48937114

Reviewed by Aditya Keerthi.

These are non-standard and barely used. They are put behind a flag and
will be kept around for a while in case they are still being used
somewhere.

* LayoutTests/TestExpectations:
* LayoutTests/fast/dom/Window/get-set-properties-expected.txt:
* LayoutTests/fast/dom/Window/get-set-properties.html:
* LayoutTests/fast/dom/Window/resources/window-properties.js:
* LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt:
* LayoutTests/fast/dom/event-attribute-availability-expected.txt:
* LayoutTests/fast/dom/event-attribute-availability.html:
* LayoutTests/fast/dom/event-handler-attributes-expected.txt:
* LayoutTests/fast/dom/event-handler-attributes.html:
* LayoutTests/fast/dom/resources/wrapper-identity-base.js:
* LayoutTests/fast/dom/wrapper-identity-expected.txt:
* LayoutTests/fast/events/onsearch-enter-expected.txt: Removed.
* LayoutTests/fast/events/onsearch-enter.html: Removed.
* LayoutTests/fast/forms/incremental-dom-property-expected.txt: Removed.
* LayoutTests/fast/forms/incremental-dom-property.html: Removed.
* LayoutTests/fast/forms/input-search-press-escape-key-expected.txt: Removed.
* LayoutTests/fast/forms/input-search-press-escape-key.html: Removed.
* LayoutTests/fast/forms/search-event-delay-expected.txt: Removed.
* LayoutTests/fast/forms/search-event-delay.html: Removed.
* LayoutTests/http/tests/security/cross-frame-access-get-expected.txt:
* LayoutTests/http/tests/security/cross-frame-access-get.html:
* LayoutTests/http/tests/security/cross-frame-access-getOwnPropertyDescriptor-expected.txt:
* LayoutTests/http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html:
* LayoutTests/http/tests/security/cross-frame-access-put-expected.txt:
* LayoutTests/http/tests/security/cross-frame-access-put.html:
* LayoutTests/http/tests/security/resources/cross-frame-iframe-for-put-test.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/historical-expected.txt:
* LayoutTests/platform/gtk/fast/dom/Window/window-lookup-precedence-expected.txt:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-wk2/fast/dom/Window/window-lookup-precedence-expected.txt:
* LayoutTests/platform/mac/fast/dom/objc-wrapper-identity-expected.txt:
* LayoutTests/platform/wincairo/TestExpectations:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h:
* Source/WebCore/bindings/js/WebCoreBuiltinNames.h:
* Source/WebCore/dom/GlobalEventHandlers.idl:
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler):
* Source/WebCore/html/HTMLInputElement.idl:
* Source/WebCore/html/SearchInputType.cpp:
(WebCore::SearchInputType::handleKeydownEvent):
(WebCore::SearchInputType::searchEventsShouldBeDispatched const):
* Source/WebCore/html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
* Source/WebCore/rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::valueChanged):
* Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultSearchInputIncrementalAttributeAndSearchEventEnabled):
* Source/WebKit/Shared/WebPreferencesDefaultValues.h:
* Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h:
* Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm:
(WebKit::defaultSearchInputIncrementalAttributeAndSearchEventEnabled):

Canonical link: https://commits.webkit.org/266068@main
  • Loading branch information
annevk committed Jul 14, 2023
1 parent f379bd5 commit 99ff083
Show file tree
Hide file tree
Showing 45 changed files with 51 additions and 300 deletions.
2 changes: 0 additions & 2 deletions LayoutTests/TestExpectations
Expand Up @@ -1361,8 +1361,6 @@ webkit.org/b/72698 media/audio-garbage-collect.html [ Skip ]
# This test times out.
webkit.org/b/172527 fast/mediacapturefromelement/CanvasCaptureMediaStream-request-frame-events.html [ Skip ]

webkit.org/b/53990 fast/forms/search-event-delay.html [ Pass Failure ]

webkit.org/b/124932 media/video-size.html [ Pass Failure ]

webkit.org/b/126166 [ Debug ] js/dfg-int32array.html [ Skip ]
Expand Down
2 changes: 0 additions & 2 deletions LayoutTests/fast/dom/Window/get-set-properties-expected.txt
Expand Up @@ -342,8 +342,6 @@ PASS: canGet('onresize') should be 'true' and is.
PASS: canSet('onresize') should be 'true' and is.
PASS: canGet('onscroll') should be 'true' and is.
PASS: canSet('onscroll') should be 'true' and is.
PASS: canGet('onsearch') should be 'true' and is.
PASS: canSet('onsearch') should be 'true' and is.
PASS: canGet('onselect') should be 'true' and is.
PASS: canSet('onselect') should be 'true' and is.
PASS: canGet('onsubmit') should be 'true' and is.
Expand Down
1 change: 0 additions & 1 deletion LayoutTests/fast/dom/Window/get-set-properties.html
Expand Up @@ -243,7 +243,6 @@
"onreset",
"onresize",
"onscroll",
"onsearch",
"onselect",
"onsubmit",
"onunload",
Expand Down
1 change: 0 additions & 1 deletion LayoutTests/fast/dom/Window/resources/window-properties.js
Expand Up @@ -186,7 +186,6 @@ var propertyInfo = [
["onreset", "object"],
["onresize", "object"],
["onscroll", "object"],
["onsearch", "object"],
["onselect", "object"],
["onsubmit", "object"],
["onunload", "object"],
Expand Down
Expand Up @@ -373,8 +373,6 @@ PASS win['onresize'] is null
PASS win['onresize'] is null
PASS win['onscroll'] is null
PASS win['onscroll'] is null
PASS win['onsearch'] is null
PASS win['onsearch'] is null
PASS win['onselect'] is null
PASS win['onselect'] is null
PASS win['onsubmit'] is null
Expand Down
Expand Up @@ -40,7 +40,6 @@ PASS 'oncopy' in element is true
PASS 'onbeforepaste' in element is true
PASS 'onpaste' in element is true
PASS 'onreset' in element is true
PASS 'onsearch' in element is true
PASS 'onselectstart' in element is true
Test SVGElement
PASS 'onabort' in svgelement is true
Expand Down Expand Up @@ -79,7 +78,6 @@ PASS 'oncopy' in svgelement is true
PASS 'onbeforepaste' in svgelement is true
PASS 'onpaste' in svgelement is true
PASS 'onreset' in svgelement is true
PASS 'onsearch' in svgelement is true
PASS 'onselectstart' in svgelement is true

Test Document
Expand Down Expand Up @@ -119,7 +117,6 @@ PASS 'oncopy' in document is true
PASS 'onbeforepaste' in document is true
PASS 'onpaste' in document is true
PASS 'onreset' in document is true
PASS 'onsearch' in document is true
PASS 'onselectstart' in document is true

Test Window
Expand Down Expand Up @@ -159,7 +156,6 @@ PASS 'oncopy' in window is true
FAIL 'onbeforepaste' in window should be true. Was false.
PASS 'onpaste' in window is true
PASS 'onreset' in window is true
PASS 'onsearch' in window is true
PASS 'onselectstart' in window is true

Test Text Node
Expand Down Expand Up @@ -199,7 +195,6 @@ PASS 'oncopy' in textNode is false
PASS 'onbeforepaste' in textNode is false
PASS 'onpaste' in textNode is false
PASS 'onreset' in textNode is false
PASS 'onsearch' in textNode is false
PASS 'onselectstart' in textNode is false

Test Attribute
Expand Down Expand Up @@ -239,7 +234,6 @@ PASS 'oncopy' in attribute is false
PASS 'onbeforepaste' in attribute is false
PASS 'onpaste' in attribute is false
PASS 'onreset' in attribute is false
PASS 'onsearch' in attribute is false
PASS 'onselectstart' in attribute is false

Test HTMLBodyElement
Expand Down Expand Up @@ -279,7 +273,6 @@ PASS 'oncopy' in body is true
PASS 'onbeforepaste' in body is true
PASS 'onpaste' in body is true
PASS 'onreset' in body is true
PASS 'onsearch' in body is true
PASS 'onselectstart' in body is true
PASS 'onbeforeunload' in body is true
PASS 'onmessage' in body is true
Expand Down Expand Up @@ -330,7 +323,6 @@ PASS 'oncopy' in frameSet is true
PASS 'onbeforepaste' in frameSet is true
PASS 'onpaste' in frameSet is true
PASS 'onreset' in frameSet is true
PASS 'onsearch' in frameSet is true
PASS 'onselectstart' in frameSet is true
PASS 'onbeforeunload' in frameSet is true
PASS 'onmessage' in frameSet is true
Expand Down
2 changes: 1 addition & 1 deletion LayoutTests/fast/dom/event-attribute-availability.html
Expand Up @@ -20,7 +20,7 @@
// "onshow", "onstalled", "onsuspend", "ontimeupdate", "onvolumechange", "onwaiting",

// WebKit extensions
"onbeforecut", "oncut", "onbeforecopy", "oncopy", "onbeforepaste", "onpaste", "onreset", "onsearch",
"onbeforecut", "oncut", "onbeforecopy", "oncopy", "onbeforepaste", "onpaste", "onreset",
"onselectstart"
];

Expand Down
10 changes: 0 additions & 10 deletions LayoutTests/fast/dom/event-handler-attributes-expected.txt
Expand Up @@ -64,7 +64,6 @@ PASS testScriptAttribute(window, "ratechange") is "window"
PASS testScriptAttribute(window, "reset") is "window"
PASS testScriptAttribute(window, "resize") is "window"
PASS testScriptAttribute(window, "scroll") is "window"
PASS testScriptAttribute(window, "search") is "window"
PASS testScriptAttribute(window, "seeked") is "window"
PASS testScriptAttribute(window, "seeking") is "window"
PASS testScriptAttribute(window, "select") is "window"
Expand Down Expand Up @@ -153,7 +152,6 @@ PASS testScriptAttribute(document, "readystatechange") is "document"
PASS testScriptAttribute(document, "reset") is "document"
PASS testScriptAttribute(document, "resize") is "document"
PASS testScriptAttribute(document, "scroll") is "document"
PASS testScriptAttribute(document, "search") is "document"
PASS testScriptAttribute(document, "seeked") is "document"
PASS testScriptAttribute(document, "seeking") is "document"
PASS testScriptAttribute(document, "select") is "document"
Expand Down Expand Up @@ -248,7 +246,6 @@ PASS testElementAttribute(element, "ratechange") is "target"
PASS testElementAttribute(element, "reset") is "target"
PASS testElementAttribute(element, "resize") is "target"
PASS testElementAttribute(element, "scroll") is "target"
PASS testElementAttribute(element, "search") is "target"
PASS testElementAttribute(element, "seeked") is "target"
PASS testElementAttribute(element, "seeking") is "target"
PASS testElementAttribute(element, "select") is "target"
Expand Down Expand Up @@ -341,7 +338,6 @@ PASS testElementAttribute(inputElement, "ratechange") is "target"
PASS testElementAttribute(inputElement, "reset") is "target"
PASS testElementAttribute(inputElement, "resize") is "target"
PASS testElementAttribute(inputElement, "scroll") is "target"
PASS testElementAttribute(inputElement, "search") is "target"
PASS testElementAttribute(inputElement, "seeked") is "target"
PASS testElementAttribute(inputElement, "seeking") is "target"
PASS testElementAttribute(inputElement, "select") is "target"
Expand Down Expand Up @@ -434,7 +430,6 @@ PASS testElementAttribute(audioElement, "ratechange") is "target"
PASS testElementAttribute(audioElement, "reset") is "target"
PASS testElementAttribute(audioElement, "resize") is "target"
PASS testElementAttribute(audioElement, "scroll") is "target"
PASS testElementAttribute(audioElement, "search") is "target"
PASS testElementAttribute(audioElement, "seeked") is "target"
PASS testElementAttribute(audioElement, "seeking") is "target"
PASS testElementAttribute(audioElement, "select") is "target"
Expand Down Expand Up @@ -527,7 +522,6 @@ PASS testElementAttribute(videoElement, "ratechange") is "target"
PASS testElementAttribute(videoElement, "reset") is "target"
PASS testElementAttribute(videoElement, "resize") is "target"
PASS testElementAttribute(videoElement, "scroll") is "target"
PASS testElementAttribute(videoElement, "search") is "target"
PASS testElementAttribute(videoElement, "seeked") is "target"
PASS testElementAttribute(videoElement, "seeking") is "target"
PASS testElementAttribute(videoElement, "select") is "target"
Expand Down Expand Up @@ -633,7 +627,6 @@ PASS testElementAttribute(bodyElement, "progress") is "target"
PASS testElementAttribute(bodyElement, "ratechange") is "target"
PASS testElementAttribute(bodyElement, "reset") is "target"
FAIL testElementAttribute(bodyElement, "scroll") should be target. Was window.
PASS testElementAttribute(bodyElement, "search") is "target"
PASS testElementAttribute(bodyElement, "seeked") is "target"
PASS testElementAttribute(bodyElement, "seeking") is "target"
PASS testElementAttribute(bodyElement, "select") is "target"
Expand Down Expand Up @@ -729,7 +722,6 @@ PASS testElementAttribute(framesetElement, "progress") is "target"
PASS testElementAttribute(framesetElement, "ratechange") is "target"
PASS testElementAttribute(framesetElement, "reset") is "target"
FAIL testElementAttribute(framesetElement, "scroll") should be target. Was window.
PASS testElementAttribute(framesetElement, "search") is "target"
PASS testElementAttribute(framesetElement, "seeked") is "target"
PASS testElementAttribute(framesetElement, "seeking") is "target"
PASS testElementAttribute(framesetElement, "select") is "target"
Expand Down Expand Up @@ -812,7 +804,6 @@ PASS testElementAttribute(rectElement, "ratechange") is "target"
PASS testElementAttribute(rectElement, "reset") is "target"
PASS testElementAttribute(rectElement, "resize") is "target"
PASS testElementAttribute(rectElement, "scroll") is "target"
PASS testElementAttribute(rectElement, "search") is "target"
PASS testElementAttribute(rectElement, "seeked") is "target"
PASS testElementAttribute(rectElement, "seeking") is "target"
PASS testElementAttribute(rectElement, "select") is "target"
Expand Down Expand Up @@ -915,7 +906,6 @@ PASS testElementAttribute(nonHTMLElement, "readystatechange") is "none"
PASS testElementAttribute(nonHTMLElement, "reset") is "none"
PASS testElementAttribute(nonHTMLElement, "resize") is "none"
PASS testElementAttribute(nonHTMLElement, "scroll") is "none"
PASS testElementAttribute(nonHTMLElement, "search") is "none"
PASS testElementAttribute(nonHTMLElement, "seeked") is "none"
PASS testElementAttribute(nonHTMLElement, "seeking") is "none"
PASS testElementAttribute(nonHTMLElement, "select") is "none"
Expand Down
1 change: 0 additions & 1 deletion LayoutTests/fast/dom/event-handler-attributes.html
Expand Up @@ -76,7 +76,6 @@
"transitionend",
"volumechange",
"waiting",
"search",
"wheel",
"webkitanimationend",
"webkitanimationiteration",
Expand Down
1 change: 0 additions & 1 deletion LayoutTests/fast/dom/resources/wrapper-identity-base.js
Expand Up @@ -137,7 +137,6 @@ var staticWindowProperties = [
'onreset',
'onresize',
'onscroll',
'onsearch',
'onselect',
'onsubmit',
'onunload',
Expand Down
1 change: 0 additions & 1 deletion LayoutTests/fast/dom/wrapper-identity-expected.txt
Expand Up @@ -146,7 +146,6 @@ PASS var object = window['onmousewheel']; isEqualJS(object, object); is true
PASS var object = window['onreset']; isEqualJS(object, object); is true
PASS var object = window['onresize']; isEqualJS(object, object); is true
PASS var object = window['onscroll']; isEqualJS(object, object); is true
PASS var object = window['onsearch']; isEqualJS(object, object); is true
PASS var object = window['onselect']; isEqualJS(object, object); is true
PASS var object = window['onsubmit']; isEqualJS(object, object); is true
PASS var object = window['onunload']; isEqualJS(object, object); is true
Expand Down
4 changes: 0 additions & 4 deletions LayoutTests/fast/events/onsearch-enter-expected.txt

This file was deleted.

25 changes: 0 additions & 25 deletions LayoutTests/fast/events/onsearch-enter.html

This file was deleted.

13 changes: 0 additions & 13 deletions LayoutTests/fast/forms/incremental-dom-property-expected.txt

This file was deleted.

28 changes: 0 additions & 28 deletions LayoutTests/fast/forms/incremental-dom-property.html

This file was deleted.

17 changes: 0 additions & 17 deletions LayoutTests/fast/forms/input-search-press-escape-key-expected.txt

This file was deleted.

79 changes: 0 additions & 79 deletions LayoutTests/fast/forms/input-search-press-escape-key.html

This file was deleted.

0 comments on commit 99ff083

Please sign in to comment.