GPUConnectionToWebProcess::setTCCIdentity need to check that it has a…

… bundle identifier before calling tcc_identity_create

https://bugs.webkit.org/show_bug.cgi?id=271459
rdar://122836442

Reviewed by Eric Carlson.

As can be seen from crash logs, we are sometimes calling tcc_identity_create with a nullptr identifier.
This identifier is coming from the bundle proxy created by [LSBundleProxy bundleProxyWithAuditToken:error:].
This function can probably return nil without an error, or the returned bundle proxy has a nullptr identifier.
We add an if check that covers both cases and add release logging to know the exact issue.

* Source/WebKit/GPUProcess/cocoa/GPUConnectionToWebProcessCocoa.mm:
(WebKit::GPUConnectionToWebProcess::setTCCIdentity):

Canonical link: https://commits.webkit.org/276549@main

Source/WebKit/GPUProcess/cocoa/GPUConnectionToWebProcessCocoa.mm

@@ -92,7 +92,13 @@
         return;
     }
 
-    auto identity = adoptOSObject(tcc_identity_create(TCC_IDENTITY_CODE_BUNDLE_ID, [bundleProxy.bundleIdentifier UTF8String]));
+    const auto* bundleIdentifier = [bundleProxy.bundleIdentifier UTF8String];
+    if (!bundleIdentifier) {
+        RELEASE_LOG_ERROR(WebRTC, "Unable to get the bundle identifier, bundle is %d", !!bundleProxy);
+        return;
+    }
+
+    auto identity = adoptOSObject(tcc_identity_create(TCC_IDENTITY_CODE_BUNDLE_ID, bundleIdentifier));
     if (!identity) {
         RELEASE_LOG_ERROR(WebRTC, "tcc_identity_create returned null");
         return;