Skip to content

Commit

Permalink
[resultsdbpy] Add "no results" message for when no test results are r…
Browse files Browse the repository at this point in the history
…eturned from the server.

rdar://113864624
https://bugs.webkit.org/show_bug.cgi?id=260162

Reviewed by Jonathan Bedard.

Adds/demystifies UI feedback for no build results found for existing test.

* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/timeline.js:
(TimelineFromEndpoint.prototype.reload):

Canonical link: https://commits.webkit.org/266916@main
  • Loading branch information
bls1999 committed Aug 15, 2023
1 parent de8fac4 commit 9b47de8
Showing 1 changed file with 7 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,13 @@ class TimelineFromEndpoint {
response.json().then(json => {
if (myDispatch !== this.latestDispatch)
return;
else if (json.length === 0) {
this.ref.setState({
error: "No results found for the requested test under the selected configuration.",
description: "This could be because the selected configuration is not tested (check test expectations), no builds were completed, or the test does not exist."
});
return;
}

let oldestUuid = Date.now() / 10;
let newestUuid = 0;
Expand Down

0 comments on commit 9b47de8

Please sign in to comment.