Merge r186981 - (display: block)input range's thumb disappears when m…

…oved. https://bugs.webkit.org/show_bug.cgi?id=146896 <rdar://problem/21787807> Reviewed by Simon Fraser. Since the thumb is positioned after the layout for the input (shadow) subtree is finished, the repaint rects issued during the layout will not cover the re-positioned thumb. We need to issue a repaint soon after the thumb is re-positioned. Source/WebCore: Test: fast/repaint/block-inputrange-repaint.html * html/shadow/SliderThumbElement.cpp: (WebCore::RenderSliderContainer::layout): LayoutTests: * fast/repaint/block-inputrange-repaint-expected.txt: Added. * fast/repaint/block-inputrange-repaint.html: Added.
WebKit · Aug 4, 2015 · 9b6dbb1 · 9b6dbb1
1 parent 7c167b6
commit 9b6dbb1
Show file tree

Hide file tree

Showing 5 changed files with 66 additions and 0 deletions.
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
@@ -1,3 +1,18 @@
+2015-07-17  Zalan Bujtas  <zalan@apple.com>
+
+        (display: block)input range's thumb disappears when moved.
+        https://bugs.webkit.org/show_bug.cgi?id=146896
+        <rdar://problem/21787807>
+
+        Reviewed by Simon Fraser.
+
+        Since the thumb is positioned after the layout for the input (shadow) subtree is finished, the repaint rects
+        issued during the layout will not cover the re-positioned thumb.
+        We need to issue a repaint soon after the thumb is re-positioned.
+
+        * fast/repaint/block-inputrange-repaint-expected.txt: Added.
+        * fast/repaint/block-inputrange-repaint.html: Added.
+
 2015-07-17  Myles C. Maxfield  <mmaxfield@apple.com>
 
         style.fontFamily accessor crashes on unstyled node created from DOMParser().parseFromString()

diff --git a/LayoutTests/fast/repaint/block-inputrange-repaint-expected.txt b/LayoutTests/fast/repaint/block-inputrange-repaint-expected.txt
@@ -0,0 +1,5 @@
+PASS repaintRects.indexOf('495 8 15 15') is not -1
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
diff --git a/LayoutTests/fast/repaint/block-inputrange-repaint.html b/LayoutTests/fast/repaint/block-inputrange-repaint.html
@@ -0,0 +1,28 @@
+<!DOCTYPE html>
+<head>
+<title>This tests when input=range is block we issue correct repaint rects</title>
+<script>jsTestIsAsync = true;</script>
+<script src="../../resources/js-test-pre.js"></script>
+<style>
+  input[type="range"] {
+    display: block;
+    width: 500px;
+  }
+</style>
+</head>
+<body>
+<input id=moveme type=range>
+<script>
+  window.internals.startTrackingRepaints();
+  document.getElementById("moveme").value = 100;
+  document.body.offsetHeight;
+  if (window.internals) {
+    repaintRects = window.internals.repaintRectsAsText();
+    window.internals.stopTrackingRepaints();
+    shouldNotBe("repaintRects.indexOf('495 8 15 15')", "-1");
+    finishJSTest();
+  }
+</script>
+</body>
+<script src="../../resources/js-test-post.js"></script>
+</html>
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
@@ -1,3 +1,20 @@
+2015-07-17  Zalan Bujtas  <zalan@apple.com>
+
+        (display: block)input range's thumb disappears when moved.
+        https://bugs.webkit.org/show_bug.cgi?id=146896
+        <rdar://problem/21787807>
+
+        Reviewed by Simon Fraser.
+
+        Since the thumb is positioned after the layout for the input (shadow) subtree is finished, the repaint rects
+        issued during the layout will not cover the re-positioned thumb.
+        We need to issue a repaint soon after the thumb is re-positioned.
+
+        Test: fast/repaint/block-inputrange-repaint.html
+
+        * html/shadow/SliderThumbElement.cpp:
+        (WebCore::RenderSliderContainer::layout):
+
 2015-07-17  Myles C. Maxfield  <mmaxfield@apple.com>
 
         style.fontFamily accessor crashes on unstyled node created from DOMParser().parseFromString()

diff --git a/Source/WebCore/html/shadow/SliderThumbElement.cpp b/Source/WebCore/html/shadow/SliderThumbElement.cpp
@@ -190,6 +190,7 @@ void RenderSliderContainer::layout()
     else
         thumbLocation.setX(thumbLocation.x() - offset);
     thumb->setLocation(thumbLocation);
+    thumb->repaint();
 }
 
 // --------------------------------