-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Get DisplayLink-related code out of WebProcessPool
https://bugs.webkit.org/show_bug.cgi?id=252505 rdar://105613366 Reviewed by Tim Horton. The list of DisplayLink objects is stored on WebProcessPool, since they are shared between all WebPageProxy objects that use the same process pool. However, we don't need to pollute the WebProcessPool API with DisplayLink-related functions; instead, just expose `DisplayLinkCollection` and move the functionality into that class. WebProcessProxy gains a couple more wrapper functions related to DisplayLinks. Move to the more conventional `displayLinkForDisplay()` and `existingDisplayLinkForDisplay()` terminology. * Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::displayPropertiesChanged): (WebKit::WebProcessPool::nominalFramesPerSecondForDisplay): Deleted. (WebKit::WebProcessPool::startDisplayLink): Deleted. (WebKit::WebProcessPool::stopDisplayLink): Deleted. (WebKit::WebProcessPool::stopDisplayLinks): Deleted. (WebKit::WebProcessPool::setDisplayLinkPreferredFramesPerSecond): Deleted. (WebKit::WebProcessPool::setDisplayLinkForDisplayWantsFullSpeedUpdates): Deleted. * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.mm: (WebKit::RemoteLayerTreeDrawingAreaProxyMac::exisingDisplayLink): (WebKit::RemoteLayerTreeDrawingAreaProxyMac::ensureDisplayLink): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::updateDisplayLinkFrequency): (WebKit::WebPageProxy::windowScreenDidChange): * Source/WebKit/UIProcess/WebProcessPool.h: * Source/WebKit/UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::~WebProcessProxy): (WebKit::WebProcessProxy::processWillShutDown): * Source/WebKit/UIProcess/WebProcessProxy.h: * Source/WebKit/UIProcess/mac/DisplayLink.cpp: (WebKit::DisplayLink::DisplayLink): (WebKit::DisplayLink::nominalFramesPerSecondFromDisplayLink): (WebKit::DisplayLink::addObserver): (WebKit::DisplayLink::setObserverPreferredFramesPerSecond): (WebKit::DisplayLink::notifyObserversDisplayWasRefreshed): (WebKit::DisplayLinkCollection::displayLinkForDisplay): (WebKit::DisplayLinkCollection::existingDisplayLinkForDisplay const): (WebKit::DisplayLinkCollection::nominalFramesPerSecondForDisplay): (WebKit::DisplayLinkCollection::startDisplayLink): (WebKit::DisplayLinkCollection::stopDisplayLink): (WebKit::DisplayLinkCollection::stopDisplayLinks): (WebKit::DisplayLinkCollection::setDisplayLinkPreferredFramesPerSecond): (WebKit::DisplayLinkCollection::setDisplayLinkForDisplayWantsFullSpeedUpdates): (WebKit::DisplayLinkCollection::displayLinkForDisplay const): Deleted. * Source/WebKit/UIProcess/mac/DisplayLink.h: (WebKit::DisplayLinkCollection::displayLinks const): Deleted. * Source/WebKit/UIProcess/mac/WebProcessProxyMac.mm: (WebKit::WebProcessProxy::nominalFramesPerSecondForDisplay): (WebKit::WebProcessProxy::startDisplayLink): (WebKit::WebProcessProxy::stopDisplayLink): (WebKit::WebProcessProxy::setDisplayLinkPreferredFramesPerSecond): (WebKit::WebProcessProxy::setDisplayLinkForDisplayWantsFullSpeedUpdates): * Source/WebKit/UIProcess/mac/WebViewImpl.mm: (WebKit::WebViewImpl::windowDidChangeScreen): Canonical link: https://commits.webkit.org/260489@main
- Loading branch information
Showing
10 changed files
with
103 additions
and
97 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters