Skip to content

Commit

Permalink
Merge r241491 - Unreviewed GTK test gardening
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=194631

* platform/gtk/TestExpectations:
* platform/gtk/editing/pasteboard/smart-paste-007-expected.txt:
* platform/gtk/editing/pasteboard/smart-paste-008-expected.txt:
  • Loading branch information
ntrrgc authored and carlosgcampos committed Feb 14, 2019
1 parent 731243c commit 9d5e3e2
Show file tree
Hide file tree
Showing 4 changed files with 46 additions and 51 deletions.
9 changes: 9 additions & 0 deletions LayoutTests/ChangeLog
@@ -1,3 +1,12 @@
2019-02-13 Alicia Boya García <aboya@igalia.com>

Unreviewed GTK test gardening
https://bugs.webkit.org/show_bug.cgi?id=194631

* platform/gtk/TestExpectations:
* platform/gtk/editing/pasteboard/smart-paste-007-expected.txt:
* platform/gtk/editing/pasteboard/smart-paste-008-expected.txt:

2019-02-13 Jer Noble <jer.noble@apple.com>

Entering fullscreen inside a shadow root will not set fullscreen pseudoclasses outside of root
Expand Down
14 changes: 14 additions & 0 deletions LayoutTests/platform/gtk/TestExpectations
Expand Up @@ -1357,6 +1357,9 @@ webkit.org/b/191882 fast/forms/validation-message-in-relative-body.html [ Failur

webkit.org/b/194385 imported/w3c/web-platform-tests/service-workers/service-worker/clients-get.https.html [ Crash ]

webkit.org/b/194630 accessibility/removed-anonymous-block-child-causes-crash.html [ Crash ]
webkit.org/b/194630 accessibility/removed-continuation-element-causes-crash.html [ Crash ]

#////////////////////////////////////////////////////////////////////////////////////////
# End of Crashing tests
#////////////////////////////////////////////////////////////////////////////////////////
Expand Down Expand Up @@ -2432,6 +2435,7 @@ webkit.org/b/156109 http/tests/security/contentSecurityPolicy/video-redirect-blo
webkit.org/b/158921 http/tests/security/video-cross-origin-caching.html [ Timeout ]

webkit.org/b/158923 media/airplay-autoplay.html [ Timeout ]
webkit.org/b/158923 media/airplay-allows-buffering.html [ Timeout ]

webkit.org/b/162017 http/tests/navigation/ping-attribute/anchor-cookie.html [ Timeout ]
webkit.org/b/162017 http/tests/navigation/ping-attribute/anchor-cross-origin-from-https.html [ Timeout ]
Expand Down Expand Up @@ -2516,6 +2520,10 @@ webkit.org/b/193635 imported/w3c/web-platform-tests/resource-timing/resource_tim

webkit.org/b/193636 imported/w3c/web-platform-tests/service-workers/service-worker/websocket-in-service-worker.https.html [ Failure ]

webkit.org/b/194629 http/tests/websocket/connection-refusal-in-frame-resource-load-statistics.html [ Timeout ]

webkit.org/b/137311 media/video-fullscreeen-only-playback.html [ Timeout ]

#////////////////////////////////////////////////////////////////////////////////////////
# End of Tests timing out
#////////////////////////////////////////////////////////////////////////////////////////
Expand Down Expand Up @@ -3741,6 +3749,12 @@ webkit.org/b/193641 webrtc/video-setDirection.html [ Failure ]

webkit.org/b/194384 compositing/clipping/border-radius-async-overflow-clipping-layer.html [ Failure ]

webkit.org/b/194606 accessibility/set-value-not-work-for-disabled-sliders.html [ Failure ]

webkit.org/b/194609 http/tests/local/blob/send-hybrid-blob-using-open-panel.html [ Failure ]

webkit.org/b/194611 http/wpt/webrtc/getUserMedia-processSwapping.html [ Failure ]

#////////////////////////////////////////////////////////////////////////////////////////
# End of non-crashing, non-flaky tests failing
#////////////////////////////////////////////////////////////////////////////////////////
Expand Down
Expand Up @@ -20,30 +20,13 @@ EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotificatio
EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 7 of #text > DIV > DIV > BODY > HTML > #document to 7 of #text > DIV > DIV > BODY > HTML > #document toDOMRange:range from 6 of #text > DIV > DIV > BODY > HTML > #document to 6 of #text > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x584
RenderBlock {DIV} at (0,0) size 784x206 [border: (2px solid #0000FF)]
RenderBlock {DIV} at (14,14) size 756x54
RenderText {#text} at (0,0) size 65x26
text run at (0,0) width 65: "Tests: "
RenderBR {BR} at (0,0) size 0x0
RenderText {#text} at (0,27) size 460x26
text run at (0,27) width 460: "Smart paste when pasting between two periods."
RenderBlock {DIV} at (14,84) size 756x108
RenderText {#text} at (0,0) size 189x26
text run at (0,0) width 189: "Expected Results: "
RenderBR {BR} at (188,21) size 1x0
RenderText {#text} at (0,27) size 743x53
text run at (0,27) width 743: "A space should be added before, but not after the pasted word. It should look"
text run at (0,54) width 91: "like this: "
RenderBR {BR} at (91,75) size 0x0
RenderText {#text} at (0,81) size 52x26
text run at (0,81) width 52: ". test."
RenderBlock {DIV} at (0,230) size 784x31
RenderBlock {DIV} at (0,0) size 784x31 [border: (2px solid #FF0000)]
RenderText {#text} at (2,2) size 52x26
text run at (2,2) width 52: ". test."
caret: position 6 of child 0 {#text} of child 1 {DIV} of child 3 {DIV} of body
Tests:
Smart paste when pasting between two periods.
Expected Results:
A space should be added before, but not after the pasted word. It should look like this:
. test.
. test.
execCutCommand: <div id="test" class="editing"><br></div>
execTypeCharacterCommand: <div id="test" class="editing">.</div>
execTypeCharacterCommand: <div id="test" class="editing">..</div>
execPasteCommand: <div id="test" class="editing">. test.</div>
@@ -1,33 +1,22 @@
EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 2 of DIV > BODY > HTML > #document
EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > DIV > DIV > BODY > HTML > #document to 2 of DIV > DIV > DIV > BODY > HTML > #document
EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > DIV > BODY > HTML > #document to 0 of DIV > DIV > BODY > HTML > #document toDOMRange:range from 0 of #text > DIV > DIV > BODY > HTML > #document to 3 of #text > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > DIV > DIV > DIV > BODY > HTML > #document to 0 of DIV > DIV > DIV > DIV > BODY > HTML > #document toDOMRange:range from 1 of #text > DIV > DIV > DIV > DIV > BODY > HTML > #document to 1 of #text > DIV > DIV > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 1 of #text > DIV > DIV > DIV > DIV > BODY > HTML > #document to 1 of #text > DIV > DIV > DIV > DIV > BODY > HTML > #document toDOMRange:range from 0 of #text > DIV > DIV > DIV > DIV > BODY > HTML > #document to 3 of #text > DIV > DIV > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 1 of #text > DIV > DIV > BODY > HTML > #document to 1 of #text > DIV > DIV > BODY > HTML > #document givenAction:WebViewInsertActionPasted
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 1 of #text > DIV > DIV > BODY > HTML > #document to 1 of DIV > BODY > HTML > #document toDOMRange:range from 5 of #text > DIV > DIV > BODY > HTML > #document to 5 of #text > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 1 of #text > DIV > DIV > DIV > DIV > BODY > HTML > #document to 1 of #text > DIV > DIV > DIV > DIV > BODY > HTML > #document givenAction:WebViewInsertActionPasted
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 1 of #text > DIV > DIV > DIV > DIV > BODY > HTML > #document to 1 of DIV > DIV > DIV > BODY > HTML > #document toDOMRange:range from 5 of #text > DIV > DIV > DIV > DIV > BODY > HTML > #document to 5 of #text > DIV > DIV > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x584
RenderBlock {P} at (0,0) size 784x36
RenderText {#text} at (0,0) size 773x35
text run at (0,0) width 394: "There was a bug in paste's smart replace whitespace handling. "
text run at (394,0) width 379: "In some cases, it used information gathered at the start of the"
text run at (0,18) width 722: "selection being pasted into to decide whether or not a space needed to be added to the end of the incoming content."
RenderBlock {P} at (0,52) size 784x36
RenderText {#text} at (0,0) size 764x35
text run at (0,0) width 547: "A smart paste is performed into a selection starting in one block and ending in another. "
text run at (546,0) width 218: "Spaces should surround the pasted"
text run at (0,18) width 37: "word."
RenderBlock {DIV} at (0,104) size 784x18
RenderBlock {DIV} at (0,0) size 784x18
RenderText {#text} at (0,0) size 54x17
text run at (0,0) width 54: "f foo bar"
caret: position 5 of child 0 {#text} of child 0 {DIV} of child 4 {DIV} of body
There was a bug in paste's smart replace whitespace handling. In some cases, it used information gathered at the start of the selection being pasted into to decide whether or not a space needed to be added to the end of the incoming content.

Expected Results:
A smart paste is performed into a selection starting in one block and ending in another. Spaces should surround the pasted word and look like:
f foo bar
f foo bar

0 comments on commit 9d5e3e2

Please sign in to comment.