-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove InjectedBundlePagePolicyClient
https://bugs.webkit.org/show_bug.cgi?id=247169 rdar://101655797 Reviewed by Tim Horton. There was one layout test, fast/loader/policy-delegate-action-hit-test-zoomed.html, which printed the dom node path of the clicked link. This functionality is not available nor needed in WK2. The WK1 test still verifies it. WK2 has _WKHitTestResult with tests to verify we get the node info we need in this case. * Source/WebKit/Sources.txt: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageSetPolicyClient): * Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp: Removed. * Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h: Removed. * Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse): (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebKit::WebFrameLoaderClient::dispatchUnableToImplementPolicy): * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::close): (WebKit::WebPage::initializeInjectedBundlePolicyClient): Deleted. * Source/WebKit/WebProcess/WebPage/WebPage.h: (WebKit::WebPage::injectedBundleLoaderClient): (WebKit::WebPage::injectedBundlePolicyClient): Deleted. Canonical link: https://commits.webkit.org/256491@main
- Loading branch information
1 parent
1974887
commit 9eeab8d
Showing
46 changed files
with
247 additions
and
372 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
Policy delegate: attempt to load mailto:?subject=%E3%82%BF%E3%82%A4%E3%83%88%E3%83%AB&body=%E6%9C%AC%E6%96%87 with navigation type 'link clicked' originating from #text > SPAN > A > BODY > HTML > #document | ||
Policy delegate: attempt to load mailto:?subject=%E3%82%BF%E3%82%A4%E3%83%88%E3%83%AB&body=%E6%9C%AC%E6%96%87 with navigation type 'link clicked' | ||
Test encoding of mailto URLs. Click on the URL - a new message with Japanese subject and body should open in your mail client. | ||
|
||
Subject : Japanese Body : Japanese |
2 changes: 1 addition & 1 deletion
2
LayoutTests/fast/forms/mailto/formenctype-attribute-button-html-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
Policy delegate: attempt to load mailto:?body=to%3Done%40example.org%0D%0Abody%3DLine%201%0D%0ALine%202%0D%0A%40%0D%0A%3D%2C%3B%3F%22%20%0D%0A with navigation type 'form submitted' originating from HTML > #document | ||
Policy delegate: attempt to load mailto:?body=to%3Done%40example.org%0D%0Abody%3DLine%201%0D%0ALine%202%0D%0A%40%0D%0A%3D%2C%3B%3F%22%20%0D%0A with navigation type 'form submitted' | ||
Field 1: Field 2: |
2 changes: 1 addition & 1 deletion
2
LayoutTests/fast/forms/mailto/formenctype-attribute-input-2-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
Policy delegate: attempt to load mailto:?body=to%3Done%40example.org%0D%0Abody%3DLine%201%0D%0ALine%202%0D%0A%40%0D%0A%3D%2C%3B%3F%20%0D%0A with navigation type 'form submitted' originating from INPUT > FORM > BODY > HTML > #document | ||
Policy delegate: attempt to load mailto:?body=to%3Done%40example.org%0D%0Abody%3DLine%201%0D%0ALine%202%0D%0A%40%0D%0A%3D%2C%3B%3F%20%0D%0A with navigation type 'form submitted' | ||
Field 1: Field 2: |
2 changes: 1 addition & 1 deletion
2
LayoutTests/fast/forms/mailto/formenctype-attribute-input-html-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
Policy delegate: attempt to load mailto:?body=to%3Done%40example.org%0D%0Abody%3DLine%201%0D%0ALine%202%0D%0A%40%0D%0A%3D%2C%3B%3F%22%20%0D%0A with navigation type 'form submitted' originating from HTML > #document | ||
Policy delegate: attempt to load mailto:?body=to%3Done%40example.org%0D%0Abody%3DLine%201%0D%0ALine%202%0D%0A%40%0D%0A%3D%2C%3B%3F%22%20%0D%0A with navigation type 'form submitted' | ||
Field 1: Field 2: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
LayoutTests/fast/loader/policy-delegate-action-hit-test-zoomed-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
LayoutTests/http/tests/misc/policy-delegate-called-twice-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
LayoutTests/platform/mac-wk1/fast/encoding/mailto-always-utf-8-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Policy delegate: attempt to load mailto:?subject=%E3%82%BF%E3%82%A4%E3%83%88%E3%83%AB&body=%E6%9C%AC%E6%96%87 with navigation type 'link clicked' originating from #text > SPAN > A > BODY > HTML > #document | ||
Test encoding of mailto URLs. Click on the URL - a new message with Japanese subject and body should open in your mail client. | ||
|
||
Subject : Japanese Body : Japanese |
2 changes: 2 additions & 0 deletions
2
...utTests/platform/mac-wk1/fast/forms/mailto/formenctype-attribute-button-html-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Policy delegate: attempt to load mailto:?body=to%3Done%40example.org%0D%0Abody%3DLine%201%0D%0ALine%202%0D%0A%40%0D%0A%3D%2C%3B%3F%22%20%0D%0A with navigation type 'form submitted' originating from HTML > #document | ||
Field 1: Field 2: |
2 changes: 2 additions & 0 deletions
2
LayoutTests/platform/mac-wk1/fast/forms/mailto/formenctype-attribute-input-2-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Policy delegate: attempt to load mailto:?body=to%3Done%40example.org%0D%0Abody%3DLine%201%0D%0ALine%202%0D%0A%40%0D%0A%3D%2C%3B%3F%20%0D%0A with navigation type 'form submitted' originating from INPUT > FORM > BODY > HTML > #document | ||
Field 1: Field 2: |
2 changes: 2 additions & 0 deletions
2
LayoutTests/platform/mac-wk1/fast/forms/mailto/formenctype-attribute-input-html-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Policy delegate: attempt to load mailto:?body=to%3Done%40example.org%0D%0Abody%3DLine%201%0D%0ALine%202%0D%0A%40%0D%0A%3D%2C%3B%3F%22%20%0D%0A with navigation type 'form submitted' originating from HTML > #document | ||
Field 1: Field 2: |
6 changes: 6 additions & 0 deletions
6
LayoutTests/platform/mac-wk1/fast/loader/policy-delegate-action-hit-test-zoomed-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
Policy delegate: attempt to load about:blank with navigation type 'link clicked' originating from #text > A > BODY > HTML > #document | ||
This is a test for rdar://problem/6755137 Action dictionary for policy decision is missing keys when full-page zoom is used. | ||
|
||
Link | ||
The policy delegate message should indicate that the originating node is the text child of an anchor element. | ||
|
8 changes: 8 additions & 0 deletions
8
LayoutTests/platform/mac-wk1/http/tests/misc/policy-delegate-called-twice-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
Policy delegate: attempt to load http://127.0.0.1:8000/misc/resources/iframe-policy-2.html with navigation type 'link clicked' originating from HTML > #document | ||
This page has an iframe which will navigate itself. The policy delegate callbacks will be dumped. The delegate should only be consulted once. | ||
|
||
|
||
-------- | ||
Frame: '<!--frame1-->' | ||
-------- | ||
You've reached the second page. Congratulations. |
4 changes: 4 additions & 0 deletions
4
LayoutTests/platform/win/fast/encoding/mailto-always-utf-8-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Policy delegate: attempt to load mailto:?subject=%E3%82%BF%E3%82%A4%E3%83%88%E3%83%AB&body=%E6%9C%AC%E6%96%87 with navigation type 'link clicked' originating from #text > SPAN > A > BODY > HTML > #document | ||
Test encoding of mailto URLs. Click on the URL - a new message with Japanese subject and body should open in your mail client. | ||
|
||
Subject : Japanese Body : Japanese |
2 changes: 2 additions & 0 deletions
2
LayoutTests/platform/win/fast/forms/mailto/formenctype-attribute-button-html-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Policy delegate: attempt to load mailto:?body=to%3Done%40example.org%0D%0Abody%3DLine%201%0D%0ALine%202%0D%0A%40%0D%0A%3D%2C%3B%3F%22%20%0D%0A with navigation type 'form submitted' originating from HTML > #document | ||
Field 1: Field 2: |
2 changes: 2 additions & 0 deletions
2
LayoutTests/platform/win/fast/forms/mailto/formenctype-attribute-input-2-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Policy delegate: attempt to load mailto:?body=to%3Done%40example.org%0D%0Abody%3DLine%201%0D%0ALine%202%0D%0A%40%0D%0A%3D%2C%3B%3F%20%0D%0A with navigation type 'form submitted' originating from INPUT > FORM > BODY > HTML > #document | ||
Field 1: Field 2: |
2 changes: 2 additions & 0 deletions
2
LayoutTests/platform/win/fast/forms/mailto/formenctype-attribute-input-html-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Policy delegate: attempt to load mailto:?body=to%3Done%40example.org%0D%0Abody%3DLine%201%0D%0ALine%202%0D%0A%40%0D%0A%3D%2C%3B%3F%22%20%0D%0A with navigation type 'form submitted' originating from HTML > #document | ||
Field 1: Field 2: |
6 changes: 6 additions & 0 deletions
6
LayoutTests/platform/win/fast/loader/policy-delegate-action-hit-test-zoomed-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
Policy delegate: attempt to load about:blank with navigation type 'link clicked' originating from #text > A > BODY > HTML > #document | ||
This is a test for rdar://problem/6755137 Action dictionary for policy decision is missing keys when full-page zoom is used. | ||
|
||
Link | ||
The policy delegate message should indicate that the originating node is the text child of an anchor element. | ||
|
8 changes: 8 additions & 0 deletions
8
LayoutTests/platform/win/http/tests/misc/policy-delegate-called-twice-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
Policy delegate: attempt to load http://127.0.0.1:8000/misc/resources/iframe-policy-2.html with navigation type 'link clicked' originating from HTML > #document | ||
This page has an iframe which will navigate itself. The policy delegate callbacks will be dumped. The delegate should only be consulted once. | ||
|
||
|
||
-------- | ||
Frame: '<!--frame1-->' | ||
-------- | ||
You've reached the second page. Congratulations. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.