Skip to content

Commit

Permalink
REGRESSION (278263@main): [UnifiedPDF] Error about ProcessCapabilitie…
Browse files Browse the repository at this point in the history
…s::canUseAcceleratedBuffers()

https://bugs.webkit.org/show_bug.cgi?id=273658
rdar://127462832

Reviewed by Abrar Rahman Protyasha and Sammy Gill.

We can't mix and match accelerated drawing, and accessing the platform context, because this
tries to map IOSurfaces into the webcontent process, which is denied by the sandbox.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::ensureLayers):

Canonical link: https://commits.webkit.org/278295@main
  • Loading branch information
smfr committed May 3, 2024
1 parent c277969 commit a2d74c7
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,8 @@ static String mutationObserverNotificationString()
m_selectionLayer = createGraphicsLayer("PDF selections"_s, GraphicsLayer::Type::TiledBacking);
m_selectionLayer->setAnchorPoint({ });
m_selectionLayer->setDrawsContent(true);
m_selectionLayer->setAcceleratesDrawing(true);
if (canPaintSelectionIntoOwnedLayer())
m_selectionLayer->setAcceleratesDrawing(true);
m_selectionLayer->setBlendMode(BlendMode::Multiply);
m_scrolledContentsLayer->addChild(*m_selectionLayer);
}
Expand Down

0 comments on commit a2d74c7

Please sign in to comment.