Skip to content

Commit

Permalink
REGRESSION (r291587): [ iOS ] editing/deleting/insert-in-orphaned-sel…
Browse files Browse the repository at this point in the history
…ection-crash.html is a constant text failure (238282)

https://bugs.webkit.org/show_bug.cgi?id=238282
<rdar://problem/90720306>

Reviewed by Aditya Keerthi.

In r291587 we started dropping native appearance for non-form control elements with
specified author style. This is the correct behavior, but requires adjusting this
test which relies on the appearance of a table element in order to reproduce a
non-appearance related crash. This patch updates the test to add table data tags which
ensure the table element gets included in the selectAll() command to keep the test passing.

* editing/deleting/insert-in-orphaned-selection-crash.html:
* platform/ios-wk2/TestExpectations:



Canonical link: https://commits.webkit.org/248943@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
kcheney1 committed Mar 28, 2022
1 parent fce6bd5 commit a309ccc
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 3 deletions.
17 changes: 17 additions & 0 deletions LayoutTests/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,20 @@
2022-03-28 Kate Cheney <katherine_cheney@apple.com>

REGRESSION (r291587): [ iOS ] editing/deleting/insert-in-orphaned-selection-crash.html is a constant text failure (238282)
https://bugs.webkit.org/show_bug.cgi?id=238282
<rdar://problem/90720306>

Reviewed by Aditya Keerthi.

In r291587 we started dropping native appearance for non-form control elements with
specified author style. This is the correct behavior, but requires adjusting this
test which relies on the appearance of a table element in order to reproduce a
non-appearance related crash. This patch updates the test to add table data tags which
ensure the table element gets included in the selectAll() command to keep the test passing.

* editing/deleting/insert-in-orphaned-selection-crash.html:
* platform/ios-wk2/TestExpectations:

2022-03-28 Brady Eidson <beidson@apple.com>

Support ServiceWorkerClients.openWindow.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<style>
* { -webkit-appearance:default-button; }
tr { height: 10px; }
td { width: 100px; height: 100px; }
</style>
<script>
if (window.testRunner)
Expand All @@ -21,5 +22,8 @@
<textarea></textarea>
</div>
<table frame="vsides">
<tr></tr>
<tr>
<td>
</td>
</tr>
</table>
2 changes: 0 additions & 2 deletions LayoutTests/platform/ios-wk2/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -2322,8 +2322,6 @@ model-element/model-element-interactive.html [ Skip ]

webkit.org/b/237358 imported/w3c/web-platform-tests/css/css-scroll-snap/scroll-target-margin-005.html [ Failure ]

webkit.org/b/238282 editing/deleting/insert-in-orphaned-selection-crash.html [ Failure ]

fast/text/accessibility-bold.html [ Pass ]

webkit.org/b/233621 http/tests/webgpu [ Skip ]

0 comments on commit a309ccc

Please sign in to comment.