-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix deprecated system colors to match same-as requirements in CSS Col…
…or 4 https://bugs.webkit.org/show_bug.cgi?id=245609 Reviewed by Aditya Keerthi. CSS Color 4 deprecates some of the system colors and adds a "same-as" requirement for each of them. https://drafts.csswg.org/css-color-4/#deprecated-system-colors * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-compute-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-color/system-color-compute-expected.txt: Removed. * LayoutTests/platform/glib/tables/mozilla/bugs/bug103533-expected.txt: * LayoutTests/platform/gtk/TestExpectations: * LayoutTests/platform/ios-wk2/TestExpectations: * LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-color/system-color-compute-expected.txt: Removed. * LayoutTests/platform/ios/tables/mozilla/bugs/bug103533-expected.txt: * LayoutTests/platform/mac/TestExpectations: * LayoutTests/platform/mac/imported/w3c/web-platform-tests/css/css-color/system-color-compute-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-compute-expected.txt. * LayoutTests/platform/mac/tables/mozilla/bugs/bug103533-expected.txt: * Source/WebCore/rendering/RenderTheme.cpp: (WebCore::RenderTheme::systemColor const): * Source/WebCore/rendering/RenderThemeAdwaita.cpp: (WebCore::RenderThemeAdwaita::systemColor const): * Source/WebCore/rendering/RenderThemeIOS.mm: (WebCore::RenderThemeIOS::systemColor const): Canonical link: https://commits.webkit.org/268124@main
- Loading branch information
1 parent
7be6789
commit a396d02
Showing
14 changed files
with
104 additions
and
152 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 0 additions & 32 deletions
32
...form/glib/imported/w3c/web-platform-tests/css/css-color/system-color-compute-expected.txt
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 0 additions & 32 deletions
32
...tform/ios/imported/w3c/web-platform-tests/css/css-color/system-color-compute-expected.txt
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
...tform/mac/imported/w3c/web-platform-tests/css/css-color/system-color-compute-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
Parent | ||
Specified Child | ||
Inherit Child | ||
|
||
FAIL color-scheme property affects Menu system color keyword assert_not_equals: got disallowed value "rgb(246, 246, 246)" | ||
FAIL System color doesn't compute to itself on color assert_not_equals: got disallowed value "rgb(246, 246, 246)" | ||
PASS Inherited system color keyword is observable on color | ||
FAIL System color doesn't compute to itself on background-color assert_not_equals: got disallowed value "rgb(246, 246, 246)" | ||
PASS Inherited system color keyword is observable on background-color | ||
FAIL System color doesn't compute to itself on box-shadow assert_not_equals: got disallowed value "rgb(246, 246, 246) 2px 2px 0px 0px" | ||
PASS Inherited system color keyword is observable on box-shadow | ||
FAIL System color doesn't compute to itself on text-shadow assert_not_equals: got disallowed value "rgb(246, 246, 246) 2px 2px 0px" | ||
PASS Inherited system color keyword is observable on text-shadow | ||
FAIL System color doesn't compute to itself on border-left-color assert_not_equals: got disallowed value "rgb(246, 246, 246)" | ||
PASS Inherited system color keyword is observable on border-left-color | ||
FAIL System color doesn't compute to itself on border-top-color assert_not_equals: got disallowed value "rgb(246, 246, 246)" | ||
PASS Inherited system color keyword is observable on border-top-color | ||
FAIL System color doesn't compute to itself on border-right-color assert_not_equals: got disallowed value "rgb(246, 246, 246)" | ||
PASS Inherited system color keyword is observable on border-right-color | ||
FAIL System color doesn't compute to itself on border-bottom-color assert_not_equals: got disallowed value "rgb(246, 246, 246)" | ||
PASS Inherited system color keyword is observable on border-bottom-color | ||
FAIL System color doesn't compute to itself on column-rule-color assert_not_equals: got disallowed value "rgb(246, 246, 246)" | ||
PASS Inherited system color keyword is observable on column-rule-color | ||
FAIL System color doesn't compute to itself on outline-color assert_not_equals: got disallowed value "rgb(246, 246, 246)" | ||
PASS Inherited system color keyword is observable on outline-color | ||
FAIL System color doesn't compute to itself on caret-color assert_not_equals: got disallowed value "rgb(246, 246, 246)" | ||
PASS Inherited system color keyword is observable on caret-color | ||
FAIL System color doesn't compute to itself on fill assert_not_equals: got disallowed value "rgb(246, 246, 246)" | ||
PASS Inherited system color keyword is observable on fill | ||
FAIL System color doesn't compute to itself on stroke assert_not_equals: got disallowed value "rgb(246, 246, 246)" | ||
PASS Inherited system color keyword is observable on stroke | ||
|
Oops, something went wrong.