Skip to content

Commit

Permalink
Fix debug tests after 266301@main
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=259508
rdar://112868658

Unreviewed.

The new call to broadcastFrameRemovalToOtherProcesses was causing assertions.
Restrict it to when site isolation is enabled to restore existing behavior when it is not enabled.

* Source/WebCore/html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::disconnectContentFrame):

Canonical link: https://commits.webkit.org/266305@main
  • Loading branch information
achristensen07 committed Jul 25, 2023
1 parent bb1cedb commit a3ead67
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Source/WebCore/html/HTMLFrameOwnerElement.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ void HTMLFrameOwnerElement::clearContentFrame()
void HTMLFrameOwnerElement::disconnectContentFrame()
{
if (RefPtr frame = m_contentFrame.get()) {
frame->broadcastFrameRemovalToOtherProcesses();
if (frame->settings().siteIsolationEnabled())
frame->broadcastFrameRemovalToOtherProcesses();
frame->frameDetached();
frame->disconnectOwnerElement();
}
Expand Down

0 comments on commit a3ead67

Please sign in to comment.