Skip to content

Commit

Permalink
[JSC][armv7] Unskip most of newly-added v8/regress tests
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=248905

Reviewed by Yusuke Suzuki.

Many of these tests do pass on 32-bit arm; we just need to skip a few that
require wasm shared memory or >2GB allocations; so, do that and run the rest of
the suite as normal for now.

Of the unconditionally skipped tests in this directory, I suspect only
`JSTests/wasm/v8/regress/regress-crbug-816961.js` has the potential to be
problematic for the 32-bit port.

* JSTests/wasm.yaml:
* JSTests/wasm/v8/regress/regress-1045225.js:
* JSTests/wasm/v8/regress/regress-1045737.js:
* JSTests/wasm/v8/regress/regress-1048241.js:
* JSTests/wasm/v8/regress/regress-1074586.js:
* JSTests/wasm/v8/regress/regress-1080902.js:
* JSTests/wasm/v8/regress/regress-10898.js:
* JSTests/wasm/v8/regress/regress-1140549.js:
* JSTests/wasm/v8/regress/regress-1153442.js:
* JSTests/wasm/v8/regress/regress-1179025.js:
* JSTests/wasm/v8/regress/regress-1220855.js:
* JSTests/wasm/v8/regress/regress-873600.js:
* JSTests/wasm/v8/regress/regress-9425.js:

Canonical link: https://commits.webkit.org/257516@main
  • Loading branch information
jjgriego authored and Constellation committed Dec 7, 2022
1 parent 1f69d09 commit a424a36
Show file tree
Hide file tree
Showing 13 changed files with 13 additions and 1 deletion.
2 changes: 1 addition & 1 deletion JSTests/wasm.yaml
Expand Up @@ -50,7 +50,7 @@
- path: wasm/v8/
cmd: runV8WebAssemblySuite(:no_module, "mjsunit.js") unless parseRunCommands
- path: wasm/v8/regress/
cmd: if 'arm' == $architecture; skip; else runV8WebAssemblySuite(:no_module, "mjsunit.js") unless parseRunCommands; end
cmd: runV8WebAssemblySuite(:no_module, "mjsunit.js") unless parseRunCommands
- path: wasm/branch-hints
cmd: runWebAssemblySuite unless parseRunCommands

Expand Down
1 change: 1 addition & 0 deletions JSTests/wasm/v8/regress/regress-1045225.js
@@ -1,3 +1,4 @@
//@ skip if 'arm' == $architecture
// Copyright 2020 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
Expand Down
1 change: 1 addition & 0 deletions JSTests/wasm/v8/regress/regress-1045737.js
@@ -1,3 +1,4 @@
//@ skip if 'arm' == $architecture
// Copyright 2020 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
Expand Down
1 change: 1 addition & 0 deletions JSTests/wasm/v8/regress/regress-1048241.js
@@ -1,3 +1,4 @@
//@ skip if 'arm' == $architecture
// Copyright 2020 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
Expand Down
1 change: 1 addition & 0 deletions JSTests/wasm/v8/regress/regress-1074586.js
@@ -1,3 +1,4 @@
//@ skip if 'arm' == $architecture
// Copyright 2020 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
Expand Down
1 change: 1 addition & 0 deletions JSTests/wasm/v8/regress/regress-1080902.js
@@ -1,3 +1,4 @@
//@ skip if 'arm' == $architecture
// Copyright 2020 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
Expand Down
1 change: 1 addition & 0 deletions JSTests/wasm/v8/regress/regress-10898.js
@@ -1,3 +1,4 @@
//@ skip if 'arm' == $architecture
// Copyright 2020 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
Expand Down
1 change: 1 addition & 0 deletions JSTests/wasm/v8/regress/regress-1140549.js
@@ -1,3 +1,4 @@
//@ skip if 'arm' == $architecture
// Copyright 2020 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
Expand Down
1 change: 1 addition & 0 deletions JSTests/wasm/v8/regress/regress-1153442.js
@@ -1,3 +1,4 @@
//@ skip if 'arm' == $architecture
// Copyright 2020 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
Expand Down
1 change: 1 addition & 0 deletions JSTests/wasm/v8/regress/regress-1179025.js
@@ -1,3 +1,4 @@
//@ skip if 'arm' == $architecture
// Copyright 2021 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
Expand Down
1 change: 1 addition & 0 deletions JSTests/wasm/v8/regress/regress-1220855.js
@@ -1,3 +1,4 @@
//@ skip if 'arm' == $architecture
// Copyright 2021 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
Expand Down
1 change: 1 addition & 0 deletions JSTests/wasm/v8/regress/regress-873600.js
@@ -1,3 +1,4 @@
//@ skip if $memoryLimited
// Copyright 2018 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
Expand Down
1 change: 1 addition & 0 deletions JSTests/wasm/v8/regress/regress-9425.js
@@ -1,3 +1,4 @@
//@ skip if 'arm' == $architecture
// Copyright 2019 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
Expand Down

0 comments on commit a424a36

Please sign in to comment.