IDL Callbacks with variadic params cause build failures on some platf…

…orms https://bugs.webkit.org/show_bug.cgi?id=267548 Reviewed by Chris Dumez. Includes the IDLType import in the header file to prevent template specialization errors on some platforms. * Source/WebCore/bindings/scripts/CodeGeneratorJS.pm: (GenerateCallbackHeaderContent): * Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunctionWithVariadic.cpp: * Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunctionWithVariadic.h: Canonical link: https://commits.webkit.org/273050@main
WebKit · Jan 15, 2024 · a505bd7 · a505bd7
1 parent 3074b66
commit a505bd7
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 1 deletion.
diff --git a/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm b/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
@@ -6674,6 +6674,7 @@ sub GenerateCallbackHeaderContent
                 my $IDLType = GetIDLType($interfaceOrCallback, $argument->type);
                 if ($argument->isVariadic) {
                     AddToIncludes("JSDOMConvertVariadic.h", $includesRef, 1);
+                    AddToIncludesForIDLType($argument->type, $includesRef, 1);
                     push(@arguments, "FixedVector<typename VariadicConverter<${IDLType}>::Item>&& " . $argument->name);
                 } else {
                     push(@arguments, "typename ${IDLType}::ParameterType " . $argument->name);

diff --git a/Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunctionWithVariadic.cpp b/Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunctionWithVariadic.cpp
@@ -22,7 +22,6 @@
 #include "JSTestCallbackFunctionWithVariadic.h"
 
 #include "ContextDestructionObserverInlines.h"
-#include "JSDOMConvertAny.h"
 #include "JSDOMConvertStrings.h"
 #include "JSDOMExceptionHandling.h"
 #include "ScriptExecutionContext.h"

diff --git a/Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunctionWithVariadic.h b/Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunctionWithVariadic.h
@@ -22,6 +22,7 @@
 
 #include "IDLTypes.h"
 #include "JSCallbackData.h"
+#include "JSDOMConvertAny.h"
 #include "JSDOMConvertVariadic.h"
 #include "TestCallbackFunctionWithVariadic.h"
 #include <wtf/Forward.h>