Skip to content

Commit

Permalink
Unreviewed, reverting 274680@main, 274734@main, 274817@main, 274846@m…
Browse files Browse the repository at this point in the history
…ain, 274893@main, 274913@main, 274916@main, 274957@main, 274961@main and 274964@main.

https://bugs.webkit.org/show_bug.cgi?id=269743

Caused ~0.3% Speedometer

Reverted changesets:

"[view-transitions] Integrate pseudo-elements with animation code"
https://bugs.webkit.org/show_bug.cgi?id=268064
https://commits.webkit.org/274680@main

"[view-transitions] Allow animations to run more than once"
https://bugs.webkit.org/show_bug.cgi?id=269460
https://commits.webkit.org/274734@main

"[view-transitions] Implement "update pseudo-element styles" algorithm."
https://bugs.webkit.org/show_bug.cgi?id=265224
https://commits.webkit.org/274817@main

"getComputedStyle() should work with functional pseudo-elements like ::highlight()"
https://bugs.webkit.org/show_bug.cgi?id=264103
https://commits.webkit.org/274846@main

"Move parsePseudoElement() to CSSSelectorParser"
https://bugs.webkit.org/show_bug.cgi?id=269597
https://commits.webkit.org/274893@main

"Devirtualize Event::eventInterface"
https://bugs.webkit.org/show_bug.cgi?id=269338
https://commits.webkit.org/274913@main

"Synchronize css/cssom & css/css-highlight-api WPT"
https://bugs.webkit.org/show_bug.cgi?id=269601
https://commits.webkit.org/274916@main

"[view-transitions] Implement "capture the image" algorithm."
https://bugs.webkit.org/show_bug.cgi?id=265170
https://commits.webkit.org/274957@main

"[view-transitions] Support script-originated animations"
https://bugs.webkit.org/show_bug.cgi?id=269468
https://commits.webkit.org/274961@main

"::view-transition-group dynamic styles doesn't compute the transform."
https://bugs.webkit.org/show_bug.cgi?id=269692
https://commits.webkit.org/274964@main

Canonical link: https://commits.webkit.org/274996@main
  • Loading branch information
webkit-commit-queue authored and rniwa committed Feb 19, 2024
1 parent af34d92 commit a5e570d
Show file tree
Hide file tree
Showing 286 changed files with 819 additions and 3,406 deletions.
23 changes: 2 additions & 21 deletions LayoutTests/TestExpectations
Expand Up @@ -4982,29 +4982,9 @@ webkit.org/b/220325 http/wpt/css/css-highlight-api/highlight-text-cascade.html [

# Tests need updating relating to Highlight Spec
imported/w3c/web-platform-tests/css/css-highlight-api/painting/css-target-text-decoration-001.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-container-metrics-001.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-container-metrics-002.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-container-metrics-003.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-container-metrics-004.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-container-metrics-005.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-container-metrics-006.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-dynamic-container-metrics-002.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-dynamic-container-metrics-003.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-dynamic-container-metrics-004.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-dynamic-font-metrics-001.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-dynamic-logical-metrics-001.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-font-metrics-001.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-font-metrics-002.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-font-metrics-003.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-font-metrics-004.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-font-metrics-005.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-logical-metrics-001.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-logical-metrics-002.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-below-selection-transparency.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-below-target-text.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-inheritance-001.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-inheritance-002.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-vertical-writing-mode-001.html [ ImageOnlyFailure ]

http/tests/webgl/1.0.x/conformance/textures/misc/origin-clean-conformance-offscreencanvas.html [ Skip ]
http/tests/webgl/2.0.y/conformance/textures/misc/origin-clean-conformance-offscreencanvas.html [ Skip ]
Expand Down Expand Up @@ -7018,12 +6998,13 @@ imported/w3c/web-platform-tests/css/css-view-transitions/old-content-with-overfl
imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-rendering-invalidation.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-view-transitions/snapshot-containing-block-static.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-view-transitions/span-with-overflowing-text-hidden.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-view-transitions/web-animations-api.html [ ImageOnlyFailure ]

# Timeouts
imported/w3c/web-platform-tests/css/css-view-transitions/iframe-transition.sub.html [ Skip ]
imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-get-computed-style.html [ Skip ]
imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-computed-style-stays-in-sync-with-new-element.html [ Skip ]
imported/w3c/web-platform-tests/css/css-view-transitions/web-animations-api.html [ Skip ]
imported/w3c/web-platform-tests/css/css-view-transitions/web-animation-pseudo-incorrect-name.html [ Skip ]

# Flakes
imported/w3c/web-platform-tests/css/css-view-transitions/synchronous-callback-skipped-before-run.html [ Failure Pass ]
Expand Down
17 changes: 0 additions & 17 deletions LayoutTests/imported/w3c/resources/resource-files.json
Expand Up @@ -2881,29 +2881,15 @@
"web-platform-tests/css/css-grid/table-grid-item-dynamic-003-ref.html",
"web-platform-tests/css/css-grid/table-grid-item-dynamic-004-ref.html",
"web-platform-tests/css/css-grid/test-plan/index.html",
"web-platform-tests/css/css-highlight-api/highlight-priority-painting-ref.html",
"web-platform-tests/css/css-highlight-api/painting/css-highlight-painting-underline-offset-001-ref.html",
"web-platform-tests/css/css-highlight-api/painting/css-target-text-decoration-001-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-container-metrics-001-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-container-metrics-002-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-container-metrics-003-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-container-metrics-004-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-dynamic-container-metrics-001-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-font-metrics-001-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-font-metrics-002-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-font-metrics-003-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-font-metrics-004-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-font-metrics-005-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-logical-metrics-001-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-logical-metrics-002-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-001-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-002-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-003-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-004-2-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-004-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-below-grammar-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-below-selection-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-below-selection-transparency-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-below-target-text-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-iframe-001-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-iframe-003-ref.html",
Expand All @@ -2915,12 +2901,9 @@
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-invalidation-007-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-overlapping-highlights-001-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-overlapping-highlights-002-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-prioritization-003-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-staticrange-001-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-staticrange-004-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-text-decoration-001-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-text-decoration-dynamic-001-ref.html",
"web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-vertical-writing-mode-001-ref.html",
"web-platform-tests/css/css-highlight-api/painting/invalidation/css-highlight-invalidation-001-ref.html",
"web-platform-tests/css/css-images/image-fit-001.xht",
"web-platform-tests/css/css-images/image-fit-006.xht",
Expand Down
Expand Up @@ -6,7 +6,7 @@ PASS Originating element container for ::after
PASS Originating element container for ::marker
PASS Originating element container for ::first-line
PASS Originating element container for ::first-letter
PASS Originating element container for ::highlight
FAIL Originating element container for ::highlight assert_equals: expected "20px" but got ""
PASS Originating element container for outer ::first-line
PASS Originating element container for outer ::first-letter
PASS Originating element container for ::backdrop
Expand Down
@@ -1,5 +1,5 @@

PASS Initial text-decoration-thickness for highlight pseudo
PASS text-decoration-thickness for highlight pseudo depending on container
PASS text-decoration-thickness for highlight pseudo depending on container only defined in a query
FAIL Initial text-decoration-thickness for highlight pseudo assert_equals: expected "0px" but got ""
FAIL text-decoration-thickness for highlight pseudo depending on container assert_equals: expected "30px" but got ""
FAIL text-decoration-thickness for highlight pseudo depending on container only defined in a query assert_equals: expected "30px" but got ""

Expand Up @@ -73,5 +73,6 @@
assert_equals(highlightBlue.priority, -1);
});
</script>

</body>
</html>
@@ -1,14 +1,13 @@

PASS getComputedStyle() for ::highlight(foo)
PASS Different getComputedStyle() for ::highlight(bar) and same element
PASS getComputedStyle() for ::highlight(foo): should not return a style.
PASS getComputedStyle() for ::highlight(foo)) should not return a style.
PASS getComputedStyle() for ::highlight(foo)( should not return a style.
PASS getComputedStyle() for ::highlight should not return a style.
PASS getComputedStyle() for ::highlight(foo)(foo) should not return a style.
PASS getComputedStyle() for ::highlight(foo)() should not return a style.
PASS getComputedStyle() for :::highlight(foo) should not return a style.
PASS getComputedStyle() for ::highlight(foo). should not return a style.
PASS getComputedStyle() for ::highlight(foo,bar) should not return a style.
PASS getComputedStyle() for ::highlight(foo bar) should not return a style.
FAIL getComputedStyle() for ::highlight(foo) assert_equals: Background color is green. expected "rgb(0, 128, 0)" but got ""
FAIL Different getComputedStyle() for ::highlight(bar) and same element assert_equals: Background color is cyan. expected "rgb(0, 255, 255)" but got ""
FAIL getComputedStyle() for ::highlight(foo): should be element's default assert_equals: Background color is element's default. expected "rgba(0, 0, 0, 0)" but got ""
FAIL getComputedStyle() for ::highlight(foo)) should be element's default assert_equals: Background color is element's default. expected "rgba(0, 0, 0, 0)" but got ""
FAIL getComputedStyle() for ::highlight(foo)( should be element's default assert_equals: Background color is element's default. expected "rgba(0, 0, 0, 0)" but got ""
PASS getComputedStyle() for ::highlight should be element's default
FAIL getComputedStyle() for ::highlight(foo)(foo) should be element's default assert_equals: Background color is element's default. expected "rgba(0, 0, 0, 0)" but got ""
FAIL getComputedStyle() for ::highlight(foo)() should be element's default assert_equals: Background color is element's default. expected "rgba(0, 0, 0, 0)" but got ""
FAIL getComputedStyle() for :::highlight(foo) should be element's default assert_equals: Background color is element's default. expected "rgba(0, 0, 0, 0)" but got ""
FAIL getComputedStyle() for ::highlight(foo). should be element's default assert_equals: Background color is element's default. expected "rgba(0, 0, 0, 0)" but got ""
FAIL getComputedStyle() for ::highlight(foo,bar) should be element's default assert_equals: Background color is element's default. expected "rgba(0, 0, 0, 0)" but got ""

Expand Up @@ -9,7 +9,6 @@
background-color: green;
color: lime;
}

#target::highlight(bar) {
background-color: cyan;
color: fuchsia;
Expand All @@ -31,10 +30,12 @@
assert_equals(style.color, "rgb(255, 0, 255)", "Color is fuchsia.");
}, `Different getComputedStyle() for ${highlightPseudo} and same element`);

for (const illHighlightPseudo of ["::highlight(foo):", "::highlight(foo))", "::highlight(foo)(", "::highlight", "::highlight(foo)(foo)", "::highlight(foo)()", ":::highlight(foo)", "::highlight(foo).", "::highlight(foo,bar)", "::highlight(foo bar)"]) {
for (const illHighlightPseudo of ["::highlight(foo):", "::highlight(foo))", "::highlight(foo)(", "::highlight", "::highlight(foo)(foo)", "::highlight(foo)()", ":::highlight(foo)", "::highlight(foo).", "::highlight(foo,bar)"]) {
test(() => {
let style = getComputedStyle(target, illHighlightPseudo);
assert_equals(style.length, 0, "Invalid pseudo identifiers should not return a style.");
}, `getComputedStyle() for ${illHighlightPseudo} should not return a style.`);
let defaultStyle = getComputedStyle(target);
assert_equals(style.backgroundColor, defaultStyle.backgroundColor, "Background color is element's default.");
assert_equals(style.color, defaultStyle.color, "Color is element's default.");
}, `getComputedStyle() for ${illHighlightPseudo} should be element's default`);
}
</script>
</script>

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

0 comments on commit a5e570d

Please sign in to comment.