Skip to content

Commit

Permalink
Merge 254237@main - [GTK4] UI process hang when opening HTML select e…
Browse files Browse the repository at this point in the history
…lements (combo boxes)

https://bugs.webkit.org/show_bug.cgi?id=238323

Reviewed by Michael Catanzaro.

Hide the popover before destroying it.

* Source/WebKit/UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
(WebKit::WebPopupMenuProxyGtk::hidePopupMenu):

Canonical link: https://commits.webkit.org/254237@main

(cherry picked from commit 4e07bc3)
  • Loading branch information
alice-mkh authored and aperezdc committed Sep 7, 2022
1 parent d0bb974 commit a611e96
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Source/WebKit/UIProcess/gtk/WebPopupMenuProxyGtk.cpp
Expand Up @@ -412,6 +412,7 @@ void WebPopupMenuProxyGtk::hidePopupMenu()
}

#if USE(GTK4)
gtk_popover_popdown(GTK_POPOVER(m_popup));
g_clear_pointer(&m_popup, gtk_widget_unparent);
#else
gtk_widget_destroy(m_popup);
Expand Down

0 comments on commit a611e96

Please sign in to comment.