Skip to content

Commit

Permalink
update-angle script commit message template lacks reviewer reminder
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=258972
rdar://111903092

Unreviewed, to be reviewed by Dan Glastonbury.

Add the missing oops for reviewer, bug URL and Radar URL.

* Tools/Scripts/update-angle:

Canonical link: https://commits.webkit.org/266423@main
  • Loading branch information
kkinnunen-apple committed Jul 31, 2023
1 parent ea191c9 commit a6e2340
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion Tools/Scripts/update-angle
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,11 @@ cleanup_after_successful_rebase_and_exit() {
regenerate_changes_diff "$ANGLE_TARGET_COMMIT"
echo "Generating contents of commit message into commit-message.txt."
echo "Be sure to copy out this file's contents and delete it before committing."
echo "Update ANGLE to $(git log -1 ${COMMIT_HASH} --format=%cs) (${COMMIT_HASH}))" > commit-message.txt
echo "Update ANGLE to $(git log -1 ${COMMIT_HASH} --format=%cs) (${COMMIT_HASH})" > commit-message.txt
echo "Need the bug URL (OOPS!)." >> commit-message.txt
echo "Include a Radar link (OOPS!)." >> commit-message.txt
echo "" >> commit-message.txt
echo "Reviewed by NOBODY (OOPS!)" >> commit-message.txt
echo "" >> commit-message.txt
echo "Contains upstream commits:" >> commit-message.txt
echo git log --oneline "$PREVIOUS_ANGLE_COMMIT_HASH".."$COMMIT_HASH" --pretty="%h %s" >> commit-message.txt
Expand Down

0 comments on commit a6e2340

Please sign in to comment.