Skip to content

Commit

Permalink
Merged r241753 - Fix DFG doesGC() for CompareEq/Less/LessEq/Greater/G…
Browse files Browse the repository at this point in the history
…reaterEq and CompareStrictEq nodes.

https://bugs.webkit.org/show_bug.cgi?id=194800
<rdar://problem/48183773>

Reviewed by Yusuke Suzuki.

Fix doesGC() for the following nodes:

    CompareEq:
    CompareLess:
    CompareLessEq:
    CompareGreater:
    CompareGreaterEq:
    CompareStrictEq:
        Only return false (i.e. does not GC) for child node use kinds that have
        been vetted to not do anything that can GC.  For all other use kinds
        (including StringUse and BigIntUse), we return true (i.e. does GC).

* dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
  • Loading branch information
aperezdc committed Feb 22, 2019
1 parent bd5f3e8 commit a8702c9
Showing 1 changed file with 23 additions and 0 deletions.
23 changes: 23 additions & 0 deletions Source/JavaScriptCore/ChangeLog
@@ -1,3 +1,26 @@
2019-02-18 Mark Lam <mark.lam@apple.com>

Fix DFG doesGC() for CompareEq/Less/LessEq/Greater/GreaterEq and CompareStrictEq nodes.
https://bugs.webkit.org/show_bug.cgi?id=194800
<rdar://problem/48183773>

Reviewed by Yusuke Suzuki.

Fix doesGC() for the following nodes:

CompareEq:
CompareLess:
CompareLessEq:
CompareGreater:
CompareGreaterEq:
CompareStrictEq:
Only return false (i.e. does not GC) for child node use kinds that have
been vetted to not do anything that can GC. For all other use kinds
(including StringUse and BigIntUse), we return true (i.e. does GC).

* dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):

2019-02-19 Robin Morisset <rmorisset@apple.com>

B3-O2 incorrectly optimizes this subtest
Expand Down

0 comments on commit a8702c9

Please sign in to comment.