Merge r249276 - [GStreamer] Do not use makeWeakPtr from streaming thr…

…ead.

https://bugs.webkit.org/show_bug.cgi?id=201220

Reviewed by Xabier Rodriguez-Calvar.

Test: imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-retrieve-persistent-license.https.html

Recently some asserts were added that you can't create WeakPtr's
from streaming threads when the factory is created on the
main-thread. The fix is to eagerly create the WeakPtr at player
initialization time, rather than lazily when the streaming thread
first asks for it.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

Source/WebCore/ChangeLog

@@ -1,3 +1,20 @@
+2019-08-29  Charlie Turner  <cturner@igalia.com>
+
+        [GStreamer] Do not use makeWeakPtr from streaming thread.
+        https://bugs.webkit.org/show_bug.cgi?id=201220
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        Test: imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-retrieve-persistent-license.https.html
+
+        Recently some asserts were added that you can't create WeakPtr's
+        from streaming threads when the factory is created on the
+        main-thread. The fix is to eagerly create the WeakPtr at player
+        initialization time, rather than lazily when the streaming thread
+        first asks for it.
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
+
 2019-08-30  Adrian Perez de Castro  <aperez@igalia.com>
 
         Unreviewed build fix for ENABLE_UNIFIED_BUILDS=OFF.

Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h

@@ -88,7 +88,8 @@ class TextureMapperPlatformLayerProxy;
 
 void registerWebKitGStreamerElements();
 
-class MediaPlayerPrivateGStreamerBase : public MediaPlayerPrivateInterface, public CanMakeWeakPtr<MediaPlayerPrivateGStreamerBase>
+// Use eager initialization for the WeakPtrFactory since we call makeWeakPtr() from another thread.
+class MediaPlayerPrivateGStreamerBase : public MediaPlayerPrivateInterface, public CanMakeWeakPtr<MediaPlayerPrivateGStreamerBase, WeakPtrFactoryInitialization::Eager>
 #if USE(TEXTURE_MAPPER_GL)
 #if USE(NICOSIA)
     , public Nicosia::ContentLayerTextureMapperImpl::Client