Stop using CheckedPtr with CSSStyleSheet

https://bugs.webkit.org/show_bug.cgi?id=266479 Reviewed by Ryosuke Niwa. Stop using CheckedPtr with CSSStyleSheet. Use WeakPtr instead to generate more actionable crashes. This tested as performance neutral on Speedometer 2 & 3. * Source/WebCore/css/CSSStyleSheet.h: * Source/WebCore/style/StyleScope.h: Canonical link: https://commits.webkit.org/272124@main
WebKit · Dec 15, 2023 · abebb37 · abebb37
1 parent d6daeab
commit abebb37
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Source/WebCore/css/CSSStyleSheet.h b/Source/WebCore/css/CSSStyleSheet.h
@@ -58,7 +58,7 @@ namespace Style {
 class Scope;
 }
 
-class CSSStyleSheet final : public StyleSheet, public CanMakeCheckedPtr {
+class CSSStyleSheet final : public StyleSheet, public CanMakeSingleThreadWeakPtr<CSSStyleSheet> {
 public:
     struct Init {
         String baseURL;

diff --git a/Source/WebCore/style/StyleScope.h b/Source/WebCore/style/StyleScope.h
@@ -213,7 +213,7 @@ class Scope : public CanMakeWeakPtr<Scope>, public CanMakeCheckedPtr {
 
     Timer m_pendingUpdateTimer;
 
-    mutable HashSet<CheckedRef<const CSSStyleSheet>> m_weakCopyOfActiveStyleSheetListForFastLookup;
+    mutable HashSet<SingleThreadWeakRef<const CSSStyleSheet>> m_weakCopyOfActiveStyleSheetListForFastLookup;
 
     // Track the currently loading top-level stylesheets needed for rendering.
     // Sheets loaded using the @import directive are not included in this count.