Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge r245300 - Do not try to issue repaint while the render tree is …
…being destroyed. https://bugs.webkit.org/show_bug.cgi?id=197461 <rdar://problem/50368992> Reviewed by Simon Fraser. Source/WebCore: Test: http/tests/svg/crash-on-reload-with-filter.html We don't need to compute repaint rects when the render tree is getting torn down. We'll issue a full repaint at some point. Also during full render tree destruction the inline tree state is undefined. We should avoid accessing it. * rendering/svg/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::markAllClientLayersForInvalidation): LayoutTests: * http/tests/svg/crash-on-reload-with-filter-expected.txt: Added. * http/tests/svg/crash-on-reload-with-filter.html: Added. * http/tests/svg/resources/finishTest.html: Added.
- Loading branch information
1 parent
fe1ef53
commit ac52a25
Showing
6 changed files
with
50 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
LayoutTests/http/tests/svg/crash-on-reload-with-filter-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Pass if no crash or assert. |
11 changes: 11 additions & 0 deletions
11
LayoutTests/http/tests/svg/crash-on-reload-with-filter.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
<div style="display: inline-block;"></div> | ||
<svg><filter id="svgfilter"><feOffset/></filter></svg> | ||
<span style="-webkit-text-emphasis: '-';"></span> | ||
<video style="filter: url(#svgfilter);"></video> | ||
<script> | ||
document.body.offsetHeight; | ||
location = "resources/finishTest.html"; | ||
|
||
if (window.testRunner) | ||
testRunner.waitUntilDone(); | ||
</script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
Pass if no crash or assert.<script> | ||
if (window.testRunner) { | ||
testRunner.dumpAsText(); | ||
testRunner.notifyDone(); | ||
} | ||
</script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters