Skip to content

Commit

Permalink
Remove StringBuilder calls in CacheStorageDiskStore
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=273657
rdar://127461376

Reviewed by Sihui Liu.

There are some dead stores to StringBuilder in CacheStorageDiskStore that should be removed.

* Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.cpp:
(WebKit::encodeRecord):

Canonical link: https://commits.webkit.org/278293@main
  • Loading branch information
bnham committed May 3, 2024
1 parent df37193 commit afc7f08
Showing 1 changed file with 0 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -500,12 +500,6 @@ static Vector<uint8_t> encodeRecord(const NetworkCache::Key& key, const Vector<u
result.append(metaData);
result.appendVector(headerData);

StringBuilder sb;
for (auto& data : bodyData) {
sb.append(data);
sb.append(",");
}

if (isBodyInline)
result.appendVector(bodyData);

Expand Down

0 comments on commit afc7f08

Please sign in to comment.