Skip to content

Commit

Permalink
REGRESSION (256812@main): [macOS] ASSERTION FAILED: m_element in WebK…
Browse files Browse the repository at this point in the history
…it::WebFullScreenManager::setAnimatingFullScreen()

https://bugs.webkit.org/show_bug.cgi?id=248093
rdar://102522154

Unreviewed test gardening.

Disable the tests in the debug configuration.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenVideoTextRecognition.mm:
* Tools/TestWebKitAPI/Tests/mac/FullscreenFocus.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/258258@main
  • Loading branch information
ryanhaddad committed Dec 22, 2022
1 parent ac4c2a7 commit b395978
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 2 deletions.
Expand Up @@ -66,7 +66,12 @@ - (void)_webViewDidExitFullscreen:(WKWebView *)webView

namespace TestWebKitAPI {

// FIXME: Re-enable this test once webkit.org/b/248093 is resolved.
#if !defined(NDEBUG)
TEST(ExitFullscreenOnEnterPiP, DISABLED_VideoFullscreen)
#else
TEST(ExitFullscreenOnEnterPiP, VideoFullscreen)
#endif
{
RetainPtr<WKWebViewConfiguration> configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
[configuration preferences]._fullScreenEnabled = YES;
Expand Down Expand Up @@ -96,7 +101,8 @@ - (void)_webViewDidExitFullscreen:(WKWebView *)webView
}

// FIXME: Re-enable this test for Big Sur once webkit.org/b/245241 is resolved
#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 120000)
// FIXME: Re-enable this test once webkit.org/b/248093 is resolved.
#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 120000) || !defined(NDEBUG)
TEST(ExitFullscreenOnEnterPiP, DISABLED_ElementFullscreen)
#else
TEST(ExitFullscreenOnEnterPiP, ElementFullscreen)
Expand Down
Expand Up @@ -269,7 +269,8 @@ - (void)waitForImageAnalysisToEnd
}

// FIXME: Re-enable this test for iOS once webkit.org/b/248094 is resolved
#if PLATFORM(IOS)
// FIXME: Re-enable this test once webkit.org/b/248093 is resolved.
#if PLATFORM(IOS) || !defined(NDEBUG)
TEST(FullscreenVideoTextRecognition, DISABLED_DoNotAnalyzeVideoAfterExitingFullscreen)
#else
TEST(FullscreenVideoTextRecognition, DoNotAnalyzeVideoAfterExitingFullscreen)
Expand Down
5 changes: 5 additions & 0 deletions Tools/TestWebKitAPI/Tests/mac/FullscreenFocus.mm
Expand Up @@ -55,7 +55,12 @@ - (void)_webViewDidExitFullscreen:(WKWebView *)webView

namespace TestWebKitAPI {

// FIXME: Re-enable this test once webkit.org/b/248093 is resolved.
#if !defined(NDEBUG)
TEST(Fullscreen, DISABLED_Focus)
#else
TEST(Fullscreen, Focus)
#endif
{
auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
[configuration preferences]._fullScreenEnabled = YES;
Expand Down

0 comments on commit b395978

Please sign in to comment.