Skip to content
Permalink
Browse files
REGRESSION(r222181): Web Inspector: Augmenting Agents Domains are not…
… getting activated

https://bugs.webkit.org/show_bug.cgi?id=178768
<rdar://problem/35081334>

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-10-24
Reviewed by Brian Burg.

* UserInterface/Base/Main.js:
Simplify event dispatch.

* UserInterface/Controllers/AppController.js:
(WI.AppController.prototype.activateExtraDomains):
Pass the domains on.

Canonical link: https://commits.webkit.org/194944@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@223948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
JosephPecoraro authored and webkit-commit-queue committed Oct 25, 2017
1 parent 8a4c441 commit b4e64a5c4776528de052c3e5e72c4ee55be4aa43
Showing with 17 additions and 2 deletions.
  1. +15 −0 Source/WebInspectorUI/ChangeLog
  2. +1 −1 Source/WebInspectorUI/UserInterface/Base/Main.js
  3. +1 −1 Source/WebInspectorUI/UserInterface/Controllers/AppController.js
@@ -1,3 +1,18 @@
2017-10-24 Joseph Pecoraro <pecoraro@apple.com>

REGRESSION(r222181): Web Inspector: Augmenting Agents Domains are not getting activated
https://bugs.webkit.org/show_bug.cgi?id=178768
<rdar://problem/35081334>

Reviewed by Brian Burg.

* UserInterface/Base/Main.js:
Simplify event dispatch.

* UserInterface/Controllers/AppController.js:
(WI.AppController.prototype.activateExtraDomains):
Pass the domains on.

2017-10-24 Joseph Pecoraro <pecoraro@apple.com>

Web Inspector: Console Drawer resizing doesn't match cursor position
@@ -695,7 +695,7 @@ WI.registerTabClass = function(tabClass)

WI.activateExtraDomains = function(domains)
{
this.notifications.dispatchEventToListeners(WI.Notification.ExtraDomainsActivated, {"domains": domains});
this.notifications.dispatchEventToListeners(WI.Notification.ExtraDomainsActivated, {domains});

WI.CSSCompletions.requestCSSCompletions();

@@ -54,6 +54,6 @@ WI.AppController = class AppController extends WI.AppControllerBase
}

// FIXME: all code within WI.activateExtraDomains should be distributed elsewhere.
WI.activateExtraDomains();
WI.activateExtraDomains(domains);
}
};

0 comments on commit b4e64a5

Please sign in to comment.