Skip to content

Commit

Permalink
REGRESSION(256766@main): MSVC can't compile WTFBreakpointTrapUnderCon…
Browse files Browse the repository at this point in the history
…stexprContext

https://bugs.webkit.org/show_bug.cgi?id=248026

Reviewed by Yusuke Suzuki.

It reports an error:

> JavaScriptCore\runtime\TypedArrayType.h(144): error C3615: constexpr function 'JSC::logElementSize' cannot result in a constant expression
> JavaScriptCore\runtime\TypedArrayType.h(166): note: failure was caused by a statement or an expression that is not valid in a constexpr context

* Source/WTF/wtf/Assertions.h:
(WTFBreakpointTrapUnderConstexprContext) Do nothing for MSVC.

Canonical link: https://commits.webkit.org/256776@main
  • Loading branch information
fujii authored and Constellation committed Nov 17, 2022
1 parent 597ffc8 commit b50dbcc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Source/WTF/wtf/Assertions.h
Expand Up @@ -257,7 +257,7 @@ WTF_EXPORT_PRIVATE bool WTFIsDebuggerAttached(void);
#endif

#if COMPILER(MSVC)
#define WTFBreakpointTrapUnderConstexprContext() __debugbreak()
#define WTFBreakpointTrapUnderConstexprContext() ((void) 0)
#else
#define WTFBreakpointTrapUnderConstexprContext() __builtin_trap()
#endif
Expand Down

0 comments on commit b50dbcc

Please sign in to comment.