-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Sync 'VideoPlaybackQuality.idl' with web specification and add partia…
…l interface to 'HTMLVideoElement.idl' https://bugs.webkit.org/show_bug.cgi?id=125474 rdar://problem/99826631 Reviewed by Eric Carlson. This patch aligns WebKit with Web Specification [1] & [2]. [1] https://w3c.github.io/media-playback-quality/#videoplaybackquality-interface [2] https://w3c.github.io/media-playback-quality/#extension-to-the-htmlvideoelement-interface In this PR, we removed 'FIXME' about 'LegacyNoInterfaceObject' as well as implementation and also added missing 'Exposed=Window'. Additionally, we updated 'HTMLVideoElement.idl' to have partial interface for 'getVideoPlaybackQuality'. Additionally, we synced WPT tests from upstream: Upstream Hash: 9f24a7061dc47c00ffe3f0f6dda5822a9b15c2a5 * Source/WebCore/Modules/mediasource/VideoPlaybackQuality.idl: * Source/WebCore/html/HTMLVideoElement.idl: * LayoutTests/imported/w3c/resources/import-expectations.json: * LayoutTests/imported/w3c/web-platform-tests/media-playback-quality/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/media-playback-quality/META.yml: * LayoutTests/imported/w3c/web-platform-tests/media-playback-quality/idlharness.window.js: * LayoutTests/imported/w3c/web-platform-tests/media-playback-quality/idlharness.window.html: * LayoutTests/imported/w3c/web-platform-tests/media-playback-quality/idlharness.window-expected.txt: Canonical link: https://commits.webkit.org/269893@main
- Loading branch information
1 parent
6c8a22c
commit b5ffcfb
Showing
8 changed files
with
89 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
LayoutTests/imported/w3c/web-platform-tests/media-playback-quality/META.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
spec: https://w3c.github.io/media-playback-quality/ | ||
suggested_reviewers: | ||
- mounirlamouri |
32 changes: 32 additions & 0 deletions
32
...sts/imported/w3c/web-platform-tests/media-playback-quality/idlharness.window-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
|
||
PASS idl_test setup | ||
PASS idl_test validation | ||
PASS Partial interface HTMLVideoElement: original interface defined | ||
PASS Partial interface HTMLVideoElement: member names are unique | ||
PASS HTMLElement includes GlobalEventHandlers: member names are unique | ||
PASS HTMLElement includes DocumentAndElementEventHandlers: member names are unique | ||
PASS HTMLElement includes ElementContentEditable: member names are unique | ||
PASS HTMLElement includes HTMLOrSVGElement: member names are unique | ||
PASS Element includes ParentNode: member names are unique | ||
PASS Element includes NonDocumentTypeChildNode: member names are unique | ||
PASS Element includes ChildNode: member names are unique | ||
PASS Element includes Slottable: member names are unique | ||
PASS VideoPlaybackQuality interface: existence and properties of interface object | ||
PASS VideoPlaybackQuality interface object length | ||
PASS VideoPlaybackQuality interface object name | ||
PASS VideoPlaybackQuality interface: existence and properties of interface prototype object | ||
PASS VideoPlaybackQuality interface: existence and properties of interface prototype object's "constructor" property | ||
PASS VideoPlaybackQuality interface: existence and properties of interface prototype object's @@unscopables property | ||
PASS VideoPlaybackQuality interface: attribute creationTime | ||
PASS VideoPlaybackQuality interface: attribute droppedVideoFrames | ||
PASS VideoPlaybackQuality interface: attribute totalVideoFrames | ||
PASS VideoPlaybackQuality interface: attribute corruptedVideoFrames | ||
PASS VideoPlaybackQuality must be primary interface of videoPlaybackQuality | ||
PASS Stringification of videoPlaybackQuality | ||
PASS VideoPlaybackQuality interface: videoPlaybackQuality must inherit property "creationTime" with the proper type | ||
PASS VideoPlaybackQuality interface: videoPlaybackQuality must inherit property "droppedVideoFrames" with the proper type | ||
PASS VideoPlaybackQuality interface: videoPlaybackQuality must inherit property "totalVideoFrames" with the proper type | ||
PASS VideoPlaybackQuality interface: videoPlaybackQuality must inherit property "corruptedVideoFrames" with the proper type | ||
PASS HTMLVideoElement interface: operation getVideoPlaybackQuality() | ||
PASS HTMLVideoElement interface: video must inherit property "getVideoPlaybackQuality()" with the proper type | ||
|
1 change: 1 addition & 0 deletions
1
LayoutTests/imported/w3c/web-platform-tests/media-playback-quality/idlharness.window.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
<!-- This file is required for WebKit test infrastructure to run the templated test --> |
20 changes: 20 additions & 0 deletions
20
LayoutTests/imported/w3c/web-platform-tests/media-playback-quality/idlharness.window.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
// META: script=/resources/WebIDLParser.js | ||
// META: script=/resources/idlharness.js | ||
|
||
// https://w3c.github.io/media-playback-quality/ | ||
|
||
'use strict'; | ||
|
||
idl_test( | ||
['media-playback-quality'], | ||
['html', 'dom'], | ||
idl_array => { | ||
idl_array.add_objects({ | ||
HTMLVideoElement: ['video'], | ||
VideoPlaybackQuality: ['videoPlaybackQuality'] | ||
}); | ||
|
||
self.video = document.createElement('video'); | ||
self.videoPlaybackQuality = video.getVideoPlaybackQuality(); | ||
} | ||
); |
18 changes: 18 additions & 0 deletions
18
LayoutTests/imported/w3c/web-platform-tests/media-playback-quality/w3c-import.log
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
The tests in this directory were imported from the W3C repository. | ||
Do NOT modify these tests directly in WebKit. | ||
Instead, create a pull request on the WPT github: | ||
https://github.com/web-platform-tests/wpt | ||
|
||
Then run the Tools/Scripts/import-w3c-tests in WebKit to reimport | ||
|
||
Do NOT modify or remove this file. | ||
|
||
------------------------------------------------------------------------ | ||
Properties requiring vendor prefixes: | ||
None | ||
Property values requiring vendor prefixes: | ||
None | ||
------------------------------------------------------------------------ | ||
List of files: | ||
/LayoutTests/imported/w3c/web-platform-tests/media-playback-quality/META.yml | ||
/LayoutTests/imported/w3c/web-platform-tests/media-playback-quality/idlharness.window.js |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters