-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Crash in GridBaselineAlignment::baselineGroupForChild
https://bugs.webkit.org/show_bug.cgi?id=257509 rdar://110027455 Reviewed by Alan Baradlay. Certain baseline properties are not properly handled in CSS Masonry. We will just disable these calculations for now and then remove this in the future. * LayoutTests/fast/css-grid-layout/baseline-masonry-crash-expected.html: Added. * LayoutTests/fast/css-grid-layout/baseline-masonry-crash.html: Added. * Source/WebCore/rendering/RenderGrid.cpp: (WebCore::RenderGrid::columnAxisBaselineOffsetForChild const): (WebCore::RenderGrid::rowAxisBaselineOffsetForChild const): Canonical link: https://commits.webkit.org/259548.835@safari-7615-branch
- Loading branch information
Showing
3 changed files
with
40 additions
and
0 deletions.
There are no files selected for viewing
15 changes: 15 additions & 0 deletions
15
LayoutTests/fast/css-grid-layout/baseline-masonry-crash-expected.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
<style> | ||
grid { | ||
display: inline-grid; | ||
grid-template-columns: auto; | ||
grid-template-rows: repeat(4,auto); | ||
} | ||
</style> | ||
|
||
<p>This test passes if it does not crash.</p> | ||
|
||
<grid> | ||
<<item>3</item>/item> | ||
<item>4</item> | ||
<item style="-webkit-align-self: baseline;"> | ||
</grid> |
15 changes: 15 additions & 0 deletions
15
LayoutTests/fast/css-grid-layout/baseline-masonry-crash.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
<style> | ||
grid { | ||
display: inline-grid; | ||
grid-template-columns: masonry; | ||
grid-template-rows: repeat(4,auto); | ||
} | ||
</style> | ||
|
||
<p>This test passes if it does not crash.</p> | ||
|
||
<grid> | ||
<<item>3</item>/item> | ||
<item>4</item> | ||
<item style="-webkit-align-self: baseline;"> | ||
</grid> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters