Skip to content

Commit

Permalink
Merge r228483 - WebCore headers should not include config.h or Platfo…
Browse files Browse the repository at this point in the history
…rmExportMacros.h

https://bugs.webkit.org/show_bug.cgi?id=182799

Reviewed by Darin Adler.

No new tests. No change in behavior.

* Modules/speech/SpeechSynthesis.h:
* bindings/js/JSDOMGlobalObject.h:
* contentextensions/ContentExtensionError.h:
* contentextensions/DFA.h:
* dom/ContextDestructionObserver.h:
* dom/DeviceOrientationClient.h:
* dom/DeviceOrientationData.h:
* editing/cocoa/HTMLConverter.h:
* loader/FrameLoaderStateMachine.h:
* loader/cache/CachedResourceHandle.h:
* page/FrameDestructionObserver.h:
* page/RuntimeEnabledFeatures.h:
* platform/URL.h:
* platform/audio/AudioHardwareListener.h:
* platform/audio/AudioSession.h:
* platform/graphics/Color.h:
* platform/graphics/IntSize.h:
* platform/graphics/transforms/AffineTransform.h:
* platform/graphics/win/LocalWindowsContext.h:
* platform/network/CacheValidation.h:
* platform/network/CredentialBase.h:
* platform/network/ResourceHandleClient.h:
* platform/network/cf/CertificateInfo.h:
  • Loading branch information
donny-dont authored and carlosgcampos committed Feb 20, 2018
1 parent f632575 commit b7874a6
Show file tree
Hide file tree
Showing 24 changed files with 33 additions and 27 deletions.
33 changes: 33 additions & 0 deletions Source/WebCore/ChangeLog
@@ -1,3 +1,36 @@
2018-02-14 Don Olmstead <don.olmstead@sony.com>

WebCore headers should not include config.h or PlatformExportMacros.h
https://bugs.webkit.org/show_bug.cgi?id=182799

Reviewed by Darin Adler.

No new tests. No change in behavior.

* Modules/speech/SpeechSynthesis.h:
* bindings/js/JSDOMGlobalObject.h:
* contentextensions/ContentExtensionError.h:
* contentextensions/DFA.h:
* dom/ContextDestructionObserver.h:
* dom/DeviceOrientationClient.h:
* dom/DeviceOrientationData.h:
* editing/cocoa/HTMLConverter.h:
* loader/FrameLoaderStateMachine.h:
* loader/cache/CachedResourceHandle.h:
* page/FrameDestructionObserver.h:
* page/RuntimeEnabledFeatures.h:
* platform/URL.h:
* platform/audio/AudioHardwareListener.h:
* platform/audio/AudioSession.h:
* platform/graphics/Color.h:
* platform/graphics/IntSize.h:
* platform/graphics/transforms/AffineTransform.h:
* platform/graphics/win/LocalWindowsContext.h:
* platform/network/CacheValidation.h:
* platform/network/CredentialBase.h:
* platform/network/ResourceHandleClient.h:
* platform/network/cf/CertificateInfo.h:

2018-02-14 Dean Jackson <dino@apple.com>

CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot + 618
Expand Down
1 change: 0 additions & 1 deletion Source/WebCore/Modules/speech/SpeechSynthesis.h
Expand Up @@ -27,7 +27,6 @@

#if ENABLE(SPEECH_SYNTHESIS)

#include "PlatformExportMacros.h"
#include "PlatformSpeechSynthesisUtterance.h"
#include "PlatformSpeechSynthesizer.h"
#include "SpeechSynthesisUtterance.h"
Expand Down
1 change: 0 additions & 1 deletion Source/WebCore/bindings/js/JSDOMGlobalObject.h
Expand Up @@ -26,7 +26,6 @@

#pragma once

#include "PlatformExportMacros.h"
#include "WebCoreJSBuiltinInternals.h"
#include <JavaScriptCore/HeapInlines.h>
#include <JavaScriptCore/JSGlobalObject.h>
Expand Down
1 change: 0 additions & 1 deletion Source/WebCore/contentextensions/ContentExtensionError.h
Expand Up @@ -27,7 +27,6 @@

#if ENABLE(CONTENT_EXTENSIONS)

#include "PlatformExportMacros.h"
#include <system_error>

namespace WebCore {
Expand Down
1 change: 0 additions & 1 deletion Source/WebCore/contentextensions/DFA.h
Expand Up @@ -29,7 +29,6 @@

#include "ContentExtensionsDebugging.h"
#include "DFANode.h"
#include "PlatformExportMacros.h"
#include <wtf/Vector.h>

namespace WebCore {
Expand Down
2 changes: 0 additions & 2 deletions Source/WebCore/dom/ContextDestructionObserver.h
Expand Up @@ -26,8 +26,6 @@

#pragma once

#include "PlatformExportMacros.h"

namespace WebCore {

class ScriptExecutionContext;
Expand Down
1 change: 0 additions & 1 deletion Source/WebCore/dom/DeviceOrientationClient.h
Expand Up @@ -27,7 +27,6 @@
#pragma once

#include "DeviceClient.h"
#include "PlatformExportMacros.h"
#include <wtf/Noncopyable.h>

namespace WebCore {
Expand Down
1 change: 0 additions & 1 deletion Source/WebCore/dom/DeviceOrientationData.h
Expand Up @@ -25,7 +25,6 @@

#pragma once

#include "PlatformExportMacros.h"
#include <wtf/Optional.h>
#include <wtf/Ref.h>
#include <wtf/RefCounted.h>
Expand Down
2 changes: 0 additions & 2 deletions Source/WebCore/editing/cocoa/HTMLConverter.h
Expand Up @@ -25,8 +25,6 @@

#pragma once

#include "PlatformExportMacros.h"

OBJC_CLASS NSAttributedString;

namespace WebCore {
Expand Down
1 change: 0 additions & 1 deletion Source/WebCore/loader/FrameLoaderStateMachine.h
Expand Up @@ -28,7 +28,6 @@

#pragma once

#include "PlatformExportMacros.h"
#include <wtf/Noncopyable.h>

namespace WebCore {
Expand Down
1 change: 0 additions & 1 deletion Source/WebCore/loader/cache/CachedResourceHandle.h
Expand Up @@ -25,7 +25,6 @@

#pragma once

#include "PlatformExportMacros.h"
#include <wtf/Forward.h>

namespace WebCore {
Expand Down
2 changes: 0 additions & 2 deletions Source/WebCore/page/FrameDestructionObserver.h
Expand Up @@ -25,8 +25,6 @@

#pragma once

#include "PlatformExportMacros.h"

namespace WebCore {

class Frame;
Expand Down
1 change: 0 additions & 1 deletion Source/WebCore/page/RuntimeEnabledFeatures.h
Expand Up @@ -31,7 +31,6 @@

#pragma once

#include "PlatformExportMacros.h"
#include <wtf/Forward.h>
#include <wtf/Noncopyable.h>

Expand Down
1 change: 0 additions & 1 deletion Source/WebCore/platform/URL.h
Expand Up @@ -25,7 +25,6 @@

#pragma once

#include "PlatformExportMacros.h"
#include <wtf/Forward.h>
#include <wtf/RetainPtr.h>
#include <wtf/text/WTFString.h>
Expand Down
1 change: 0 additions & 1 deletion Source/WebCore/platform/audio/AudioHardwareListener.h
Expand Up @@ -26,7 +26,6 @@
#ifndef AudioHardwareListener_h
#define AudioHardwareListener_h

#include "PlatformExportMacros.h"
#include <wtf/Ref.h>
#include <wtf/RefCounted.h>

Expand Down
2 changes: 0 additions & 2 deletions Source/WebCore/platform/audio/AudioSession.h
Expand Up @@ -26,8 +26,6 @@
#ifndef AudioSession_h
#define AudioSession_h

#include "PlatformExportMacros.h"

#if USE(AUDIO_SESSION)

#include <memory>
Expand Down
1 change: 0 additions & 1 deletion Source/WebCore/platform/graphics/Color.h
Expand Up @@ -27,7 +27,6 @@

#include "ColorSpace.h"
#include "ExtendedColor.h"
#include "PlatformExportMacros.h"
#include <algorithm>
#include <cmath>
#include <unicode/uchar.h>
Expand Down
1 change: 0 additions & 1 deletion Source/WebCore/platform/graphics/IntSize.h
Expand Up @@ -25,7 +25,6 @@

#pragma once

#include "PlatformExportMacros.h"
#include <algorithm>

#if PLATFORM(MAC) && defined __OBJC__
Expand Down
Expand Up @@ -27,7 +27,6 @@
#ifndef AffineTransform_h
#define AffineTransform_h

#include "PlatformExportMacros.h"
#include <array>
#include <wtf/FastMalloc.h>
#include <wtf/Optional.h>
Expand Down
1 change: 0 additions & 1 deletion Source/WebCore/platform/graphics/win/LocalWindowsContext.h
Expand Up @@ -26,7 +26,6 @@
#ifndef LocalWindowsContext_h
#define LocalWindowsContext_h

#include "config.h"
#include "GraphicsContext.h"

namespace WebCore {
Expand Down
1 change: 0 additions & 1 deletion Source/WebCore/platform/network/CacheValidation.h
Expand Up @@ -25,7 +25,6 @@

#pragma once

#include "PlatformExportMacros.h"
#include <pal/SessionID.h>
#include <wtf/Optional.h>
#include <wtf/Vector.h>
Expand Down
1 change: 0 additions & 1 deletion Source/WebCore/platform/network/CredentialBase.h
Expand Up @@ -26,7 +26,6 @@
#ifndef CredentialBase_h
#define CredentialBase_h

#include "PlatformExportMacros.h"
#include <wtf/text/WTFString.h>

namespace WebCore {
Expand Down
1 change: 0 additions & 1 deletion Source/WebCore/platform/network/ResourceHandleClient.h
Expand Up @@ -25,7 +25,6 @@

#pragma once

#include "PlatformExportMacros.h"
#include <wtf/Forward.h>
#include <wtf/Ref.h>

Expand Down
1 change: 0 additions & 1 deletion Source/WebCore/platform/network/cf/CertificateInfo.h
Expand Up @@ -26,7 +26,6 @@
#ifndef CertificateInfo_h
#define CertificateInfo_h

#include "PlatformExportMacros.h"
#include <wtf/RetainPtr.h>

#if PLATFORM(COCOA)
Expand Down

0 comments on commit b7874a6

Please sign in to comment.