Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~Ob…
…jCEventListener https://bugs.webkit.org/show_bug.cgi?id=197079 Reviewed by Darin Adler. Source/WebKitLegacy/mac: The crash was caused by the fact deleting a node could end up deleting Objective-C event listeners some of which may be the last object holding onto WebView itself in the middle of running GC. It's not generally safe to delete Objective-C objects defiend by client applications since dealloc could execute arbitrary code, and for instance, try to execute JavaScript or load new page. Fixed the bug by delaying the dealloc'ing of Objective event listeners via autorelease pool. * DOM/ObjCEventListener.mm: (WebCore::ObjCEventListener::~ObjCEventListener): Tools: Added a regression test. It hits a slightly different backtrace but of the same class of issues. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added. Canonical link: https://commits.webkit.org/211336@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244459 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing
5 changed files
with
130 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93 changes: 93 additions & 0 deletions
93
Tools/TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| /* | ||
| * Copyright (C) 2018 Apple Inc. All rights reserved. | ||
| * | ||
| * Redistribution and use in source and binary forms, with or without | ||
| * modification, are permitted provided that the following conditions | ||
| * are met: | ||
| * 1. Redistributions of source code must retain the above copyright | ||
| * notice, this list of conditions and the following disclaimer. | ||
| * 2. Redistributions in binary form must reproduce the above copyright | ||
| * notice, this list of conditions and the following disclaimer in the | ||
| * documentation and/or other materials provided with the distribution. | ||
| * | ||
| * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' | ||
| * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, | ||
| * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR | ||
| * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS | ||
| * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR | ||
| * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF | ||
| * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS | ||
| * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN | ||
| * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) | ||
| * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF | ||
| * THE POSSIBILITY OF SUCH DAMAGE. | ||
| */ | ||
|
|
||
| #import "config.h" | ||
| #import "PlatformUtilities.h" | ||
| #import "WTFStringUtilities.h" | ||
|
|
||
| #import <Carbon/Carbon.h> | ||
| #import <WebKit/WebViewPrivate.h> | ||
| #import <wtf/RetainPtr.h> | ||
|
|
||
| extern "C" void JSSynchronousGarbageCollectForDebugging(JSContextRef); | ||
|
|
||
| #if JSC_OBJC_API_ENABLED | ||
|
|
||
| static bool didFinishLoad = false; | ||
| static bool didClose = false; | ||
| static RetainPtr<WebView> webView; | ||
|
|
||
| @interface DeallocWebViewInEventListenerLoadDelegate : NSObject <WebFrameLoadDelegate> | ||
| @end | ||
|
|
||
| @implementation DeallocWebViewInEventListenerLoadDelegate | ||
| - (void)webView:(WebView *)sender didFinishLoadForFrame:(WebFrame *)frame | ||
| { | ||
| didFinishLoad = true; | ||
| } | ||
| @end | ||
|
|
||
| @interface DeallocWebViewInEventListener : NSObject <DOMEventListener> | ||
| @end | ||
|
|
||
| @implementation DeallocWebViewInEventListener | ||
| - (void)handleEvent:(DOMEvent *)event | ||
| { | ||
|
|
||
| } | ||
|
|
||
| - (void)dealloc | ||
| { | ||
| webView = nullptr; | ||
| [super dealloc]; | ||
| didClose = true; | ||
| } | ||
| @end | ||
|
|
||
| namespace TestWebKitAPI { | ||
|
|
||
| TEST(WebKitLegacy, DeallocWebViewInEventListener) | ||
| { | ||
| { | ||
| NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init]; | ||
| webView = adoptNS([[WebView alloc] initWithFrame:NSMakeRect(0, 0, 400, 400) frameName:nil groupName:nil]); | ||
| auto loadDelegate = adoptNS([[DeallocWebViewInEventListenerLoadDelegate alloc] init]); | ||
| webView.get().frameLoadDelegate = loadDelegate.get(); | ||
|
|
||
| [[webView mainFrame] loadHTMLString:@"<html><body></body></html>" baseURL:nil]; | ||
| Util::run(&didFinishLoad); | ||
|
|
||
| auto listener = adoptNS([[DeallocWebViewInEventListener alloc] init]); | ||
| [[[webView mainFrameDocument] body] addEventListener:@"keypress" listener:listener.get() useCapture:NO]; | ||
| listener = nullptr; | ||
| [webView close]; | ||
| [pool drain]; | ||
| } | ||
| Util::run(&didClose); | ||
| } | ||
|
|
||
| } // namespace TestWebKitAPI | ||
|
|
||
| #endif // ENABLE(JSC_OBJC_API) |