Skip to content

Commit

Permalink
Remove Quirk shouldDispatchSimulatedMouseEvents for iqiyi.com
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=260015
rdar://108958661

Reviewed by Brent Fulgham.

The quirk was introduced to allow interaction with the website on
first tap. After testing again, the current Quirk has no effect on
the usability of the site. The controls can be dragged for position
in the video or the volume of the audio, but they can be changed on
a simple tab both with/without the Quirk and fullscreen or not.

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):

Canonical link: https://commits.webkit.org/266774@main
  • Loading branch information
karlcow authored and Brent Fulgham committed Aug 10, 2023
1 parent bd5d32f commit b890f0f
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions Source/WebCore/page/Quirks.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,6 @@ bool Quirks::isGoogleMaps() const
// desmos.com rdar://47068176
// msn.com rdar://49403260
// flipkart.com rdar://49648520
// iqiyi.com rdar://53235709
// soundcloud.com rdar://52915981
// naver.com rdar://48068610
// mybinder.org rdar://51770057
Expand Down Expand Up @@ -412,8 +411,6 @@ bool Quirks::shouldDispatchSimulatedMouseEvents(const EventTarget* target) const
return ShouldDispatchSimulatedMouseEvents::Yes;
if (host == "flipkart.com"_s || host.endsWith(".flipkart.com"_s))
return ShouldDispatchSimulatedMouseEvents::Yes;
if (host == "iqiyi.com"_s || host.endsWith(".iqiyi.com"_s))
return ShouldDispatchSimulatedMouseEvents::Yes;
if (host == "trailers.apple.com"_s)
return ShouldDispatchSimulatedMouseEvents::Yes;
if (host == "soundcloud.com"_s)
Expand Down

0 comments on commit b890f0f

Please sign in to comment.